Devsh-Graphics-Programming · YasInvolved · Apr 11, 2025 · Apr 11, 2025 · Apr 25, 2025 · Apr 26, 2025
diff --git a/include/matrix3x4SIMD.h b/include/matrix3x4SIMD.h
@@ -59,9 +59,9 @@ class matrix3x4SIMD// : private AllocationOverrideBase<_NBL_MATRIX_ALIGNMENT> EB
 		inline matrix3x4SIMD& set(const matrix4x3& _retarded);
 		inline matrix4x3 getAsRetardedIrrlichtMatrix() const;
 
-		static inline matrix3x4SIMD concatenateBFollowedByA(const matrix3x4SIMD& _a, const matrix3x4SIMD& _b);
+		static matrix3x4SIMD concatenateBFollowedByA(const matrix3x4SIMD& _a, const matrix3x4SIMD& _b);
 
-		static inline matrix3x4SIMD concatenateBFollowedByAPrecisely(const matrix3x4SIMD& _a, const matrix3x4SIMD& _b);
+		static matrix3x4SIMD concatenateBFollowedByAPrecisely(const matrix3x4SIMD& _a, const matrix3x4SIMD& _b);
 
 		inline matrix3x4SIMD& concatenateAfter(const matrix3x4SIMD& _other)
 		{
@@ -88,7 +88,7 @@ class matrix3x4SIMD// : private AllocationOverrideBase<_NBL_MATRIX_ALIGNMENT> EB
 			return !(*this != _other);
 		}
 
-		inline bool operator!=(const matrix3x4SIMD& _other);
+		bool operator!=(const matrix3x4SIMD& _other);
 
 
 		inline matrix3x4SIMD operator-() const
@@ -101,21 +101,21 @@ class matrix3x4SIMD// : private AllocationOverrideBase<_NBL_MATRIX_ALIGNMENT> EB
 		}
 
 
-		inline matrix3x4SIMD& operator+=(const matrix3x4SIMD& _other);
+		matrix3x4SIMD& operator+=(const matrix3x4SIMD& _other);
 		inline matrix3x4SIMD operator+(const matrix3x4SIMD& _other) const
 		{
 			matrix3x4SIMD retval(*this);
 			return retval += _other;
 		}
 
-		inline matrix3x4SIMD& operator-=(const matrix3x4SIMD& _other);
+		matrix3x4SIMD& operator-=(const matrix3x4SIMD& _other);
 		inline matrix3x4SIMD operator-(const matrix3x4SIMD& _other) const
 		{
 			matrix3x4SIMD retval(*this);
 			return retval -= _other;
 		}
 
-		inline matrix3x4SIMD& operator*=(float _scalar);
+		matrix3x4SIMD& operator*=(float _scalar);
 		inline matrix3x4SIMD operator*(float _scalar) const
 		{
 			matrix3x4SIMD retval(*this);
@@ -137,19 +137,19 @@ class matrix3x4SIMD// : private AllocationOverrideBase<_NBL_MATRIX_ALIGNMENT> EB
 
 		inline vectorSIMDf getScale() const;
 
-		inline void transformVect(vectorSIMDf& _out, const vectorSIMDf& _in) const;
+		void transformVect(vectorSIMDf& _out, const vectorSIMDf& _in) const;
 		inline void transformVect(vectorSIMDf& _in_out) const
 		{
 			transformVect(_in_out, _in_out);
 		}
 
-		inline void pseudoMulWith4x1(vectorSIMDf& _out, const vectorSIMDf& _in) const;
+		void pseudoMulWith4x1(vectorSIMDf& _out, const vectorSIMDf& _in) const;
 		inline void pseudoMulWith4x1(vectorSIMDf& _in_out) const
 		{
 			pseudoMulWith4x1(_in_out,_in_out);
 		}
 
-		inline void mulSub3x3WithNx1(vectorSIMDf& _out, const vectorSIMDf& _in) const;
+		void mulSub3x3WithNx1(vectorSIMDf& _out, const vectorSIMDf& _in) const;
 		inline void mulSub3x3WithNx1(vectorSIMDf& _in_out) const
 		{
 			mulSub3x3WithNx1(_in_out, _in_out);
@@ -176,7 +176,7 @@ class matrix3x4SIMD// : private AllocationOverrideBase<_NBL_MATRIX_ALIGNMENT> EB
 			return determinant_helper(tmp);
 		}
 
-		inline bool getInverse(matrix3x4SIMD& _out) const;
+		bool getInverse(matrix3x4SIMD& _out) const;
 		bool makeInverse()
 		{
 			matrix3x4SIMD tmp;
@@ -190,7 +190,7 @@ class matrix3x4SIMD// : private AllocationOverrideBase<_NBL_MATRIX_ALIGNMENT> EB
 		}
 
 		//
-		inline bool getSub3x3InverseTranspose(matrix3x4SIMD& _out) const;
+		bool getSub3x3InverseTranspose(matrix3x4SIMD& _out) const;
 
 		//
 		inline bool getSub3x3InverseTransposePacked(float outRows[9]) const

diff --git a/include/matrix4SIMD.h b/include/matrix4SIMD.h
@@ -80,41 +80,41 @@ class matrix4SIMD// : public AlignedBase<_NBL_SIMD_ALIGNMENT> don't inherit from
 		inline float* pointer() {return rows[0].pointer;}
 
 
+		bool operator!=(const matrix4SIMD& _other) const;
 		inline bool operator==(const matrix4SIMD& _other) const
 		{
 			return !(*this != _other);
 		}
-		inline bool operator!=(const matrix4SIMD& _other) const;
 
-		inline matrix4SIMD& operator+=(const matrix4SIMD& _other);
+		matrix4SIMD& operator+=(const matrix4SIMD& _other);
 		inline matrix4SIMD operator+(const matrix4SIMD& _other) const
 		{
 			matrix4SIMD r{*this};
 			return r += _other;
 		}
 
-		inline matrix4SIMD& operator-=(const matrix4SIMD& _other);
+		matrix4SIMD& operator-=(const matrix4SIMD& _other);
 		inline matrix4SIMD operator-(const matrix4SIMD& _other) const
 		{
 			matrix4SIMD r{*this};
 			return r -= _other;
 		}
 
-		inline matrix4SIMD& operator*=(float _scalar);
+		matrix4SIMD& operator*=(float _scalar);
 		inline matrix4SIMD operator*(float _scalar) const
 		{
 			matrix4SIMD r{*this};
 			return r *= _scalar;
 		}
 
-		static inline matrix4SIMD concatenateBFollowedByA(const matrix4SIMD& _a, const matrix4SIMD& _b);
+		static matrix4SIMD concatenateBFollowedByA(const matrix4SIMD& _a, const matrix4SIMD& _b);
 		static inline matrix4SIMD concatenateBFollowedByAPrecisely(const matrix4SIMD& _a, const matrix4SIMD& _b);
 
 		inline bool isIdentity() const
 		{
 			return *this == matrix4SIMD();
 		}
-		inline bool isIdentity(float _tolerance) const;
+		bool isIdentity(float _tolerance) const;
 
 		inline bool isOrthogonal() const
 		{
@@ -125,7 +125,7 @@ class matrix4SIMD// : public AlignedBase<_NBL_SIMD_ALIGNMENT> don't inherit from
 			return concatenateBFollowedByA(transpose(*this), *this).isIdentity(_tolerance);
 		}
 
-		inline matrix4SIMD& setScale(const core::vectorSIMDf& _scale);
+		matrix4SIMD& setScale(const core::vectorSIMDf& _scale);
 		inline matrix4SIMD& setScale(float _scale)
 		{
 			return setScale(vectorSIMDf(_scale));
@@ -147,7 +147,7 @@ class matrix4SIMD// : public AlignedBase<_NBL_SIMD_ALIGNMENT> don't inherit from
 		}
 
 		//! Returns last column of the matrix.
-		inline vectorSIMDf getTranslation() const;
+		vectorSIMDf getTranslation() const;
 
 		//! Returns translation part of the matrix (w component is always 0).
 		inline vectorSIMDf getTranslation3D() const;
@@ -310,7 +310,7 @@ class matrix4SIMD// : public AlignedBase<_NBL_SIMD_ALIGNMENT> don't inherit from
 
 		inline vectorSIMDf sub3x3TransformVect(const vectorSIMDf& _in) const;
 
-		inline void transformVect(vectorSIMDf& _out, const vectorSIMDf& _in) const;
+		void transformVect(vectorSIMDf& _out, const vectorSIMDf& _in) const;
 		inline void transformVect(vectorSIMDf& _vector) const
 		{
 			transformVect(_vector, _vector);
@@ -379,7 +379,6 @@ inline matrix4SIMD concatenateBFollowedByAPrecisely(const matrix4SIMD& _a, const
 }
 */
 
-
 }} // nbl::core
 
 #endif
diff --git a/include/nbl/asset/ECommonEnums.h b/include/nbl/asset/ECommonEnums.h
@@ -220,7 +220,7 @@ inline core::bitflag<PIPELINE_STAGE_FLAGS> allPreviousStages(core::bitflag<PIPEL
                 for (size_t ix=0ull; ix<sizeof(size_t)*8; ix++)
                 if ((0x1ull<<ix)&val)
                     return ix;
-                return ~0u;
+                return static_cast<uint8_t>(~0u);
             }
             constexpr void add(PIPELINE_STAGE_FLAGS stageFlag, PIPELINE_STAGE_FLAGS previousStageFlags)
             {
@@ -278,7 +278,7 @@ inline core::bitflag<PIPELINE_STAGE_FLAGS> allLaterStages(core::bitflag<PIPELINE
                 for (size_t ix=0ull; ix<sizeof(size_t)*8; ix++)
                 if ((0x1ull<<ix)&val)
                     return ix;
-                return ~0u;
+                return static_cast<uint8_t>(~0u);
             }
             constexpr void add(PIPELINE_STAGE_FLAGS stageFlag, PIPELINE_STAGE_FLAGS laterStageFlags)
             {
@@ -362,7 +362,7 @@ inline core::bitflag<ACCESS_FLAGS> allAccessesFromStages(core::bitflag<PIPELINE_
                 for (size_t ix=0ull; ix<sizeof(size_t)*8; ix++)
                 if ((0x1ull<<ix)&val)
                     return ix;
-                return ~0u;
+                return static_cast<uint8_t>(~0u);
             }
             constexpr void init(PIPELINE_STAGE_FLAGS stageFlag, ACCESS_FLAGS accessFlags)
             {
@@ -449,7 +449,7 @@ inline core::bitflag<PIPELINE_STAGE_FLAGS> allStagesFromAccesses(core::bitflag<A
                 for (size_t ix=0ull; ix<sizeof(size_t)*8; ix++)
                 if ((0x1ull<<ix)&val)
                     return ix;
-                return ~0u;
+                return static_cast<uint8_t>(~0u);
             }
             constexpr void init(ACCESS_FLAGS accessFlags, PIPELINE_STAGE_FLAGS stageFlags)
             {

diff --git a/include/nbl/asset/ICPUGeometryCollection.h b/include/nbl/asset/ICPUGeometryCollection.h
@@ -81,7 +81,7 @@ class NBL_API2 ICPUGeometryCollection : public IAsset, public IGeometryCollectio
         template<typename Iterator>// requires std::is_same_v<decltype(*declval<Iterator>()),decltype(ICPUBottomLevelAccelerationStructure::Triangles&)>
         inline Iterator exportForBLAS(Iterator out, uint32_t* pWrittenOrdinals=nullptr) const
         {
-            return exportForBLAS(std::forward<Iterator>(out),[](const hlsl::float32_t3x4& lhs, const hlsl::float32_t3x4& rhs)->void
+            return exportForBLAS(std::forward<Iterator>(out),[this, &pWrittenOrdinals](hlsl::float32_t3x4& lhs, const hlsl::float32_t3x4& rhs)->void
                 {
                     lhs = rhs;
                     if (pWrittenOrdinals)

diff --git a/include/nbl/asset/filters/kernels/WeightFunctions.h b/include/nbl/asset/filters/kernels/WeightFunctions.h
@@ -4,6 +4,11 @@
 #include <limits>
 #include <cstdint>
 
+#ifdef __clang__
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wnan-infinity-disabled"
+#endif
+
 // move later if its useful for anything else
 namespace nbl::core::impl
 {
@@ -389,3 +394,7 @@ concept SimpleWeightFunction1D = requires(T t)
 
 } // end namespace nbl::asset
 #endif
+
+#ifdef __clang__
+#pragma clang diagnostic pop
+#endif
diff --git a/include/nbl/asset/utils/CGeometryCreator.h b/include/nbl/asset/utils/CGeometryCreator.h
@@ -25,7 +25,7 @@ class NBL_API2 CGeometryCreator final : public core::IReferenceCounted
 			core::smart_refctd_ptr<CQuantNormalCache> normalCache = nullptr;
 			core::smart_refctd_ptr<CQuantQuaternionCache> quaternionCache = nullptr;
 		};
-		inline CGeometryCreator(SCreationParams&& params={}) : m_params(std::move(params))
+		inline CGeometryCreator(SCreationParams&& params={ nullptr, nullptr }) : m_params(std::move(params))
 		{
 			if (!m_params.normalCache)
 				m_params.normalCache = core::make_smart_refctd_ptr<CQuantNormalCache>();

diff --git a/include/nbl/builtin/hlsl/ieee754.hlsl b/include/nbl/builtin/hlsl/ieee754.hlsl
@@ -105,7 +105,6 @@ NBL_CONSTEXPR_INLINE_FUNC T fastMulExp2(T x, int n)
 template <typename T>
 NBL_CONSTEXPR_INLINE_FUNC typename unsigned_integer_of_size<sizeof(T)>::type extractMantissa(T x)
 {
-	using AsUint = typename unsigned_integer_of_size<sizeof(T)>::type;
 	return ieee754::impl::bitCastToUintType(x) & traits<typename float_of_size<sizeof(T)>::type>::mantissaMask;
 }
 

diff --git a/include/nbl/core/alloc/AddressAllocatorBase.h b/include/nbl/core/alloc/AddressAllocatorBase.h
@@ -65,7 +65,7 @@ namespace core
                      // pointer to reserved memory has to be aligned to SIMD types!
                     assert((reinterpret_cast<size_t>(reservedSpace)&(_NBL_SIMD_ALIGNMENT-1u))==0ull);
                     assert(maxAllocatableAlignment);
-                    assert(core::isPoT(maxRequestableAlignment)); // this is not a proper alignment value
+                    assert(hlsl::isPoT(maxRequestableAlignment)); // this is not a proper alignment value
                 #endif // _NBL_DEBUG
             }
             AddressAllocatorBase(CRTP&& other, void* newReservedSpc)

diff --git a/include/nbl/core/hash/blake.h b/include/nbl/core/hash/blake.h
@@ -8,6 +8,9 @@
 
 #include <span>
 
+#define __NBL_CORE_BLAKE3_FUNCTION_STR(x) #x
+#define __NBL_CORE_BLAKE3_FUNCTION_STRINGIFY(x) __NBL_CORE_BLAKE3_FUNCTION_STR(x)
+
 namespace nbl::core
 {
 struct blake3_hash_t final
@@ -29,7 +32,8 @@ class NBL_API2 blake3_hasher final
 				// unfortunately there's no concept like StandardLayout or Aggregate for "just structs/classes of non-pointer types" so need to play it safe
 				constexpr bool ForbiddenType = std::is_compound_v<T> || std::is_enum_v<T> || std::is_class_v<T>;
 				// use __FUNCTION__ to print something with `T` to the error log
-				static_assert(!ForbiddenType, __FUNCTION__ "Hashing Specialization for this Type is not implemented!");
+
+				static_assert(!ForbiddenType, __NBL_CORE_BLAKE3_FUNCTION_STRINGIFY(__FUNCTION__) "Hashing Specialization for this Type is not implemented!");
 				hasher.update(&input,sizeof(input));
 			}
 		};
@@ -110,7 +114,7 @@ struct hash<nbl::core::blake3_hash_t>
 	{
 		auto* as_p_uint64_t = reinterpret_cast<const size_t*>(blake3.data);
 		size_t retval = as_p_uint64_t[0];
-		for (auto i=1; i<BLAKE3_OUT_LEN/sizeof(size_t); i++)
+		for (size_t i=1; i<BLAKE3_OUT_LEN/sizeof(size_t); i++)
 			retval ^= as_p_uint64_t[i] + 0x9e3779b97f4a7c15ull + (retval << 6) + (retval >> 2);
 		return retval;
 	}

diff --git a/include/nbl/core/math/floatutil.h b/include/nbl/core/math/floatutil.h
@@ -1,6 +1,11 @@
 // Copyright (C) 2018-2020 - DevSH Graphics Programming Sp. z O.O.
 // This file is part of the "Nabla Engine".
 // For conditions of distribution and use, see copyright notice in nabla.h
+#ifdef __clang__
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wnan-infinity-disabled"
+#endif
+
 #ifndef _NBL_CORE_FLOAT_UTIL_H_INCLUDED_
 #define _NBL_CORE_FLOAT_UTIL_H_INCLUDED_
 
@@ -361,3 +366,7 @@ uint32_t floatBitsToUint(float&& _f);
 }
 
 #endif
+
+#ifdef __clang__
+#pragma clang diagnostic pop
+#endif
diff --git a/include/nbl/core/memory/memory.h b/include/nbl/core/memory/memory.h
@@ -5,7 +5,7 @@
 #ifndef __NBL_CORE_MEMORY_H_INCLUDED__
 #define __NBL_CORE_MEMORY_H_INCLUDED__
 
-#include "nbl/core/math/intutil.h"
+#include "nbl/builtin/hlsl/math/intutil.hlsl"
 
 #include <typeinfo>
 #include <cstddef>
@@ -79,13 +79,13 @@ constexpr inline size_t alignDown(size_t value, size_t alignment)
 //! Valid alignments are power of two
 constexpr inline bool is_alignment(size_t value)
 {
-    return core::isPoT(value);
+    return hlsl::isPoT(value);
 }
 
 //!
 constexpr inline bool is_aligned_to(size_t value, size_t alignment)
 {
-    return core::isPoT(alignment)&&((value&(alignment-1ull))==0ull);
+    return hlsl::isPoT(alignment)&&((value&(alignment-1ull))==0ull);
 }
 // clang complains about constexpr so make normal for now (also complains abour reinterpret_cast)
 inline bool is_aligned_to(const void* value, size_t alignment)

diff --git a/include/nbl/core/util/bitflag.h b/include/nbl/core/util/bitflag.h
@@ -36,6 +36,7 @@ struct bitflag final
 	explicit constexpr operator bool() const {return bool(value);}
 	constexpr bool operator!=(const bitflag<ENUM_TYPE> rhs) const {return value!=rhs.value;}
 	constexpr bool operator==(const bitflag<ENUM_TYPE> rhs) const {return value==rhs.value;}
+	auto operator<=>(const bitflag<ENUM_TYPE>& rhs) const = default;
 	constexpr bool hasFlags(const bitflag<ENUM_TYPE> val) const {return (static_cast<UNDERLYING_TYPE>(value) & static_cast<UNDERLYING_TYPE>(val.value)) == static_cast<UNDERLYING_TYPE>(val.value);}
 	constexpr bool hasAnyFlag(const bitflag<ENUM_TYPE> val) const {return (static_cast<UNDERLYING_TYPE>(value) & static_cast<UNDERLYING_TYPE>(val.value)) != static_cast<UNDERLYING_TYPE>(0);}
 };

diff --git a/include/nbl/nblpack.h b/include/nbl/nblpack.h
@@ -12,9 +12,10 @@
 #if defined(_MSC_VER) || defined(__GNUC__) || defined(__clang__)
 #	ifdef _MSC_VER
 #		pragma warning(disable: 4103)
-#	elif defined(__clang__)
-#		pragma clang diagnostic ignored "-Wpragma-pack"
 #	endif
+#	ifdef __clang__
+#		pragma clang diagnostic ignored "-Wpragma-pack"
+#  endif
 #		pragma pack( push, packing )
 #		pragma pack( 1 )
 // TODO: Remove PACK_STRUCT from the engine

diff --git a/include/nbl/system/IAsyncQueueDispatcher.h b/include/nbl/system/IAsyncQueueDispatcher.h
@@ -3,6 +3,8 @@
 
 #include "nbl/core/declarations.h"
 
+#include "nbl/builtin/hlsl/math/intutil.hlsl"
+
 #include "nbl/system/IThreadHandler.h"
 #include "nbl/system/atomic_state.h"
 
@@ -416,7 +418,7 @@ template<typename CRTP, typename request_metadata_t, uint32_t BufferSize=256u, t
 class IAsyncQueueDispatcher : public IThreadHandler<CRTP,InternalStateType>, protected impl::IAsyncQueueDispatcherBase
 {
         static_assert(BufferSize>0u, "BufferSize must not be 0!");
-        static_assert(core::isPoT(BufferSize), "BufferSize must be power of two!");
+        static_assert(hlsl::isPoT(BufferSize), "BufferSize must be power of two!");
 
     protected:
         using base_t = IThreadHandler<CRTP,InternalStateType>;

diff --git a/include/nbl/system/IFileArchive.h b/include/nbl/system/IFileArchive.h
@@ -142,7 +142,7 @@ class IFileArchive : public core::IReferenceCounted
 
 		inline const SFileList::found_t getItemFromPath(const system::path& pathRelativeToArchive) const
 		{
-            const SFileList::SEntry itemToFind = { pathRelativeToArchive };
+			const SFileList::SEntry itemToFind = { pathRelativeToArchive, 0ull, 0ull , 0u, EAT_NULL };
 			// calling `listAssets` makes sure any "update list" overload can kick in
 			auto items = listAssets();
 			const auto span = SFileList::span_t(items);

diff --git a/include/nbl/system/IFileBase.h b/include/nbl/system/IFileBase.h
@@ -81,7 +81,7 @@ class IFileBase : public core::IReferenceCounted
 
 		// this is an abstract interface class so this stays protected
 		explicit IFileBase(path&& _filename, const core::bitflag<E_CREATE_FLAGS> _flags, const time_point_t _initialModified) :
-			m_filename(std::move(_filename)), m_flags(_flags), m_modified(_initialModified) {}
+			m_filename(std::move(_filename)), m_modified(_initialModified), m_flags(_flags) {}
 
 	private:
 		const path m_filename;