Hlsl path tracer example #863
There are no files selected for viewing
Submodule examples_tests
updated
26 files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| // Copyright (C) 2018-2023 - DevSH Graphics Programming Sp. z O.O. | ||
| // This file is part of the "Nabla Engine". | ||
| // For conditions of distribution and use, see copyright notice in nabla.h | ||
| #ifndef _NBL_BUILTIN_HLSL_MATH_MORTON_INCLUDED_ | ||
| #define _NBL_BUILTIN_HLSL_MATH_MORTON_INCLUDED_ | ||
|
|
||
| #include "nbl/builtin/hlsl/cpp_compat.hlsl" | ||
|
|
||
| namespace nbl | ||
| { | ||
| namespace hlsl | ||
| { | ||
| namespace math | ||
| { | ||
|
|
||
| namespace impl | ||
| { | ||
|
|
||
| template<typename T, uint32_t bitDepth> | ||
| struct MortonComponent; | ||
|
|
||
| template<typename T> | ||
| struct MortonComponent<T, 8u> | ||
| { | ||
| static T decode2d(T x) | ||
| { | ||
| x &= 0x55555555u; | ||
| x = (x ^ (x >> 1u)) & 0x33333333u; | ||
| x = (x ^ (x >> 2u)) & 0x0f0f0f0fu; | ||
| x = (x ^ (x >> 4u)) & 0x00ff00ffu; | ||
| return x; | ||
| } | ||
| }; | ||
|
|
||
| template<typename T> | ||
| struct MortonComponent<T, 32u> | ||
| { | ||
| static T decode2d(T x) | ||
| { | ||
| x &= 0x55555555u; | ||
| x = (x ^ (x >> 1u)) & 0x33333333u; | ||
| x = (x ^ (x >> 2u)) & 0x0f0f0f0fu; | ||
| x = (x ^ (x >> 4u)) & 0x00ff00ffu; | ||
| x = (x ^ (x >> 8u)) & 0x0000ffffu; | ||
| x = (x ^ (x >> 16u)); | ||
| return x; | ||
| } | ||
| }; | ||
|
|
||
| } | ||
|
|
||
| template<typename T, uint32_t bitDepth=sizeof(T)*8u> | ||
| struct Morton | ||
| { | ||
| using vector2_type = vector<T, 2>; | ||
| using component_type = impl::MortonComponent<T, bitDepth>; | ||
|
|
||
| static vector2_type decode2d(T x) | ||
| { | ||
| return vector2_type(component_type::decode2d(x), component_type::decode2d(x >> 1u)); | ||
| } | ||
| }; | ||
|
|
||
| } | ||
| } | ||
| } | ||
|
|
||
| #endif | ||
|
Comment on lines
+1
to
+68
There was a problem hiding this comment. file will die after #860 is merged |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| // Copyright (C) 2018-2023 - DevSH Graphics Programming Sp. z O.O. | ||
| // This file is part of the "Nabla Engine". | ||
| // For conditions of distribution and use, see copyright notice in nabla.h | ||
|
|
||
| #ifndef _NBL_BUILTIN_HLSL_SAMPLING_BILINEAR_INCLUDED_ | ||
| #define _NBL_BUILTIN_HLSL_SAMPLING_BILINEAR_INCLUDED_ | ||
|
|
||
| #include <nbl/builtin/hlsl/cpp_compat.hlsl> | ||
| #include <nbl/builtin/hlsl/limits.hlsl> | ||
| #include <nbl/builtin/hlsl/sampling/linear.hlsl> | ||
|
|
||
| namespace nbl | ||
| { | ||
| namespace hlsl | ||
| { | ||
| namespace sampling | ||
| { | ||
|
|
||
| template<typename T> | ||
| struct Bilinear | ||
| { | ||
| using scalar_type = T; | ||
| using vector2_type = vector<T, 2>; | ||
| using vector3_type = vector<T, 3>; | ||
| using vector4_type = vector<T, 4>; | ||
|
|
||
| static Bilinear<T> create(NBL_CONST_REF_ARG(vector4_type) bilinearCoeffs) | ||
| { | ||
| Bilinear<T> retval; | ||
| retval.bilinearCoeffs = bilinearCoeffs; | ||
| return retval; | ||
| } | ||
|
|
||
| vector2_type generate(NBL_REF_ARG(scalar_type) rcpPdf, NBL_CONST_REF_ARG(vector2_type) _u) | ||
|
There was a problem hiding this comment. we need some structs like template<typename V, typename P=float>
struct ValueAndPdf;
template<typename T, typename P=float>
struct ValueAndRcpPdf;in do as part of #811 P.S. can require that |
||
| { | ||
| vector2_type u = _u; | ||
| const vector2_type twiceAreasUnderXCurve = vector2_type(bilinearCoeffs[0] + bilinearCoeffs[1], bilinearCoeffs[2] + bilinearCoeffs[3]); | ||
| Linear<scalar_type> lineary = Linear<scalar_type>::create(twiceAreasUnderXCurve); | ||
| u.y = lineary.generate(u.y); | ||
|
|
||
| const vector2_type ySliceEndPoints = vector2_type(nbl::hlsl::mix(bilinearCoeffs[0], bilinearCoeffs[2], u.y), nbl::hlsl::mix(bilinearCoeffs[1], bilinearCoeffs[3], u.y)); | ||
| Linear<scalar_type> linearx = Linear<scalar_type>::create(ySliceEndPoints); | ||
| u.x = linearx.generate(u.x); | ||
|
|
||
| rcpPdf = (twiceAreasUnderXCurve[0] + twiceAreasUnderXCurve[1]) / (4.0 * nbl::hlsl::mix(ySliceEndPoints[0], ySliceEndPoints[1], u.x)); | ||
|
|
||
| return u; | ||
| } | ||
|
|
||
| scalar_type pdf(NBL_CONST_REF_ARG(vector2_type) u) | ||
| { | ||
| return 4.0 * nbl::hlsl::mix(nbl::hlsl::mix(bilinearCoeffs[0], bilinearCoeffs[1], u.x), nbl::hlsl::mix(bilinearCoeffs[2], bilinearCoeffs[3], u.x), u.y) / (bilinearCoeffs[0] + bilinearCoeffs[1] + bilinearCoeffs[2] + bilinearCoeffs[3]); | ||
| } | ||
|
|
||
| vector4_type bilinearCoeffs; | ||
|
There was a problem hiding this comment. document which index/component maps to which vertex of the unit square |
||
| }; | ||
|
|
||
| } | ||
| } | ||
| } | ||
|
|
||
| #endif | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| // Copyright (C) 2018-2023 - DevSH Graphics Programming Sp. z O.O. | ||
| // This file is part of the "Nabla Engine". | ||
| // For conditions of distribution and use, see copyright notice in nabla.h | ||
|
|
||
| #ifndef _NBL_BUILTIN_HLSL_BOX_MULLER_TRANSFORM_INCLUDED_ | ||
| #define _NBL_BUILTIN_HLSL_BOX_MULLER_TRANSFORM_INCLUDED_ | ||
|
|
||
| #include "nbl/builtin/hlsl/math/functions.hlsl" | ||
| #include "nbl/builtin/hlsl/numbers.hlsl" | ||
|
|
||
| namespace nbl | ||
| { | ||
| namespace hlsl | ||
| { | ||
|
|
||
| template<typename T> | ||
| vector<T,2> boxMullerTransform(vector<T,2> xi, T stddev) | ||
| { | ||
| T sinPhi, cosPhi; | ||
| math::sincos<T>(2.0 * numbers::pi<float> * xi.y - numbers::pi<float>, sinPhi, cosPhi); | ||
| return vector<T,2>(cosPhi, sinPhi) * nbl::hlsl::sqrt(-2.0 * nbl::hlsl::log(xi.x)) * stddev; | ||
| } | ||
|
Comment on lines
+16
to
+22
There was a problem hiding this comment. turn into struct with |
||
|
|
||
| } | ||
| } | ||
|
|
||
| #endif | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| // Copyright (C) 2018-2023 - DevSH Graphics Programming Sp. z O.O. | ||
| // This file is part of the "Nabla Engine". | ||
| // For conditions of distribution and use, see copyright notice in nabla.h | ||
|
|
||
| #ifndef _NBL_BUILTIN_HLSL_SAMPLING_LINEAR_INCLUDED_ | ||
| #define _NBL_BUILTIN_HLSL_SAMPLING_LINEAR_INCLUDED_ | ||
|
|
||
| #include <nbl/builtin/hlsl/cpp_compat.hlsl> | ||
| #include <nbl/builtin/hlsl/limits.hlsl> | ||
|
|
||
| namespace nbl | ||
| { | ||
| namespace hlsl | ||
| { | ||
| namespace sampling | ||
| { | ||
|
|
||
| template<typename T> | ||
| struct Linear | ||
| { | ||
| using scalar_type = T; | ||
| using vector2_type = vector<T, 2>; | ||
|
|
||
| static Linear<T> create(NBL_CONST_REF_ARG(vector2_type) linearCoeffs) | ||
| { | ||
| Linear<T> retval; | ||
| retval.linearCoeffs = linearCoeffs; | ||
| return retval; | ||
| } | ||
|
|
||
| scalar_type generate(scalar_type u) | ||
| { | ||
| const scalar_type rcpDiff = 1.0 / (linearCoeffs[0] - linearCoeffs[1]); | ||
| const vector2_type squaredCoeffs = linearCoeffs * linearCoeffs; | ||
| return nbl::hlsl::abs(rcpDiff) < numeric_limits<scalar_type>::max ? (linearCoeffs[0] - nbl::hlsl::sqrt(nbl::hlsl::mix(squaredCoeffs[0], squaredCoeffs[1], u))) * rcpDiff : u; | ||
| } | ||
|
|
||
| vector2_type linearCoeffs; | ||
| }; | ||
|
|
||
| } | ||
| } | ||
| } | ||
|
|
||
| #endif |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be templated on
Tinstead offloatand live insampling.hlsl(named same as the folder and namespace), do as part of #811P.S. for the constant you can use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or you can put it in
sampling/basic.hlsl