Skip to content

Commit 69b5c24

Browse files
committed
fix awful nabla config header search path ambiguity bug, uh this shit nbl_create_ext_library_project requires a refactor
TODO: inspect why the f this extension library creation macro affected part of interface chain and influenced all examples & common api targets
1 parent 38b2d98 commit 69b5c24

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

cmake/common.cmake

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -231,17 +231,9 @@ macro(nbl_create_ext_library_project EXT_NAME LIB_HEADERS LIB_SOURCES LIB_INCLUD
231231
project(${LIB_NAME})
232232

233233
add_library(${LIB_NAME} ${LIB_SOURCES})
234-
get_target_property(_NBL_NABLA_TARGET_BINARY_DIR_ Nabla BINARY_DIR)
235234

236-
# TODO: correct those bugs, use generator expressions
237235
target_include_directories(${LIB_NAME}
238-
PUBLIC ${_NBL_NABLA_TARGET_BINARY_DIR_}/build/import
239-
PUBLIC ${CMAKE_BINARY_DIR}/include/nbl/config/debug
240-
PUBLIC ${CMAKE_BINARY_DIR}/include/nbl/config/release
241-
PUBLIC ${CMAKE_BINARY_DIR}/include/nbl/config/relwithdebinfo
242-
PUBLIC ${CMAKE_SOURCE_DIR}/include
243-
PUBLIC ${CMAKE_SOURCE_DIR}/src
244-
PUBLIC ${CMAKE_SOURCE_DIR}/source/Nabla
236+
PUBLIC $<TARGET_PROPERTY:Nabla,INCLUDE_DIRECTORIES>
245237
PRIVATE ${LIB_INCLUDES}
246238
)
247239

0 commit comments

Comments
 (0)