Apparently Nabla, Examples Common PCH, and Example can't agree on the value of _NBL_DEBUG !?

Author: devshgraphicsprogramming

include/nbl/video/alloc/CAsyncSingleBufferSubAllocator.h

@@ -21,7 +21,7 @@ template<class AddressAllocator, class HostAllocator>
 class CAsyncSingleBufferSubAllocator
 {
     private:
-        #ifdef _NBL_DEBUG
+        #if 0 // ifdef _NBL_DEBUG
         std::recursive_mutex stAccessVerfier;
         #endif // _NBL_DEBUG
         using ThisType = CAsyncSingleBufferSubAllocator<AddressAllocator,HostAllocator>;
@@ -102,7 +102,7 @@ class CAsyncSingleBufferSubAllocator
                 inline void operator()()
                 {
                     std::destroy_n(reinterpret_cast<ref_t*>(rangeData+numAllocs*2u),numAllocs);
-                    #ifdef _NBL_DEBUG
+                    #if 0 // ifdef _NBL_DEBUG
                     assert(composed && rangeData);
                     #endif // _NBL_DEBUG
                     composed->multi_deallocate(numAllocs,rangeData,rangeData+numAllocs);
@@ -130,7 +130,7 @@ class CAsyncSingleBufferSubAllocator
         //! Returns free events still outstanding
         inline uint32_t cull_frees() noexcept
         {
-            #ifdef _NBL_DEBUG
+            #if 0 // ifdef _NBL_DEBUG
             std::unique_lock<std::recursive_mutex> tLock(stAccessVerfier,std::try_to_lock_t());
             assert(tLock.owns_lock());
             #endif // _NBL_DEBUG
@@ -140,7 +140,7 @@ class CAsyncSingleBufferSubAllocator
         //! Returns max possible currently allocatable single allocation size, without having to wait for GPU more
         inline size_type max_size() noexcept
         {
-            #ifdef _NBL_DEBUG
+            #if 0 // ifdef _NBL_DEBUG
             std::unique_lock<std::recursive_mutex> tLock(stAccessVerfier,std::try_to_lock_t());
             assert(tLock.owns_lock());
             #endif // _NBL_DEBUG
@@ -161,7 +161,7 @@ class CAsyncSingleBufferSubAllocator
         template<class Clock=typename std::chrono::steady_clock, typename... Args>
         inline size_type multi_allocate(const std::chrono::time_point<Clock>& maxWaitPoint, const Args&... args) noexcept
         {
-            #ifdef _NBL_DEBUG
+            #if 0 // ifdef _NBL_DEBUG
             std::unique_lock<std::recursive_mutex> tLock(stAccessVerfier,std::try_to_lock_t());
             assert(tLock.owns_lock());
             #endif // _NBL_DEBUG
@@ -187,15 +187,15 @@ class CAsyncSingleBufferSubAllocator
         //!
         inline void multi_deallocate(core::smart_refctd_ptr<IGPUFence>&& fence, DeferredFreeFunctor&& functor) noexcept
         {
-            #ifdef _NBL_DEBUG
+            #if 0 // ifdef _NBL_DEBUG
             std::unique_lock<std::recursive_mutex> tLock(stAccessVerfier,std::try_to_lock_t());
             assert(tLock.owns_lock());
             #endif // _NBL_DEBUG
             deferredFrees.addEvent(GPUEventWrapper(const_cast<ILogicalDevice*>(m_composed.getBuffer()->getOriginDevice()),std::move(fence)),std::move(functor));
         }
         inline void multi_deallocate(uint32_t count, const value_type* addr, const size_type* bytes) noexcept
         {
-            #ifdef _NBL_DEBUG
+            #if 0 // ifdef _NBL_DEBUG
             std::unique_lock<std::recursive_mutex> tLock(stAccessVerfier,std::try_to_lock_t());
             assert(tLock.owns_lock());
             #endif // _NBL_DEBUG

include/nbl/video/alloc/CSingleBufferSubAllocator.h

@@ -88,7 +88,7 @@ class CSingleBufferSubAllocator : public IBufferAllocator
     protected:
         AddressAllocator                    m_addressAllocator;
         ReservedAllocator                   m_reservedAllocator;
-        size_t                              m_reservedSize;
+        size_t                              m_reservedSize; // FIXME: uninitialized variable
         core::smart_refctd_ptr<IGPUBuffer>  m_buffer;
 };