Skip to content

Commit 0a2c1a2

Browse files
add notes about renderdoc and make ex 24 shader use using namespace
1 parent c3bbe08 commit 0a2c1a2

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

07_StagingAndMultipleQueues/main.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -465,7 +465,8 @@ class StagingAndMultipleQueuesApp final : public application_templates::BasicMul
465465
// Some Devices like all of the Intel GPUs do not have enough queues for us to allocate different queues to compute and transfers,
466466
// so our `BasicMultiQueueApplication` will "alias" a single queue to both usages. Normally you don't need to care, but here we're
467467
// attempting to do "out-of-order" "submit-before-signal" so we need to "hold back" submissions if the queues are aliased!
468-
if (getTransferUpQueue()==computeQueue)
468+
// TODO: Renderdoc freezes because it starts capturing immediately upon a submit and can't defer a capture till semaphores signal.
469+
if (getTransferUpQueue()==computeQueue /*|| m_api->isRunningInRenderdoc()*/)
469470
for (auto old = transfersSubmitted.load(); old <= imageToProcessId; old = transfersSubmitted.load())
470471
transfersSubmitted.wait(old);
471472
computeQueue->submit(submitInfo);

24_ColorSpaceTest/app_resources/present.frag.hlsl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,12 @@
55

66
// vertex shader is provided by the fullScreenTriangle extension
77
#include <nbl/builtin/hlsl/ext/FullScreenTriangle/SVertexAttributes.hlsl>
8+
using namespace nbl::hlsl::ext::FullScreenTriangle;
89

910
[[vk::combinedImageSampler]][[vk::binding(0,3)]] Texture2DArray texture;
1011
[[vk::combinedImageSampler]][[vk::binding(0,3)]] SamplerState samplerState;
1112

12-
[[vk::location(0)]] float32_t4 main(nbl::hlsl::ext::FullScreenTriangle::SVertexAttributes vxAttr) : SV_Target0
13+
[[vk::location(0)]] float32_t4 main(SVertexAttributes vxAttr) : SV_Target0
1314
{
1415
return texture.SampleLevel(samplerState,float32_t3(vxAttr.uv,0.f),0.0);
1516
}

0 commit comments

Comments
 (0)