Skip to content

Commit c3bbe08

Browse files
a new TODO for @Fletterio
1 parent a5c1182 commit c3bbe08

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

07_StagingAndMultipleQueues/main.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,13 +56,16 @@ class StagingAndMultipleQueuesApp final : public application_templates::BasicMul
5656

5757
// TODO: create/initialize array of atomic pointers to IGPUImage* and IGPUBuffer* to hold results
5858

59+
// TODO: Change the capture start/end to become methods of IAPIConnection, because our current API is not how renderdoc works
60+
getComputeQueue()->startCapture();
5961
std::thread loadImagesThread(&StagingAndMultipleQueuesApp::loadImages, this);
6062
std::thread saveHistogramsThread(&StagingAndMultipleQueuesApp::saveHistograms, this);
6163

6264
calculateHistograms();
6365

6466
loadImagesThread.join();
6567
saveHistogramsThread.join();
68+
getComputeQueue()->endCapture();
6669

6770
return true;
6871
}
@@ -246,11 +249,9 @@ class StagingAndMultipleQueuesApp final : public application_templates::BasicMul
246249
// cannot signal from COPY stage because there's a layout transition we need to wait for right after and it doesn't have an explicit stage
247250
.stageMask=PIPELINE_STAGE_FLAGS::ALL_COMMANDS_BITS
248251
};
249-
transferUpQueue->startCapture();
250252
getTransferUpQueue()->submit(intendedSubmit.popSubmit({&signalSemaphore,1}));
251253
transfersSubmitted++;
252254
transfersSubmitted.notify_one();
253-
transferUpQueue->endCapture();
254255

255256

256257
// TODO: this is for basic testing purposes, will be deleted ofc
@@ -467,9 +468,7 @@ class StagingAndMultipleQueuesApp final : public application_templates::BasicMul
467468
if (getTransferUpQueue()==computeQueue)
468469
for (auto old = transfersSubmitted.load(); old <= imageToProcessId; old = transfersSubmitted.load())
469470
transfersSubmitted.wait(old);
470-
computeQueue->startCapture();
471471
computeQueue->submit(submitInfo);
472-
computeQueue->endCapture();
473472
std::string msg = std::string("Image nr ") + std::to_string(imageToProcessId) + " processed. Resource idx: " + std::to_string(resourceIdx);
474473
m_logger->log(msg);
475474
}

0 commit comments

Comments
 (0)