feat(connector):Add ironrdp-vmconnector crate, integrated into existing ironrdp-client and ironrdp async #841
Conversation
|
@irvingoujAtDevolution I don’t remember very well. What is different from the previous version? |
|
@CBenoit |
| pub async fn run_until_handover( | ||
| credssp_finished: &mut CredSSPFinished, | ||
| framed: &mut Framed<impl FramedRead + FramedWrite>, | ||
| mut connector: VmClientConnector, | ||
| ) -> ConnectorResult<ClientConnector> { | ||
| let result = loop { | ||
| single_sequence_step(framed, &mut connector, &mut credssp_finished.write_buf).await?; | ||
|
|
||
| if connector.should_hand_over() { | ||
| break connector.hand_over(); | ||
| } | ||
| }; | ||
|
|
||
| info!("Handover to client connector"); | ||
| credssp_finished.write_buf.clear(); |
There was a problem hiding this comment.
question: Is handover a terminology used by VMConnect protocol?
There was a problem hiding this comment.
Not really, it's only make sense in this context
|
We were having CredSSP issues on enhanced mode, I intend to have that support in separate pull request. |
Coverage Report 🤖 ⚙️Past: New: Diff: -0.66% [this comment will be updated automatically] |
irvingoujAtDevolution
force-pushed
the
vmconnect-use-vmconnector
branch
2 times, most recently
from
e28091e to
349b21f
Compare
irvingoujAtDevolution
force-pushed
the
vmconnect-use-vmconnector
branch
from
082acb5 to
69264ff
Compare
Hello @CBenoit , I added dynamically dispatched trait for hyperv connector and normal connectors. The main drive is to avoid copy and paste in previous version. I did it this is way is also to reuse existing code as much as possible, instead of copy each and every method and add a _vmconnect suffix. This might not be the best solution, let me know your thoughts.