fix: replace axios with fetch #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @jsalaber - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Hardcoded secret detected in Authorization header. (link)
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🔴 Security: 1 blocking issue
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| const writeStream = tar.x({ cwd: OUTPUT_DIR }) | ||
| const response = await axios.get(sourceUrl, { | ||
| responseType: 'stream', | ||
| const response = await fetch(sourceUrl, { |
There was a problem hiding this comment.
suggestion: Validate the response status code from fetch to ensure the stream is valid.
Checking the response status before processing the stream can prevent issues related to unexpected response statuses, such as 404 or 500 errors.
jsalaber
force-pushed
the
COR-2754-replace-axios-with-fetch
branch
from
38238d0 to
357827c
Compare
kaushalkapasi
approved these changes
May 15, 2024
jsalaber
force-pushed
the
COR-2754-replace-axios-with-fetch
branch
from
357827c to
fa2e903
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes