Add action to update vscode extension with latest version #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @emmawillis - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Use inputs.latest_tag instead of $LATEST_TAG (link)
Here's what I looked at during the review
- 🔴 General issues: 1 blocking issue, 1 other issue
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| working-directory: vscode-extension | ||
| env: | ||
| GH_TOKEN: ${{ inputs.access_token }} | ||
| run: gh pr create --repo DevCycleHQ/vscode-extension --base main --head "$BRANCH_NAME" --title "Update CLI version to $LATEST_TAG" --body "This PR was automatically created by the DevCycle CLI release workflow." |
There was a problem hiding this comment.
issue (bug_risk): Use inputs.latest_tag instead of $LATEST_TAG
The variable $LATEST_TAG is not defined in this context. It should be replaced with ${{ inputs.latest_tag }} to ensure the correct value is used.
| - name: Push code to extension repo | ||
| shell: bash | ||
| working-directory: vscode-extension | ||
| run: git push --set-upstream origin "$BRANCH_NAME" |
There was a problem hiding this comment.
suggestion: Consider adding error handling for git push
Adding error handling for the git push command can help catch and handle any issues that might occur during the push operation, ensuring the workflow does not fail silently.
Suggested change
| run: git push --set-upstream origin "$BRANCH_NAME" | |
| run: | | |
| set -e | |
| git push --set-upstream origin "$BRANCH_NAME" || { | |
| echo "Error: Failed to push code to the repository." | |
| exit 1 | |
| } |
emmawillis
force-pushed
the
update-vscode-version
branch
from
bf18c6f to
a401a1d
Compare
emmawillis
force-pushed
the
update-vscode-version
branch
5 times, most recently
from
1f0554c to
03043c8
Compare
emmawillis
force-pushed
the
update-vscode-version
branch
from
03043c8 to
471eed0
Compare
jsalaber
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the extension calls
cliUtils.loadCli()when it activates, which downloads the CLI based on the version defined inconstants.ts, so i think it should be sufficient just to update the version defined thereI set this to only run if the version bump is minor or patch
tested: DevCycleHQ/vscode-extension#291