-
Notifications
You must be signed in to change notification settings - Fork 1.7k
🎉 Add Xeol parser #12816 #12846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: bugfix
Are you sure you want to change the base?
🎉 Add Xeol parser #12816 #12846
Conversation
No security concerns detected in this pull request. All finding details can be found in the DryRun Security Dashboard. |
@Kasyap7 fyi |
dynamic_finding=False, | ||
unique_id_from_tool=matches.get("ProductPermalink", None), | ||
nb_occurences=1, | ||
references=matches.get("ProductPermalink", ""), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could there be a link to the Xeol explorer instead: https://www.xeol.io/explorer (it's seem down at the moment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still down. Shall I leave it like this?
testfile.close() | ||
self.assertEqual(1, len(findings)) | ||
finding = list(findings)[0] | ||
self.assertEqual(finding.severity, "Info") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add a couple more asserts, component name is important and version as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for the response in #12816 to extend the tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the earlier confusion — the JSON file I initially shared was a custom-transformed version of the Xeol output, not the native format produced by the tool. I've now updated the issue with a sample of the actual Xeol output and included files representing zero finding, one finding, and multiple findings for reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR! Some small items commented.
Co-authored-by: valentijnscholten <valentijnscholten@gmail.com>
#12816