Skip to content

🎉 Add Xeol parser #12816 #12846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: bugfix
Choose a base branch
from

Conversation

manuel-sommer
Copy link
Contributor

@manuel-sommer manuel-sommer commented Jul 23, 2025

Copy link

dryrunsecurity bot commented Jul 23, 2025

DryRun Security

No security concerns detected in this pull request.


All finding details can be found in the DryRun Security Dashboard.

@github-actions github-actions bot added the docs label Jul 23, 2025
@manuel-sommer
Copy link
Contributor Author

@Kasyap7 fyi

dynamic_finding=False,
unique_id_from_tool=matches.get("ProductPermalink", None),
nb_occurences=1,
references=matches.get("ProductPermalink", ""),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could there be a link to the Xeol explorer instead: https://www.xeol.io/explorer (it's seem down at the moment).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still down. Shall I leave it like this?

testfile.close()
self.assertEqual(1, len(findings))
finding = list(findings)[0]
self.assertEqual(finding.severity, "Info")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a couple more asserts, component name is important and version as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for the response in #12816 to extend the tests

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the earlier confusion — the JSON file I initially shared was a custom-transformed version of the Xeol output, not the native format produced by the tool. I've now updated the issue with a sample of the actual Xeol output and included files representing zero finding, one finding, and multiple findings for reference.

Copy link
Member

@valentijnscholten valentijnscholten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR! Some small items commented.

manuel-sommer and others added 2 commits July 23, 2025 12:57
Co-authored-by: valentijnscholten <valentijnscholten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants