forked from aws-samples/bedrock-access-gateway
-
Notifications
You must be signed in to change notification settings - Fork 0
Handle Anthropic messages as if they were chat/completions #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nullfunc
merged 14 commits into
defang
from
eric-update-to-allow-non-chat-completion-apis
Jun 5, 2025
Merged
Handle Anthropic messages as if they were chat/completions #19
nullfunc
merged 14 commits into
defang
from
eric-update-to-allow-non-chat-completion-apis
Jun 5, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jordanstephens please have a look. updated from our discussion earlier. |
Co-authored-by: Jordan Stephens <jordan@stephens.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two quick thoughts
Co-authored-by: Jordan Stephens <jordan@stephens.io>
jordanstephens
approved these changes
Jun 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple small naming suggestions
Co-authored-by: Jordan Stephens <jordan@stephens.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Update gateway to handler chat/complete for gemini and anthropic. For anthropic, the request message is transformed to one claude will understand. The REST endpoint will also point to the specific model's. The response is transformed into an openai chat/completion response format to the UI does not need to handle Anthropic Claude models differently.
The app.py entry point is also cleaned up, the GCP message handling is put into it's own file. This should help facilitate upstream changes from the project repo this gateway was forked from.