GHA for push to docker.io #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nullfunc
temporarily deployed
to
AWS_ROLE_TO_ASSUME
GitHub Actions
Inactive
nullfunc
temporarily deployed
to
AWS_ROLE_TO_ASSUME
GitHub Actions
Inactive
nullfunc
changed the title
jordanstephens
requested changes
Jun 2, 2025
| - "v*" # push events to tagged commits | ||
| branches: | ||
| - "**" | ||
| workflow_dispatch: |
There was a problem hiding this comment.
Why did you make this change? I think automatically pushing to docker.io on each merge todefang is a good idea.
Why shouldn't we do something like this?
Suggested change
| workflow_dispatch: | |
| push: | |
| tags: | |
| - "v*" # push events to tagged commits | |
| branches: | |
| - "defang" |
There was a problem hiding this comment.
I am reluctant to have this auto push until we have a test in place.
There was a problem hiding this comment.
end to end test. The fact that we have to handle differences between anthropic and gemini makes me think regressions will go undetected if we automate pushing.
| if: startsWith(github.ref, 'refs/tags/v') # only run this step on tagged commits | ||
| make-images: | ||
| name: Make Docker Images and Push To Registry | ||
| if: github.ref == 'refs/heads/defang' |
There was a problem hiding this comment.
This is implied by the suggestion above, so it could be removed here
Suggested change
| if: github.ref == 'refs/heads/defang' |
nullfunc
temporarily deployed
to
AWS_ROLE_TO_ASSUME
GitHub Actions
Inactive
jordanstephens
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update GHA to allow manual triggering of action to docker.io