Test AWS BYOC log stream handling #812
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanstephens
force-pushed
the
jordan/byoc-build-logs
branch
3 times, most recently
from
3122131 to
094170d
Compare
jordanstephens
changed the title
jordanstephens
force-pushed
the
jordan/byoc-build-logs
branch
from
094170d to
fe6a2eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring
byocServerStreamto make it easier to test handling of the different log streams scenarios.The strategy is first to derive a
TailResponseHeaderwith a particularSSModeand then use that mode to guard the different handling scenarios when constructing the actualTailResponse. I split up this logic so we could test them separately.I also made one big change in this diff: I removed a client-side filter which checked each log entry for mismatched etags or service names. This is no longer necessary. All log entries for a given stream will belong to the same etag and service.