Skip to content

Add account id to BYOC delegate domain name #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

edwardrf
Copy link
Contributor

No description provided.

@edwardrf edwardrf requested a review from lionello August 21, 2024 20:50
@edwardrf edwardrf added the wip Work in progress; don't merge label Aug 21, 2024
@edwardrf edwardrf marked this pull request as draft August 21, 2024 20:50
Copy link
Member

@lionello lionello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Longer term, we should probably create a random subdomain, like CloudFront and DigitalOcean do.

@edwardrf edwardrf requested a review from lionello August 21, 2024 23:00
@edwardrf edwardrf requested a review from lionello August 22, 2024 21:16
@edwardrf edwardrf removed the wip Work in progress; don't merge label Aug 23, 2024
@edwardrf edwardrf marked this pull request as ready for review August 23, 2024 16:37
@edwardrf edwardrf requested a review from lionello September 12, 2024 21:59
@edwardrf edwardrf force-pushed the edw-byoc-account-in-domain branch from fe02663 to 9b5f881 Compare September 12, 2024 22:18
@edwardrf edwardrf force-pushed the edw-byoc-account-in-domain branch from 9b5f881 to 367e102 Compare September 12, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants