Support some commands offline #1237
Conversation
| @@ -379,6 +376,11 @@ var RootCmd = &cobra.Command{ | |||
| return nil | |||
| } | |||
|
|
|||
| // Check whether Connect failed with a networking error | |||
There was a problem hiding this comment.
This relocation of the check may cause commands which require a Fabric/network connection but are not marked with authNeeded annotation to exit way later and show the raw network connection error instead of our nice, user-friendly error when there is no internet.
An example would be defang generate, which requires internet but not necessarily authNeeded. So when a user runs this without internet, they may see the unable to resolve host error or something similar as opposed to unable to connect to Defang server when the call to Fabric occurs later on.
According to @edwardrf, a solution would be to avoid mixing up/overloading the meaning of the when auth is needed versus when Fabric/network is needed, perhaps by adding another flag called fabricNeeded or networkNeeded
Description
When offline (on a plane), we should allow commands that don't require login, like
defang compose config.Linked Issues
See #1111
Checklist