print https:// before public endpoints #1207
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionello
requested changes
Jun 2, 2025
Comment on lines
+50
to
+53
| if endpoint == "" { | ||
| continue | ||
| } | ||
|
|
There was a problem hiding this comment.
does this actually happen? I'd remove it
Suggested change
| if endpoint == "" { | |
| continue | |
| } |
| endpoints = append(endpoints, endpoint) | ||
| } | ||
| if len(endpoints) == 0 { | ||
| endpoints = append(endpoints, "N/A") |
| continue | ||
| } | ||
|
|
||
| if !regexp.MustCompile(`\.internal:\d{1,5}$`).MatchString(endpoint) { |
There was a problem hiding this comment.
This feels brittle. There's some code elsewhere that mirrors this. Perhaps we just check for the port number: no port = https (which is true)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
https://before non-internal endpoints so that they are clickable from the shell.Linked Issues
Checklist