Add unit-test to GetProjectDomain in BaseClient #1094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionello
reviewed
Mar 31, 2025
edwardrf
force-pushed
the
edw/add-get-project-domain-test
branch
from
2e8033c to
f27b88c
Compare
lionello
reviewed
Apr 1, 2025
jordanstephens
approved these changes
Apr 3, 2025
Comment on lines
+196
to
+197
| {"", "test-zone", "test-tenant", TestProjectBackendWithoutStack{}, ""}, | ||
| {"", "test-zone", "test-tenant", TestProjectBackendWithStack{stack: "test-stack"}, ""}, |
There was a problem hiding this comment.
I guess this is unlikely (or impossible) based on validation further up the stack, but should we generate a project prefix in this case (or panic)?
nullfunc
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked Issues
Checklist