Skip to content

XML Water Commands and Messages #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

nanomad
Copy link
Contributor

@nanomad nanomad commented Apr 27, 2025

No description provided.

@nanomad nanomad changed the title Add first batch of XML Water related commands and messages XML Water Commands and Messages Apr 27, 2025
Copy link

codecov bot commented Apr 27, 2025

Codecov Report

Attention: Patch coverage is 79.59184% with 10 lines in your changes missing coverage. Please review.

Project coverage is 92.71%. Comparing base (4cc81d1) to head (2eb9e77).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
deebot_client/commands/xml/water_info.py 70.00% 9 Missing ⚠️
deebot_client/messages/xml/water_info.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #928      +/-   ##
==========================================
- Coverage   92.84%   92.71%   -0.14%     
==========================================
  Files         125      127       +2     
  Lines        4865     4913      +48     
  Branches      315      320       +5     
==========================================
+ Hits         4517     4555      +38     
- Misses        285      295      +10     
  Partials       63       63              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

codspeed-hq bot commented Apr 27, 2025

CodSpeed Performance Report

Merging #928 will not alter performance

Comparing nanomad:feature/xml-water-commands-and-messages (2eb9e77) with dev (4cc81d1)

Summary

✅ 6 untouched benchmarks

@nanomad nanomad force-pushed the feature/xml-water-commands-and-messages branch from 86e11c7 to 2eb9e77 Compare April 29, 2025 09:54
@nanomad
Copy link
Contributor Author

nanomad commented May 8, 2025

PR on hold while I await for a replacement battery 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant