-
Notifications
You must be signed in to change notification settings - Fork 24
Keycloak review #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Keycloak review #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checked that the links reported as broken are OK |
lgrateau
approved these changes
May 7, 2025
lgrateau
added a commit
that referenced
this pull request
Jun 17, 2025
* Add terraform scripts to provision ODM landing zone on IBM Cloud (#191) * added terraform for ODM on ROKS * updated readme * Update README.md * Link checker * DBACLD-148300 Enable detect secret * DBACLD-148300 Enable detect secret * New pre-commit version * Add script to extract user-group-mgt from entraid * Detect secrets GitHub action (#194) * detect-secrets github action * update .secrets.baseline with secrets from ldap-custom-ssl-secret.yaml and openldap-customldif.yaml * run the github action on push only (not pull_request) --------- Co-authored-by: Frederic Mercier <f.mercier@fr.ibm.com> * send notification to Slack if detect-secrets failed * typo on rtsUser role name * update secret baseline * updated ECS README and docker-compose * update baseline * update with audit for ldap yaml * remove exclude * groups and users synchro * Update README_WITH_CLIENT_SECRET.md * Update README_WITH_CLIENT_SECRET.md * Update README_WITH_CLIENT_SECRET.md * Update README_WITH_CLIENT_SECRET.md * Update README_WITH_CLIENT_SECRET.md * API Permissions * Add outbound rule configuration * add RES_URL info * images for datasync * Note on sidecar image * Create Dockerfile * add info about using Amazon root CA and EFS file system * Update README_WITH_CLIENT_SECRET.md * add DC server config edit * update comment in docker-compose file * explain HTTPS mode * resize images display * correct url typo * add info about HTTPS listeners * improve documenentation and add tutorial architecture schema * add steps for runtime to communicate with res notif server * add explanation about restarting runtime * update docker compose file different ECS tasks * Update - target group settings for DC and runtime * update comment in docker files * add TOC * remove : from titles * Update TOC * correct incorrect toc link * file server * check download * Update README.md * replaced by dedicated tutorials * typos * Update README.md * update doc * update for 24.1.0 * DBACLD-155807 validate instructions for using keycloak with ODM * update .secrets.baseline * update nginx ingress to create nlb instead of classic lb in AWS * restore snapshot URL * keycloak parameter change * restore intro that was deleted by TOC generator plugin * update dead link * update dead link * accessing the keycloak console behind a proxy * Review Minikube installation. (#199) * option renamed into "Always display in console" in Create Client wizard * fine-grained permission * First part * Try to fix inline note * Fix inline notes * Try fix * Another try with inline notes * Markdown is painful sometimes * Simplification * Removed user-chosen secret names * GCP changed details in Load Balancer * Markdown (URLs) * DBACLD-155793 Validate Instructions for OKTA as OIDC provider * update wrt ibm licensing service 4.9 * update the script and template file with the same changes as in keycloak-odm-script-original.zip * update instruction for applying licensing 4.9 * update instruction to apply licensing 4.9 for nginx ingress * update LS troubleshooting url * update version to 9.0.0.1 release in dec * update to 9.0.0.1 * Prepare delivery of the new release. DBACLD-157428. Deliver ODM for Developpers charts (#206) * Updated TLS secret name * token reuse * navigation * Force image version (as the doc will be merged to dedicated branches) * Typo * ROKS Review (#207) * integrated changes from Lionel M (#208) * regenerate zip file * regenerate zip file * remove bash on scripts * update jose lib version * missing AZUREAD_TENANT_ID * refactor licensing * .secrets.baseline * rename * update doc and test procedure with case 1.8.5 * Update README-NGINX.md * Update README.md * Update README.md * move to flexible-server 15 * update secret baseline * remove image.tag 9.0.0.0 and re-add back --version 24.1.0 * removed explanation and only focus on latest case * 9.0.0.1 update * push helm values files * Update README-NGINX.md * Update README.md Versioning repo * add ECS Fargate to platform list (#212) * Add License section to ECS README.md * Reformat table in minikube README.md to have better printout in PDF * ibm-entitlement-key is the default as imagePullSecret * Update odm appversion to 9.0.0.1 & chart version to 24.1.0 (#213) * Added load_balancing_resources.png + rewrote part of NGINX * Renaming + accept license * Native Load Balancer screenshots * Renaming * Fixed URLs * Added reference about URL rewrite * Updated version and ingressClass * Revert "ibm-entitlement-key is the default as imagePullSecret" This reverts commit ce8b56b. * Added instructions for correct IBMLicensing CR * Update index.yaml (#215) * broken link * Update README_FINE_GRAIN_PERMISSION.md * Updated copyright to 2025 * Update details about ODM deployment with IBM license service topology (#218) * Mentioned VPC endpoint for Secret Manager. * Add disclaimer that ILMT doesn't support AWS S3 secured via SS3-KMS * change repo (from staging to release) * Update doc per ODM 9.5 and IBM licensing 4.11.0 * update readme pertaining to nginx 1.12.1 and odm 9.5 * review and update doc according to odm 95 * update link * update link to 9.5.0/900 and also md config * Fixed TOC * DBACLD-160975 [ODM K8S] Validate Instructions for using OKTA Provider… (#223) * DBACLD-160975 [ODM K8S] Validate Instructions for using OKTA Provider with ODM containers (Helm) Signed-off-by: laurent grateau <laurent.grateau@fr.ibm.com> * Try to fix link checker --------- Signed-off-by: laurent grateau <laurent.grateau@fr.ibm.com> * Keycloak articles review for 9.5 (#227) * Review and update topic wrt odm95 * Review and update EKS (ALB) wrt ODM 95 and IBM licensing 4.12.0 * Fixed TOC and versions * Seems to be useless, our included driver can manage GCP's PostgreSQL. * Fixed link * Review and update EKS(Ingress) content wrt odm 95 * Fixed links (thank you Sia Sin!) * One less 301 * Try to fix status 403 * Revert "Try to fix status 403" This reverts commit 528f5d6. * Fix JSON * Linkchecker (#224) * Add GitHub Actions workflow for link checking with Linkspector * Add .linkspector.yml configuration for link checking * try new things * Try again something else * Try again * qdf * Fix blanks * Revert * Vnext release (#228) * Update doc per ODM 9.5 and IBM licensing 4.11.0 * update readme pertaining to nginx 1.12.1 and odm 9.5 * review and update doc according to odm 95 * update link * update link to 9.5.0/900 and also md config * DBACLD-160975 [ODM K8S] Validate Instructions for using OKTA Provider… (#223) * DBACLD-160975 [ODM K8S] Validate Instructions for using OKTA Provider with ODM containers (Helm) Signed-off-by: laurent grateau <laurent.grateau@fr.ibm.com> * Try to fix link checker --------- Signed-off-by: laurent grateau <laurent.grateau@fr.ibm.com> --------- Signed-off-by: laurent grateau <laurent.grateau@fr.ibm.com> Co-authored-by: siasin <siasin.tay@fr.ibm.com> * Fix broken link * Avoid 429 error code + put in place replacement pattern * try to fix remaining issue with okta * fix okta broken link * Update TOC in README.md * Fix cognito broken links * Fix cognito * fix broken links in azuread * fix errors reported by linkspector wrt some internal links * fix errors reported by linkspector (continued) * fix link reported by linkspector (only links to sections are possible not link to list) * fix broken links * fix broken links --------- Signed-off-by: laurent grateau <laurent.grateau@fr.ibm.com> Co-authored-by: siasin <siasin.tay@fr.ibm.com> Co-authored-by: Frederic Mercier <frederic.mercier@gmx.net> Co-authored-by: Frederic Mercier <f.mercier@fr.ibm.com> * Remove unneccessary file + DBACLD-176888 Change version reference in the github repository * Fixed links and version * update article wrt odm 95 (#232) * DBACLD-160974 : validate the instructions for using Minikube (#234) * DBACLD-160974 : validate the instructions for using Minikube * test with k8s 1.31.9 --------- Co-authored-by: Frederic Mercier <f.mercier@fr.ibm.com> * Unify helm install command and add a note about installing a specific version (#235) * DBACLD-179578 Deliver ODM for Developpers charts * update metrics * opentelemetry update * opentelemetry update * opentelemetry update * update secrets.baseline * install collector chart * install collector chart * add values for monitor * update scan * DBACLD-176906: review instructions for using Cognito * update jaeger route * typo * partial update * update README * bad display * Fix version * additional changes * modify templates * change helm instance * Update README_WITH_PRIVATE_KEY_JWT.md * Update README_WITH_CLIENT_SECRET.md * update pkjwt * scan secret * remove openId parameter * azuread-odm-script.zip * remove kid * modify pre token generation * Cognito Plan * add usage of identity * lambda picture * update scan * test RD * document lambda * update * Update EKS cluster version to 1.32 --------- Signed-off-by: laurent grateau <laurent.grateau@fr.ibm.com> Co-authored-by: Lionel <lionel.mace@gmail.com> Co-authored-by: Mathias Mouly <mathias.mouly@fr.ibm.com> Co-authored-by: Frederic Mercier <frederic.mercier@gmx.net> Co-authored-by: Frederic Mercier <f.mercier@fr.ibm.com> Co-authored-by: siasin <siasin.tay@fr.ibm.com> Co-authored-by: Pierre-Yves Lochou <pylochou@fr.ibm.com> Co-authored-by: Pierre-Yves Lochou <31895642+PYLochou@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.