test_util: Parametrize and refactor tests for build_headers_with_authorization
#539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #528, #538.
This PR uses PyTest's Parametrize functionality to parametrize the test for
build_headers_with_authorization. It also breaks out the other cases for this test into separate test scenarios, rather than having all of them encompassed in a single test. This improves readability by removing complicated logic from tests and keeping the structure of the test clean ("Arrange-Act-Assert"), and when viewing the tests in a directory with something likepytest --collect-only, it helps view the scenarios more easily.Thanks!