Skip to content

Conversation

@tylfin
Copy link
Member

@tylfin tylfin commented Oct 29, 2025

Motivation

I introduced this in a previous change, but the tests should skip this test when ddtrace is less than v3.15.0, not when it is greater than or equal to v3.15.0.

Changes

  • Updated the @missing_feature decorators in test_log_line_snapshot_debug_track and test_log_line_snapshot_new_destination to skip tests only for Python versions less than 3.15.0, aligning with when the track change was introduced. [1] [2]

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

tests/debugger/test_debugger_probe_snapshot.py                          @DataDog/debugger @DataDog/system-tests-core

@tylfin tylfin marked this pull request as ready for review October 29, 2025 14:39
@tylfin tylfin requested review from a team as code owners October 29, 2025 14:39
@tylfin tylfin enabled auto-merge (squash) October 29, 2025 14:48
@tylfin tylfin merged commit e31b820 into main Oct 29, 2025
54 checks passed
@tylfin tylfin deleted the tyler.finethy/fix-logic-ddtrace-track-change branch October 29, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants