Skip to content

Conversation

@rochdev
Copy link
Member

@rochdev rochdev commented Oct 28, 2025

Motivation

Fix issues like this one: https://github.com/DataDog/dd-trace-js/actions/runs/18879474273/job/53878613960?pr=6771

Changes

Fix missing retry for npm install of datadog-ci.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@rochdev rochdev requested a review from a team as a code owner October 28, 2025 15:20
@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

.github/actions/push_to_test_optim/action.yml                           @DataDog/system-tests-core

@rochdev rochdev merged commit 6f569bb into main Oct 28, 2025
397 checks passed
@rochdev rochdev deleted the fix-missing-dd-ci-retry branch October 28, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants