-
Couldn't load subscription status.
- Fork 14
[dotnet] feat(debugger): enable dotnet remote enablement tests #5606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Failures for the other tests: |
evanchooly
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With the release of v.3.29.0 of the Dotnet tracer, remote enablement should now be implemented. Unfortunately, a few tests fail so I marked them with the bug decorator and added the related JIRA issue DEBUG-4637
Changes
Updated the
dotnet.ymlmanifest to set the feature version forTest_Debugger_InProduct_Enablement_Code_Origin,Test_Debugger_InProduct_Enablement_Dynamic_Instrumentation, andTest_Debugger_InProduct_Enablement_Exception_Replaytov3.29.0, indicating these features are now available for .NET.Test logic improvements:
@bugdecorator (withforce_skip=True) to the three corresponding test methods intest_debugger_inproduct_enablement.pyto skip them for .NET due to the known issueDEBUG-4637. [1] [2] [3]bugdecorator intest_debugger_inproduct_enablement.pyto enable conditional test skipping for .NET.Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present