Skip to content

chore: mark efficient payload scenario as missing on agent #5594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 24, 2025
Merged

chore: mark efficient payload scenario as missing on agent #5594

merged 7 commits into from
Oct 24, 2025

Conversation

@hannahkm
Copy link
Contributor

@hannahkm hannahkm commented Oct 23, 2025 •
edited
Loading

Motivation

APM_TRACING_EFFICIENT_PAYLOAD needs to be tested against the dev version of the datadog agent.

Changes

  • Marks APM_TRACING_EFFICIENT_PAYLOAD scenario as a missing feature from the agent side

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2025 •
edited
Loading

CODEOWNERS have been resolved as:

manifests/agent.yml                                                     @DataDog/system-tests-core

cbeauchesne
cbeauchesne requested changes Oct 24, 2025
View reviewed changes
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You just need to use manifests/agent.yml

@hannahkm hannahkm marked this pull request as ready for review October 24, 2025 17:19
@hannahkm hannahkm requested a review from a team as a code owner October 24, 2025 17:19
@hannahkm hannahkm changed the title feat: allow e2e testing with dev agent image chore: mark efficient payload scenario as missing on agent Oct 24, 2025
cbeauchesne
cbeauchesne reviewed Oct 24, 2025
View reviewed changes
@hannahkm @cbeauchesne
Update manifests/agent.yml
44aecb5 
Co-authored-by: Charles de Beauchesne <charles.debeauchesne@datadoghq.com>
@hannahkm
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Oct 24, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-10-24 17:39:40 UTC ℹ️ Start processing command /merge

2025-10-24 17:39:50 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-10-24 17:51:39 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 8m (p90).

2025-10-24 17:58:04 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit ed416d5 into main Oct 24, 2025
397 checks passed
@dd-mergequeue dd-mergequeue bot deleted the hannahkm/create_custom_scenario branch October 24, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbeauchesne cbeauchesne cbeauchesne approved these changes

@ajgajg1134 ajgajg1134 ajgajg1134 approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hannahkm @ajgajg1134 @cbeauchesne