Skip to content

Conversation

@mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Oct 6, 2025

Motivation

Enables otel logs tests for nodejs

Changes

Updates tests to be compatible with nodejs implementation

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

CODEOWNERS have been resolved as:

manifests/nodejs.yml                                                    @DataDog/dd-trace-js
tests/parametric/test_otel_logs.py                                      @DataDog/system-tests-core @DataDog/apm-sdk-capabilities
tests/parametric/test_parametric_endpoints.py                           @DataDog/system-tests-core @DataDog/apm-sdk-capabilities
utils/build/docker/nodejs/parametric/server.js                          @DataDog/dd-trace-js @DataDog/system-tests-core

@mabdinur mabdinur marked this pull request as ready for review October 15, 2025 19:32
@mabdinur mabdinur requested review from a team as code owners October 15, 2025 19:32
@mabdinur mabdinur requested review from mhlidd and removed request for a team October 15, 2025 19:32
@mabdinur mabdinur enabled auto-merge (squash) October 16, 2025 20:15
@mabdinur mabdinur force-pushed the munir/otel-logs-nodehs branch from b41eff2 to e76b396 Compare October 23, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants