fix(tracer-flare): fix design of TracerFlareManager #1186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1186 +/- ##
==========================================
+ Coverage 71.88% 71.97% +0.09%
==========================================
Files 356 356
Lines 56691 56787 +96
==========================================
+ Hits 40750 40875 +125
+ Misses 15941 15912 -29
🚀 New features to boost your workflow:
|
ekump
reviewed
Aug 20, 2025
BenchmarksComparisonBenchmark execution time: 2025-10-13 13:15:35 Comparing candidate commit 0cf6047 in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics. scenario:normalization/normalize_service/normalize_service/[empty string]
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
BaselineOmitted due to size. |
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
ekump
reviewed
Sep 29, 2025
VianneyRuhlmann
approved these changes
Oct 8, 2025
ekump
approved these changes
Oct 9, 2025
There was a problem hiding this comment.
Conditional LGTM, providing you address @VianneyRuhlmann's comments / suggestions. In particular setting tracer_flare.collecting = false; on Unset seems important.
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix the use of the
AGENT_CONFIGproduct in the tracer flare design.Remove the
statefield of theTracerFlareManagerand replaced it with a simplecollectingboolean field.Added arguments
log_levelandsend_actionfor thezip_and_sendfunction to let the language tell us what log level is on when creating the flare, and give theAGENT_TASKthrough the action.Added a priority system to decide which action should happen first if several changes are received.
Made the
LogLevelenum sortable (so log levels can be compared).How to test the change?
Updated and added more tests to cover new logic and behaviors.