Skip to content

Consolidate dependencies #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 24, 2025
Merged

Consolidate dependencies #1032

merged 3 commits into from
Apr 24, 2025

Conversation

@hoolioh
Copy link
Contributor

@hoolioh hoolioh commented Apr 21, 2025 •
edited
Loading

What does this PR do?

Consolidate prost dependencies.

Motivation

Some prost dependencies from version 0.11.x to 0.13.5 differ in their major version which resulted in having duplicate libraries for some compilations.

@github-actions github-actions bot added profiling Relates to the profiling* modules. mini-agent labels Apr 21, 2025
@hoolioh hoolioh force-pushed the julio/consolidate-dependencies branch from 4b6e416 to b9695be Compare April 21, 2025 15:06
@pr-commenter
Copy link

pr-commenter bot commented Apr 21, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-04-23 21:44:52

Comparing candidate commit b6c5a38 in PR branch julio/consolidate-dependencies with baseline commit 7f595c0 in branch main.

Found 8 performance improvements and 4 performance regressions! Performance is the same for 40 metrics, 2 unstable metrics.

scenario:credit_card/is_card_number/x371413321323331

  • 🟥 execution_time [+565.133ns; +584.752ns] or [+9.360%; +9.685%]
  • 🟥 throughput [-14606699.578op/s; -14157986.912op/s] or [-8.819%; -8.549%]

scenario:credit_card/is_card_number_no_luhn/x371413321323331

  • 🟥 execution_time [+544.919ns; +564.668ns] or [+9.027%; +9.355%]
  • 🟥 throughput [-14154108.813op/s; -13699997.539op/s] or [-8.544%; -8.270%]

scenario:normalization/normalize_name/normalize_name/bad-name

  • 🟩 execution_time [-1.235µs; -1.209µs] or [-6.235%; -6.104%]
  • 🟩 throughput [+3284660.383op/s; +3350989.478op/s] or [+6.508%; +6.639%]

scenario:normalization/normalize_name/normalize_name/good

  • 🟩 execution_time [-1.122µs; -1.074µs] or [-9.307%; -8.906%]
  • 🟩 throughput [+8126850.176op/s; +8462364.887op/s] or [+9.797%; +10.202%]

scenario:normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...

  • 🟩 execution_time [-31.133µs; -30.896µs] or [-5.800%; -5.756%]
  • 🟩 throughput [+113805.701op/s; +114684.207op/s] or [+6.109%; +6.156%]

scenario:normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters

  • 🟩 execution_time [-9.160µs; -8.999µs] or [-4.904%; -4.818%]
  • 🟩 throughput [+271080.658op/s; +275968.672op/s] or [+5.064%; +5.155%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b6c5a38 1745443833 julio/consolidate-dependencies
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.962µs 5.053µs ± 0.039µs 5.062µs ± 0.028µs 5.085µs 5.100µs 5.103µs 5.119µs 1.11% -0.479 -1.030 0.77% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.047µs; 5.058µs] or [-0.107%; +0.107%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b6c5a38 1745443833 julio/consolidate-dependencies
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 243.890ns 255.802ns ± 14.153ns 248.574ns ± 2.694ns 257.199ns 287.117ns 294.556ns 298.219ns 19.97% 1.484 0.874 5.52% 1.001ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [253.840ns; 257.763ns] or [-0.767%; +0.767%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b6c5a38 1745443833 julio/consolidate-dependencies
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.234µs 33.879µs ± 1.117µs 33.375µs ± 0.053µs 33.445µs 36.285µs 36.340µs 37.056µs 11.03% 1.709 0.971 3.29% 0.079µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [33.724µs; 34.034µs] or [-0.457%; +0.457%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b6c5a38 1745443833 julio/consolidate-dependencies
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 5.927ms 5.940ms ± 0.007ms 5.939ms ± 0.004ms 5.943ms 5.949ms 5.960ms 5.988ms 0.83% 2.679 15.228 0.12% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [5.939ms; 5.941ms] or [-0.017%; +0.017%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b6c5a38 1745443833 julio/consolidate-dependencies
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 72.641ms 72.985ms ± 0.152ms 72.966ms ± 0.069ms 73.035ms 73.254ms 73.551ms 73.824ms 1.18% 1.752 6.786 0.21% 0.011ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [72.964ms; 73.006ms] or [-0.029%; +0.029%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b6c5a38 1745443833 julio/consolidate-dependencies
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 148.326µs 149.531µs ± 0.353µs 149.461µs ± 0.177µs 149.695µs 150.205µs 150.551µs 150.804µs 0.90% 0.584 1.540 0.24% 0.025µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [149.482µs; 149.580µs] or [-0.033%; +0.033%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b6c5a38 1745443833 julio/consolidate-dependencies
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.397µs 2.419µs ± 0.018µs 2.415µs ± 0.008µs 2.423µs 2.470µs 2.477µs 2.483µs 2.84% 1.999 3.892 0.73% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.416µs; 2.421µs] or [-0.102%; +0.102%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b6c5a38 1745443833 julio/consolidate-dependencies
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.198µs 3.222µs ± 1.518µs 2.995µs ± 0.020µs 3.015µs 3.690µs 13.960µs 16.798µs 460.84% 7.530 58.182 47.00% 0.107µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.012µs; 3.433µs] or [-6.530%; +6.530%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b6c5a38 1745443833 julio/consolidate-dependencies
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 208.252µs 208.723µs ± 0.163µs 208.731µs ± 0.090µs 208.815µs 208.989µs 209.095µs 209.271µs 0.26% -0.074 0.607 0.08% 0.012µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4778483.445op/s 4791042.146op/s ± 3741.107op/s 4790849.159op/s ± 2072.404op/s 4793117.243op/s 4798120.385op/s 4799851.333op/s 4801877.214op/s 0.23% 0.080 0.605 0.08% 264.536op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.500µs 18.590µs ± 0.034µs 18.585µs ± 0.020µs 18.611µs 18.647µs 18.691µs 18.728µs 0.77% 0.813 1.724 0.18% 0.002µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 53394897.348op/s 53791736.748op/s ± 97310.277op/s 53808109.350op/s ± 58595.662op/s 53856538.960op/s 53937952.814op/s 53962685.136op/s 54053038.857op/s 0.46% -0.797 1.677 0.18% 6880.876op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.871µs 10.960µs ± 0.046µs 10.956µs ± 0.032µs 10.982µs 11.045µs 11.076µs 11.078µs 1.11% 0.589 -0.184 0.42% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 90270004.527op/s 91244577.058op/s ± 383541.767op/s 91276430.670op/s ± 269802.879op/s 91554309.006op/s 91752712.184op/s 91857073.606op/s 91987857.603op/s 0.78% -0.571 -0.212 0.42% 27120.498op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [208.700µs; 208.746µs] or [-0.011%; +0.011%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4790523.664op/s; 4791560.627op/s] or [-0.011%; +0.011%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.586µs; 18.595µs] or [-0.025%; +0.025%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [53778250.479op/s; 53805223.016op/s] or [-0.025%; +0.025%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.953µs; 10.966µs] or [-0.058%; +0.058%] None None None
normalization/normalize_name/normalize_name/good throughput [91191421.858op/s; 91297732.258op/s] or [-0.058%; +0.058%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b6c5a38 1745443833 julio/consolidate-dependencies
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.895µs 3.914µs ± 0.003µs 3.914µs ± 0.001µs 3.915µs 3.919µs 3.920µs 3.922µs 0.21% -1.344 9.230 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 254949996.373op/s 255485130.381op/s ± 184690.383op/s 255473251.951op/s ± 91929.971op/s 255572755.174op/s 255747353.772op/s 255864609.628op/s 256726072.376op/s 0.49% 1.364 9.373 0.07% 13059.582op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 82.356µs 82.778µs ± 0.281µs 82.740µs ± 0.158µs 82.888µs 83.342µs 83.760µs 83.830µs 1.32% 1.285 2.080 0.34% 0.020µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 11928930.782op/s 12080692.981op/s ± 40778.361op/s 12086003.807op/s ± 23192.522op/s 12109294.186op/s 12132185.901op/s 12139587.669op/s 12142373.240op/s 0.47% -1.261 1.997 0.34% 2883.466op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 76.300µs 77.056µs ± 0.433µs 77.031µs ± 0.264µs 77.259µs 77.782µs 78.016µs 79.351µs 3.01% 1.323 4.225 0.56% 0.031µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 12602178.219op/s 12977914.475op/s ± 72380.215op/s 12981849.431op/s ± 44367.808op/s 13031152.329op/s 13074782.132op/s 13098956.965op/s 13106153.289op/s 0.96% -1.250 3.823 0.56% 5118.054op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.897µs 3.914µs ± 0.003µs 3.914µs ± 0.001µs 3.915µs 3.919µs 3.920µs 3.921µs 0.18% -1.205 8.683 0.07% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255047189.220op/s 255488525.809op/s ± 170099.702op/s 255506528.192op/s ± 77022.071op/s 255561660.642op/s 255748222.929op/s 255890201.751op/s 256605533.620op/s 0.43% 1.224 8.803 0.07% 12027.865op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 72.744µs 73.737µs ± 0.428µs 73.673µs ± 0.258µs 74.015µs 74.414µs 74.959µs 75.205µs 2.08% 0.516 0.532 0.58% 0.030µs 1 200
credit_card/is_card_number/378282246310005 throughput 13296953.130op/s 13562232.102op/s ± 78516.328op/s 13573462.564op/s ± 47714.972op/s 13614925.365op/s 13681730.846op/s 13710082.720op/s 13746882.692op/s 1.28% -0.477 0.461 0.58% 5551.943op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 51.938µs 52.188µs ± 0.113µs 52.181µs ± 0.086µs 52.270µs 52.382µs 52.431µs 52.464µs 0.54% 0.123 -0.561 0.22% 0.008µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19060694.911op/s 19161429.937op/s ± 41384.658op/s 19163935.392op/s ± 31535.528op/s 19195141.230op/s 19228213.301op/s 19244272.778op/s 19253683.119op/s 0.47% -0.114 -0.563 0.22% 2926.337op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.433µs 6.613µs ± 0.071µs 6.605µs ± 0.050µs 6.668µs 6.738µs 6.765µs 6.790µs 2.81% 0.118 -0.274 1.07% 0.005µs 1 200
credit_card/is_card_number/x371413321323331 throughput 147269536.847op/s 151236997.509op/s ± 1613396.957op/s 151406748.636op/s ± 1161509.868op/s 152482831.389op/s 153766023.723op/s 154725310.942op/s 155440921.884op/s 2.66% -0.063 -0.274 1.06% 114084.393op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.899µs 3.914µs ± 0.003µs 3.914µs ± 0.001µs 3.915µs 3.918µs 3.919µs 3.920µs 0.16% -0.933 4.039 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 255093486.373op/s 255521569.080op/s ± 172549.073op/s 255514389.904op/s ± 77699.522op/s 255591904.127op/s 255845995.926op/s 255958798.437op/s 256470666.619op/s 0.37% 0.943 4.089 0.07% 12201.062op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 63.501µs 63.970µs ± 0.177µs 63.951µs ± 0.114µs 64.065µs 64.303µs 64.398µs 64.828µs 1.37% 0.871 2.115 0.28% 0.013µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15425378.894op/s 15632462.012op/s ± 43133.721op/s 15636954.939op/s ± 27995.139op/s 15665216.188op/s 15690013.857op/s 15716560.792op/s 15747725.056op/s 0.71% -0.844 2.007 0.28% 3050.015op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 57.752µs 57.874µs ± 0.049µs 57.866µs ± 0.027µs 57.900µs 57.960µs 57.995µs 58.069µs 0.35% 0.547 1.200 0.08% 0.003µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 17220836.143op/s 17278929.408op/s ± 14494.805op/s 17281375.455op/s ± 7927.191op/s 17287700.395op/s 17299913.865op/s 17312514.532op/s 17315567.561op/s 0.20% -0.540 1.188 0.08% 1024.938op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.895µs 3.914µs ± 0.003µs 3.914µs ± 0.001µs 3.915µs 3.917µs 3.919µs 3.920µs 0.16% -1.807 10.572 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 255093257.244op/s 255517319.989op/s ± 178682.168op/s 255514070.618op/s ± 84646.387op/s 255580658.935op/s 255823859.951op/s 255930408.121op/s 256756095.672op/s 0.49% 1.826 10.725 0.07% 12634.737op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.561µs 54.764µs ± 0.185µs 54.689µs ± 0.046µs 54.771µs 55.165µs 55.203µs 55.560µs 1.59% 1.782 2.600 0.34% 0.013µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17998568.966op/s 18260362.170op/s ± 61398.436op/s 18285327.854op/s ± 15315.078op/s 18298594.668op/s 18310810.886op/s 18316785.548op/s 18328175.905op/s 0.23% -1.768 2.521 0.34% 4341.525op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 51.897µs 52.185µs ± 0.113µs 52.184µs ± 0.082µs 52.265µs 52.355µs 52.405µs 52.470µs 0.55% -0.077 -0.443 0.22% 0.008µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19058466.113op/s 19162712.776op/s ± 41323.518op/s 19162823.167op/s ± 30026.172op/s 19193060.280op/s 19229911.267op/s 19254545.438op/s 19269006.165op/s 0.55% 0.087 -0.442 0.22% 2922.014op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.433µs 6.591µs ± 0.071µs 6.591µs ± 0.045µs 6.635µs 6.709µs 6.764µs 6.795µs 3.10% 0.190 -0.075 1.08% 0.005µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 147167077.528op/s 151737817.782op/s ± 1635687.431op/s 151722273.505op/s ± 1045300.183op/s 152798283.546op/s 154473900.911op/s 155316120.661op/s 155449091.707op/s 2.46% -0.129 -0.106 1.08% 115660.567op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.914µs; 3.915µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ throughput [255459534.070op/s; 255510726.692op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [82.739µs; 82.817µs] or [-0.047%; +0.047%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12075041.492op/s; 12086344.469op/s] or [-0.047%; +0.047%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [76.996µs; 77.116µs] or [-0.078%; +0.078%] None None None
credit_card/is_card_number/ 378282246310005 throughput [12967883.274op/s; 12987945.677op/s] or [-0.077%; +0.077%] None None None
credit_card/is_card_number/37828224631 execution_time [3.914µs; 3.914µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631 throughput [255464951.627op/s; 255512099.992op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/378282246310005 execution_time [73.677µs; 73.796µs] or [-0.080%; +0.080%] None None None
credit_card/is_card_number/378282246310005 throughput [13551350.494op/s; 13573113.710op/s] or [-0.080%; +0.080%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.173µs; 52.204µs] or [-0.030%; +0.030%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19155694.421op/s; 19167165.452op/s] or [-0.030%; +0.030%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.603µs; 6.623µs] or [-0.148%; +0.148%] None None None
credit_card/is_card_number/x371413321323331 throughput [151013396.208op/s; 151460598.810op/s] or [-0.148%; +0.148%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.913µs; 3.914µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ throughput [255497655.438op/s; 255545482.722op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [63.945µs; 63.994µs] or [-0.038%; +0.038%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15626484.093op/s; 15638439.931op/s] or [-0.038%; +0.038%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [57.867µs; 57.881µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17276920.568op/s; 17280938.249op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.913µs; 3.914µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255492556.359op/s; 255542083.619op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [54.738µs; 54.790µs] or [-0.047%; +0.047%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18251852.937op/s; 18268871.402op/s] or [-0.047%; +0.047%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.169µs; 52.201µs] or [-0.030%; +0.030%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19156985.734op/s; 19168439.819op/s] or [-0.030%; +0.030%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.581µs; 6.601µs] or [-0.150%; +0.150%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [151511127.235op/s; 151964508.328op/s] or [-0.149%; +0.149%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b6c5a38 1745443833 julio/consolidate-dependencies
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 503.846µs 505.757µs ± 0.641µs 505.769µs ± 0.277µs 506.053µs 506.505µs 506.826µs 511.095µs 1.05% 2.455 23.416 0.13% 0.045µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1956584.052op/s 1977237.761op/s ± 2499.076op/s 1977187.431op/s ± 1084.548op/s 1978243.498op/s 1981108.759op/s 1983052.089op/s 1984732.993op/s 0.38% -2.382 22.758 0.13% 176.711op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 454.061µs 455.290µs ± 1.335µs 455.133µs ± 0.283µs 455.427µs 455.811µs 465.349µs 465.788µs 2.34% 6.888 50.537 0.29% 0.094µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2146899.448op/s 2196419.302op/s ± 6311.504op/s 2197158.142op/s ± 1367.881op/s 2198419.507op/s 2200380.621op/s 2201190.035op/s 2202346.777op/s 0.24% -6.843 50.088 0.29% 446.291op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 177.350µs 177.724µs ± 0.522µs 177.656µs ± 0.070µs 177.750µs 177.914µs 178.106µs 182.869µs 2.93% 9.073 85.062 0.29% 0.037µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5468384.469op/s 5626747.443op/s ± 16088.404op/s 5628841.471op/s ± 2211.978op/s 5630760.929op/s 5633296.304op/s 5636507.493op/s 5638577.885op/s 0.17% -9.031 84.520 0.29% 1137.622op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 39.312µs 39.441µs ± 0.049µs 39.435µs ± 0.033µs 39.473µs 39.519µs 39.559µs 39.562µs 0.32% 0.137 -0.244 0.12% 0.003µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 25276709.759op/s 25354410.484op/s ± 31724.032op/s 25357953.089op/s ± 21290.356op/s 25375915.060op/s 25407472.150op/s 25420966.689op/s 25437665.447op/s 0.31% -0.130 -0.245 0.12% 2243.228op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 47.689µs 47.929µs ± 0.078µs 47.925µs ± 0.047µs 47.974µs 48.050µs 48.109µs 48.290µs 0.76% 0.504 1.829 0.16% 0.005µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20708028.931op/s 20864051.083op/s ± 33728.174op/s 20865986.404op/s ± 20270.288op/s 20885870.601op/s 20912985.969op/s 20926744.743op/s 20969261.954op/s 0.49% -0.487 1.782 0.16% 2384.942op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [505.668µs; 505.846µs] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1976891.413op/s; 1977584.109op/s] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [455.105µs; 455.475µs] or [-0.041%; +0.041%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2195544.588op/s; 2197294.015op/s] or [-0.040%; +0.040%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [177.652µs; 177.796µs] or [-0.041%; +0.041%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5624517.745op/s; 5628977.141op/s] or [-0.040%; +0.040%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [39.434µs; 39.448µs] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [25350013.838op/s; 25358807.129op/s] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [47.919µs; 47.940µs] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20859376.683op/s; 20868725.484op/s] or [-0.022%; +0.022%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b6c5a38 1745443833 julio/consolidate-dependencies
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 68.263µs 68.577µs ± 0.252µs 68.529µs ± 0.044µs 68.583µs 68.835µs 69.199µs 71.462µs 4.28% 8.300 87.331 0.37% 0.018µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [68.543µs; 68.612µs] or [-0.051%; +0.051%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b6c5a38 1745443833 julio/consolidate-dependencies
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.768µs 25.692µs ± 10.578µs 18.018µs ± 0.204µs 35.195µs 41.763µs 53.686µs 88.962µs 393.75% 1.753 5.922 41.07% 0.748µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.226µs; 27.158µs] or [-5.706%; +5.706%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.13%. Comparing base (7f595c0) to head (b6c5a38).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1032      +/-   ##
==========================================
- Coverage   71.14%   71.13%   -0.02%     
==========================================
  Files         329      329              
  Lines       49172    49172              
==========================================
- Hits        34985    34977       -8     
- Misses      14187    14195       +8
Components Coverage Δ
crashtracker 42.79% <ø> (+0.05%) ⬆️
crashtracker-ffi 6.30% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 90.78% <ø> (ø)
data-pipeline-ffi 89.02% <ø> (ø)
ddcommon 78.29% <ø> (ø)
ddcommon-ffi 66.37% <ø> (ø)
ddtelemetry 60.19% <ø> (ø)
ddtelemetry-ffi 21.32% <ø> (ø)
dogstatsd-client 82.57% <ø> (ø)
ipc 82.54% <ø> (ø)
profiling 77.49% <ø> (ø)
profiling-ffi 62.12% <ø> (ø)
sidecar 40.95% <ø> (-0.06%) ⬇️
sidecar-ffi 0.58% <ø> (-0.44%) ⬇️
spawn-worker 54.37% <ø> (ø)
tinybytes 90.54% <ø> (ø)
trace-normalization 98.24% <ø> (ø)
trace-obfuscation 94.16% <ø> (ø)
trace-protobuf 78.50% <ø> (ø)
trace-utils 89.33% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@r1viollet
Copy link
Contributor

r1viollet commented Apr 21, 2025 •
edited
Loading

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 76.93 MB 76.93 MB -0% (-792 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.70 MB 7.70 MB -0% (-256 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 23.72 MB 23.72 MB -0% (-1.35 KB) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 7.63 MB 7.63 MB -0% (-240 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 71.27 MB 71.28 MB +0% (+5.51 KB) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 22.32 MB 22.32 MB +.01% (+4.00 KB) 🔍
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 16.73 MB 16.73 MB +.02% (+4.50 KB) 🔍
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 62.20 KB 62.20 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 112.73 MB 112.75 MB +.02% (+24.00 KB) 🔍
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 632.29 MB 632.83 MB +.08% (+553.25 KB) 🔍
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 4.99 MB 4.99 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 62.20 KB 62.20 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 15.87 MB 15.87 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 26.40 MB 26.40 MB +.01% (+3.24 KB) 🔍
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 14.14 MB 14.14 MB +0% (+1.00 KB) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 63.16 KB 63.16 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 114.62 MB 114.61 MB -0% (-8.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 624.68 MB 623.90 MB --.12% (-792.21 KB) 💪
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 3.77 MB 3.77 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 63.16 KB 63.16 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 16.48 MB 16.48 MB +.04% (+8.00 KB) 🔍
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 24.31 MB 24.32 MB +.01% (+3.52 KB) 🔍
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 66.29 MB 66.30 MB +.01% (+8.00 KB) 🔍
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.19 MB 8.19 MB +0% (+104 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 22.90 MB 22.90 MB +0% (+2.33 KB) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 67.26 MB 67.27 MB +0% (+5.07 KB) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 8.07 MB 8.07 MB +0% (+104 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 20.54 MB 20.55 MB +.01% (+2.41 KB) 🔍

@morrisonlevi morrisonlevi mentioned this pull request Apr 23, 2025
Merged
@hoolioh hoolioh marked this pull request as ready for review April 24, 2025 08:50
@hoolioh hoolioh requested review from a team as code owners April 24, 2025 08:50
@hoolioh hoolioh requested a review from pawelchcki April 24, 2025 08:50
ganeshnj
ganeshnj approved these changes Apr 24, 2025
View reviewed changes
Copy link

@ganeshnj ganeshnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,

did you do it manually or there is some tool which can help? I wonder how can we enforce?

@hoolioh
Copy link
Contributor Author

hoolioh commented Apr 24, 2025

Thanks,

did you do it manually or there is some tool which can help? I wonder how can we enforce?

There are several methods to check that:

  • parsing Cargo.lock
  • cargo tree.
  • cargo deny.
  • cargo duplicates
    I've been evaluating them and, since one of the goals of the versioning RFC is to consolidate dependencies, my intention is to enforce it in the CI/CD.

@hoolioh hoolioh merged commit f1b4867 into main Apr 24, 2025
35 checks passed
@hoolioh hoolioh deleted the julio/consolidate-dependencies branch April 24, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pawelchcki pawelchcki Awaiting requested review from pawelchcki pawelchcki is a code owner automatically assigned from DataDog/libdatadog-telemetry

1 more reviewer

@ganeshnj ganeshnj ganeshnj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

mini-agent profiling Relates to the profiling* modules.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hoolioh @codecov-commenter @r1viollet @ganeshnj @morrisonlevi