You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Labels now have strings rather than Option<T> where T is some string type.
This supersedes #959, which got all tangled and also out-of-date from main.
Motivation
The fuzzer can get into weird differences between None and Some(0)/Some("")/etc.
Additional Notes
There is another issue with labels in the fuzzer, but I wanted to fix this issue independently so it's easier to review. This may need to be force-merged if the only failure is the profiling fuzzer.
How to test the change?
Update your APIs to use strings directly instead of Option of strings, then run as normal.
morrisonlevi
changed the title
refactor(prof): Labels have strs directly, not Option<str>
refactor(prof): Labels have T directly, not Option<T>
Apr 15, 2025
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PROF-11530
What does this PR do?
Labels now have strings rather than
Option<T>where T is some string type.This supersedes #959, which got all tangled and also out-of-date from main.
Motivation
The fuzzer can get into weird differences between
NoneandSome(0)/Some("")/etc.Additional Notes
There is another issue with labels in the fuzzer, but I wanted to fix this issue independently so it's easier to review. This may need to be force-merged if the only failure is the profiling fuzzer.
How to test the change?
Update your APIs to use strings directly instead of Option of strings, then run as normal.