Skip to content

Conversation

@morrisonlevi
Copy link
Contributor

@morrisonlevi morrisonlevi commented Apr 15, 2025

PROF-11530

What does this PR do?

Labels now have strings rather than Option<T> where T is some string type.

This supersedes #959, which got all tangled and also out-of-date from main.

Motivation

The fuzzer can get into weird differences between None and Some(0)/Some("")/etc.

Additional Notes

There is another issue with labels in the fuzzer, but I wanted to fix this issue independently so it's easier to review. This may need to be force-merged if the only failure is the profiling fuzzer.

How to test the change?

Update your APIs to use strings directly instead of Option of strings, then run as normal.

@morrisonlevi morrisonlevi requested a review from a team as a code owner April 15, 2025 20:08
@github-actions github-actions bot added the profiling Relates to the profiling* modules. label Apr 15, 2025
@morrisonlevi morrisonlevi changed the title refactor(prof): Labels have strs directly, not Option<str> refactor(prof): Labels have T directly, not Option<T> Apr 15, 2025
@pr-commenter
Copy link

pr-commenter bot commented Apr 15, 2025

Benchmarks

Comparison

Benchmark execution time: 2025-04-15 20:18:12

Comparing candidate commit ec26aa7 in PR branch levi/labels with baseline commit 64fd851 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz ec26aa7 1744747531 levi/labels
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.213µs 3.209µs ± 1.440µs 3.008µs ± 0.026µs 3.028µs 3.675µs 14.010µs 15.010µs 398.99% 7.355 55.176 44.76% 0.102µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.009µs; 3.408µs] or [-6.218%; +6.218%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz ec26aa7 1744747531 levi/labels
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 149.721µs 150.472µs ± 0.328µs 150.408µs ± 0.181µs 150.649µs 150.933µs 151.381µs 152.461µs 1.37% 1.729 7.086 0.22% 0.023µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [150.426µs; 150.517µs] or [-0.030%; +0.030%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz ec26aa7 1744747531 levi/labels
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.892µs 3.913µs ± 0.003µs 3.913µs ± 0.001µs 3.914µs 3.917µs 3.919µs 3.919µs 0.15% -2.424 17.024 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 255151265.469op/s 255553762.667op/s ± 178469.550op/s 255536907.937op/s ± 81291.451op/s 255628413.098op/s 255809415.820op/s 255997824.737op/s 256939115.281op/s 0.55% 2.451 17.277 0.07% 12619.703op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 76.500µs 77.584µs ± 0.466µs 77.527µs ± 0.285µs 77.835µs 78.380µs 78.822µs 79.276µs 2.26% 0.677 0.704 0.60% 0.033µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12614207.470op/s 12889739.561op/s ± 77070.439op/s 12898775.907op/s ± 47577.216op/s 12944924.104op/s 13007404.553op/s 13026198.973op/s 13071876.880op/s 1.34% -0.637 0.626 0.60% 5449.703op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 70.921µs 71.462µs ± 0.274µs 71.428µs ± 0.189µs 71.629µs 71.949µs 72.239µs 72.445µs 1.42% 0.721 0.755 0.38% 0.019µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13803532.935op/s 13993638.055op/s ± 53518.711op/s 14000165.931op/s ± 37091.675op/s 14033464.237op/s 14064482.486op/s 14087054.963op/s 14100258.478op/s 0.71% -0.696 0.686 0.38% 3784.344op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.895µs 3.913µs ± 0.002µs 3.913µs ± 0.001µs 3.915µs 3.917µs 3.919µs 3.920µs 0.17% -1.930 13.666 0.06% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255118005.552op/s 255542248.803op/s ± 162871.985op/s 255544342.453op/s ± 75161.315op/s 255608971.875op/s 255823532.207op/s 255923115.222op/s 256735438.149op/s 0.47% 1.953 13.848 0.06% 11516.788op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 67.149µs 68.071µs ± 0.443µs 68.048µs ± 0.305µs 68.355µs 68.833µs 69.129µs 69.419µs 2.01% 0.279 -0.317 0.65% 0.031µs 1 200
credit_card/is_card_number/378282246310005 throughput 14405259.743op/s 14691223.404op/s ± 95444.064op/s 14695469.848op/s ± 65991.057op/s 14761478.606op/s 14844685.284op/s 14871531.394op/s 14892227.382op/s 1.34% -0.248 -0.350 0.65% 6748.914op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 51.737µs 51.840µs ± 0.035µs 51.844µs ± 0.017µs 51.858µs 51.897µs 51.930µs 51.956µs 0.21% -0.094 0.744 0.07% 0.002µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19247199.159op/s 19290112.118op/s ± 13076.122op/s 19288486.703op/s ± 6423.841op/s 19296633.705op/s 19312734.141op/s 19322077.280op/s 19328544.394op/s 0.21% 0.100 0.742 0.07% 924.621op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.030µs 6.059µs ± 0.027µs 6.045µs ± 0.011µs 6.076µs 6.112µs 6.142µs 6.214µs 2.80% 1.747 5.276 0.44% 0.002µs 1 200
credit_card/is_card_number/x371413321323331 throughput 160931883.386op/s 165055694.550op/s ± 727327.574op/s 165431669.444op/s ± 298571.478op/s 165609318.089op/s 165737800.049op/s 165827054.475op/s 165830012.378op/s 0.24% -1.692 4.892 0.44% 51429.826op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.896µs 3.914µs ± 0.003µs 3.914µs ± 0.001µs 3.915µs 3.918µs 3.921µs 3.926µs 0.31% -0.715 8.393 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254728059.616op/s 255509872.836op/s ± 187009.589op/s 255512019.807op/s ± 85226.675op/s 255595825.532op/s 255803869.166op/s 255897331.441op/s 256687528.259op/s 0.46% 0.736 8.489 0.07% 13223.575op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 65.990µs 66.484µs ± 0.280µs 66.478µs ± 0.195µs 66.653µs 66.964µs 67.165µs 67.820µs 2.02% 0.813 1.631 0.42% 0.020µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 14744997.955op/s 15041572.414op/s ± 63188.019op/s 15042653.648op/s ± 44227.220op/s 15095655.476op/s 15128902.484op/s 15143502.873op/s 15153753.394op/s 0.74% -0.776 1.471 0.42% 4468.068op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 59.518µs 59.688µs ± 0.075µs 59.682µs ± 0.039µs 59.719µs 59.796µs 59.861µs 60.282µs 1.01% 2.743 19.054 0.13% 0.005µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 16588650.638op/s 16753909.235op/s ± 20948.074op/s 16755608.529op/s ± 10892.003op/s 16766486.309op/s 16780992.927op/s 16789773.694op/s 16801549.103op/s 0.27% -2.693 18.563 0.12% 1481.253op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.895µs 3.913µs ± 0.003µs 3.913µs ± 0.001µs 3.915µs 3.918µs 3.920µs 3.924µs 0.27% -1.095 8.167 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254849163.395op/s 255526650.740op/s ± 188152.023op/s 255530610.664op/s ± 85167.929op/s 255600159.751op/s 255852975.949op/s 255955677.033op/s 256727366.886op/s 0.47% 1.114 8.274 0.07% 13304.357op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 56.243µs 56.437µs ± 0.103µs 56.426µs ± 0.077µs 56.509µs 56.619µs 56.694µs 56.792µs 0.65% 0.505 0.059 0.18% 0.007µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17608026.728op/s 17718988.123op/s ± 32195.831op/s 17722438.638op/s ± 24264.194op/s 17740940.937op/s 17766651.110op/s 17774137.706op/s 17780073.871op/s 0.33% -0.495 0.040 0.18% 2276.589op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 51.750µs 51.847µs ± 0.035µs 51.845µs ± 0.019µs 51.866µs 51.902µs 51.938µs 52.013µs 0.32% 0.612 2.656 0.07% 0.002µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19225813.354op/s 19287353.709op/s ± 13008.935op/s 19288083.822op/s ± 7137.976op/s 19294428.252op/s 19305008.236op/s 19317547.461op/s 19323810.800op/s 0.19% -0.603 2.632 0.07% 919.871op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.028µs 6.056µs ± 0.027µs 6.041µs ± 0.007µs 6.075µs 6.113µs 6.147µs 6.153µs 1.86% 1.287 1.105 0.45% 0.002µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 162530079.146op/s 165119668.044op/s ± 740866.078op/s 165546485.506op/s ± 201730.534op/s 165655203.603op/s 165789160.553op/s 165870034.132op/s 165890199.991op/s 0.21% -1.267 1.027 0.45% 52387.143op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.913µs; 3.913µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ throughput [255529028.504op/s; 255578496.830op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [77.519µs; 77.648µs] or [-0.083%; +0.083%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12879058.339op/s; 12900420.783op/s] or [-0.083%; +0.083%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [71.424µs; 71.500µs] or [-0.053%; +0.053%] None None None
credit_card/is_card_number/ 378282246310005 throughput [13986220.876op/s; 14001055.234op/s] or [-0.053%; +0.053%] None None None
credit_card/is_card_number/37828224631 execution_time [3.913µs; 3.914µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631 throughput [255519676.312op/s; 255564821.293op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/378282246310005 execution_time [68.009µs; 68.132µs] or [-0.090%; +0.090%] None None None
credit_card/is_card_number/378282246310005 throughput [14677995.774op/s; 14704451.033op/s] or [-0.090%; +0.090%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [51.835µs; 51.845µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19288299.893op/s; 19291924.343op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.055µs; 6.062µs] or [-0.062%; +0.062%] None None None
credit_card/is_card_number/x371413321323331 throughput [164954893.944op/s; 165156495.157op/s] or [-0.061%; +0.061%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.913µs; 3.914µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ throughput [255483955.105op/s; 255535790.566op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [66.445µs; 66.522µs] or [-0.058%; +0.058%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15032815.162op/s; 15050329.666op/s] or [-0.058%; +0.058%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [59.677µs; 59.698µs] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [16751006.033op/s; 16756812.437op/s] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.913µs; 3.914µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255500574.679op/s; 255552726.800op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [56.423µs; 56.451µs] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [17714526.091op/s; 17723450.156op/s] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [51.843µs; 51.852µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19285550.796op/s; 19289156.622op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.053µs; 6.060µs] or [-0.063%; +0.063%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [165016991.131op/s; 165222344.958op/s] or [-0.062%; +0.062%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz ec26aa7 1744747531 levi/labels
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.632µs 25.640µs ± 10.601µs 17.770µs ± 0.112µs 35.309µs 44.926µs 47.772µs 81.166µs 356.75% 1.264 2.334 41.24% 0.750µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.171µs; 27.109µs] or [-5.730%; +5.730%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz ec26aa7 1744747531 levi/labels
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 5.987ms 6.000ms ± 0.006ms 5.999ms ± 0.003ms 6.003ms 6.009ms 6.013ms 6.046ms 0.77% 2.390 17.102 0.10% 0.000ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [5.999ms; 6.001ms] or [-0.014%; +0.014%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz ec26aa7 1744747531 levi/labels
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.958µs 5.027µs ± 0.042µs 5.010µs ± 0.020µs 5.063µs 5.100µs 5.106µs 5.109µs 1.98% 0.543 -1.092 0.82% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.022µs; 5.033µs] or [-0.114%; +0.114%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz ec26aa7 1744747531 levi/labels
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 72.243ms 72.718ms ± 0.587ms 72.618ms ± 0.118ms 72.765ms 73.047ms 73.665ms 78.816ms 8.53% 8.244 76.497 0.81% 0.042ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [72.636ms; 72.799ms] or [-0.112%; +0.112%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz ec26aa7 1744747531 levi/labels
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 208.775µs 209.227µs ± 0.152µs 209.231µs ± 0.100µs 209.322µs 209.461µs 209.575µs 209.763µs 0.25% 0.012 0.498 0.07% 0.011µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4767279.933op/s 4779491.901op/s ± 3471.602op/s 4779401.734op/s ± 2288.074op/s 4781737.747op/s 4785170.597op/s 4787875.765op/s 4789837.880op/s 0.22% -0.006 0.495 0.07% 245.479op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.588µs 18.651µs ± 0.030µs 18.649µs ± 0.018µs 18.670µs 18.699µs 18.721µs 18.760µs 0.59% 0.411 0.248 0.16% 0.002µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 53306035.824op/s 53615901.106op/s ± 86163.014op/s 53622348.712op/s ± 52378.761op/s 53669162.813op/s 53748760.847op/s 53771762.465op/s 53799547.446op/s 0.33% -0.401 0.229 0.16% 6092.645op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.808µs 10.872µs ± 0.033µs 10.869µs ± 0.027µs 10.898µs 10.929µs 10.952µs 10.961µs 0.85% 0.323 -0.601 0.30% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 91230118.852op/s 91981424.941op/s ± 279763.383op/s 92001170.541op/s ± 230051.801op/s 92222912.735op/s 92368329.658op/s 92438071.563op/s 92521883.205op/s 0.57% -0.311 -0.615 0.30% 19782.259op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [209.206µs; 209.248µs] or [-0.010%; +0.010%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4779010.770op/s; 4779973.031op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.647µs; 18.655µs] or [-0.022%; +0.022%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [53603959.741op/s; 53627842.471op/s] or [-0.022%; +0.022%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.867µs; 10.876µs] or [-0.042%; +0.042%] None None None
normalization/normalize_name/normalize_name/good throughput [91942652.427op/s; 92020197.455op/s] or [-0.042%; +0.042%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz ec26aa7 1744747531 levi/labels
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.356µs 2.412µs ± 0.019µs 2.410µs ± 0.006µs 2.414µs 2.448µs 2.453µs 2.467µs 2.39% 0.250 1.670 0.77% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.409µs; 2.414µs] or [-0.107%; +0.107%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz ec26aa7 1744747531 levi/labels
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 502.605µs 504.770µs ± 0.751µs 504.859µs ± 0.535µs 505.251µs 505.897µs 506.152µs 508.978µs 0.82% 0.653 3.803 0.15% 0.053µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1964719.960op/s 1981104.003op/s ± 2945.759op/s 1980750.407op/s ± 2097.217op/s 1983534.952op/s 1985311.168op/s 1987271.200op/s 1989633.787op/s 0.45% -0.630 3.679 0.15% 208.297op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 454.178µs 455.686µs ± 0.607µs 455.698µs ± 0.388µs 456.080µs 456.577µs 456.987µs 459.550µs 0.85% 1.128 7.130 0.13% 0.043µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2176040.359op/s 2194498.122op/s ± 2919.396op/s 2194438.076op/s ± 1870.257op/s 2196353.148op/s 2198964.048op/s 2200580.969op/s 2201782.100op/s 0.33% -1.097 6.923 0.13% 206.432op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 177.398µs 177.828µs ± 0.202µs 177.814µs ± 0.081µs 177.896µs 178.030µs 178.255µs 179.398µs 0.89% 3.584 24.802 0.11% 0.014µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5574200.425op/s 5623413.995op/s ± 6365.202op/s 5623839.097op/s ± 2575.310op/s 5626419.471op/s 5631397.122op/s 5635176.617op/s 5637033.606op/s 0.23% -3.537 24.378 0.11% 450.088op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.580µs 37.692µs ± 0.038µs 37.690µs ± 0.023µs 37.716µs 37.765µs 37.791µs 37.810µs 0.32% 0.306 0.308 0.10% 0.003µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26448089.238op/s 26530823.972op/s ± 27007.461op/s 26532140.675op/s ± 16296.822op/s 26548029.156op/s 26570064.767op/s 26588868.569op/s 26609854.627op/s 0.29% -0.299 0.304 0.10% 1909.716op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.224µs 48.311µs ± 0.049µs 48.305µs ± 0.031µs 48.343µs 48.402µs 48.485µs 48.509µs 0.42% 1.010 1.931 0.10% 0.004µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20614895.480op/s 20699042.858op/s ± 21185.896op/s 20701686.000op/s ± 13112.246op/s 20712551.795op/s 20729067.939op/s 20734324.970op/s 20736601.799op/s 0.17% -1.001 1.900 0.10% 1498.069op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [504.666µs; 504.874µs] or [-0.021%; +0.021%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1980695.749op/s; 1981512.256op/s] or [-0.021%; +0.021%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [455.602µs; 455.770µs] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2194093.522op/s; 2194902.722op/s] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [177.800µs; 177.856µs] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5622531.839op/s; 5624296.151op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.687µs; 37.697µs] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26527080.998op/s; 26534566.946op/s] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [48.305µs; 48.318µs] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20696106.697op/s; 20701979.020op/s] or [-0.014%; +0.014%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz ec26aa7 1744747531 levi/labels
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 34.116µs 34.620µs ± 0.777µs 34.281µs ± 0.120µs 34.488µs 36.185µs 36.214µs 38.774µs 13.11% 1.988 3.798 2.24% 0.055µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [34.512µs; 34.728µs] or [-0.311%; +0.311%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz ec26aa7 1744747531 levi/labels
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 243.651ns 255.775ns ± 13.389ns 248.952ns ± 4.084ns 266.389ns 280.535ns 290.537ns 292.717ns 17.58% 1.100 -0.050 5.22% 0.947ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [253.919ns; 257.630ns] or [-0.725%; +0.725%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz ec26aa7 1744747531 levi/labels
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 65.724µs 65.909µs ± 0.297µs 65.874µs ± 0.042µs 65.919µs 66.094µs 66.276µs 69.874µs 6.07% 12.026 157.443 0.45% 0.021µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [65.868µs; 65.951µs] or [-0.062%; +0.062%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 23 lines in your changes missing coverage. Please review.

Project coverage is 71.53%. Comparing base (64fd851) to head (ec26aa7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1025      +/-   ##
==========================================
- Coverage   71.54%   71.53%   -0.01%     
==========================================
  Files         339      339              
  Lines       50693    50683      -10     
==========================================
- Hits        36267    36258       -9     
+ Misses      14426    14425       -1     
Components Coverage Δ
crashtracker 42.82% <ø> (ø)
crashtracker-ffi 6.30% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 90.93% <ø> (ø)
data-pipeline-ffi 90.35% <ø> (ø)
ddcommon 78.57% <ø> (ø)
ddcommon-ffi 66.37% <ø> (ø)
ddtelemetry 60.29% <ø> (ø)
ddtelemetry-ffi 21.43% <ø> (ø)
dogstatsd-client 82.57% <ø> (ø)
ipc 82.41% <ø> (ø)
profiling 77.53% <75.00%> (+0.08%) ⬆️
profiling-ffi 62.12% <0.00%> (-0.17%) ⬇️
serverless 0.00% <ø> (ø)
sidecar 41.14% <ø> (ø)
sidecar-ffi 2.05% <ø> (ø)
spawn-worker 54.37% <ø> (ø)
tinybytes 89.86% <ø> (ø)
trace-mini-agent 73.82% <ø> (ø)
trace-normalization 98.24% <ø> (ø)
trace-obfuscation 96.00% <ø> (ø)
trace-protobuf 78.50% <ø> (ø)
trace-utils 92.82% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@r1viollet
Copy link
Contributor

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 24.21 MB 24.21 MB --.01% (-2.85 KB) 💪
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.79 MB 7.79 MB -0% (-504 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 78.04 MB 78.03 MB --.01% (-8.25 KB) 💪
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 7.71 MB 7.71 MB -0% (-512 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 22.82 MB 22.81 MB --.01% (-2.75 KB) 💪
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 72.40 MB 72.40 MB --.01% (-8.08 KB) 💪
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 17.01 MB 17.01 MB --.01% (-2.00 KB) 💪
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 61.83 KB 61.83 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 114.22 MB 114.17 MB --.04% (-48.00 KB) 💪
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 633.87 MB 633.63 MB --.03% (-245.04 KB) 💪
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 5.06 MB 5.06 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 61.83 KB 61.83 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 16.15 MB 16.15 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 26.84 MB 26.83 MB --.01% (-3.93 KB) 💪
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 14.40 MB 14.40 MB --.01% (-2.50 KB) 💪
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 62.78 KB 62.78 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 116.22 MB 116.19 MB --.02% (-32.00 KB) 💪
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 625.75 MB 625.37 MB --.06% (-386.44 KB) 💪
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 3.83 MB 3.83 MB --.02% (-1.00 KB) 💪
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 62.78 KB 62.78 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 16.78 MB 16.77 MB --.04% (-8.00 KB) 💪
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 24.74 MB 24.74 MB --.01% (-3.56 KB) 💪
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 67.28 MB 67.28 MB -0% (-6.25 KB) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.27 MB 8.27 MB -0% (-312 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 23.35 MB 23.34 MB -0% (-2.16 KB) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 68.25 MB 68.24 MB -0% (-6.59 KB) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 8.15 MB 8.15 MB -0% (-312 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 20.99 MB 20.99 MB --.01% (-2.21 KB) 💪

@morrisonlevi morrisonlevi merged commit 6596921 into main Apr 15, 2025
35 checks passed
@morrisonlevi morrisonlevi deleted the levi/labels branch April 15, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

profiling Relates to the profiling* modules.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants