Skip to content

Conversation

@sethsamuel
Copy link
Contributor

What does this PR do?

Fixes the interval that's used to calculate missed collections for DBM async jobs.

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.13%. Comparing base (c34f53a) to head (4c6c66d).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Oct 28, 2025

⚠️ Tests

⚠️ Warnings

❄️ 2 New flaky tests detected

test_backend_transaction_age from test_pg_integration.py (Datadog)
Needed exactly 0 candidates for 'postgresql.activity.backend_xmin_age', got 1
Expected:
        MetricStub(name='postgresql.activity.backend_xmin_age', type=None, value=None, tags=['app:test_backend_transaction_age', 'database_hostname:stubbed.hostname', 'database_instance:stubbed.hostname', 'db:datadog_test', 'dd.internal.resource:database_instance:stubbed.hostname', 'foo:bar', 'port:5432', 'postgresql_cluster_name:primary', 'postgresql_version:12.17', 'replication_role:master', 'system_identifier:7566296568732680221', 'user:datadog'], hostname=None, device=None, flush_first_value=None)
Difference to closest:


Similar submitted:
Score   Most similar
1.00    MetricStub(name='postgresql.activity.backend_xmin_age', type=0, value=4.0, tags=['app:test_backend_transaction_age', 'database_hostname:stubbed.hostname', 'database_instance:stubbed.hostname', 'db:datadog_test', 'dd.internal.resource:database_instance:stubbed.hostname', 'foo:bar', 'port:5432', 'postgresql_cluster_name:primary', 'postgresql_version:12.17', 'replication_role:master', 'system_identifier:7566296568732680221', 'user:datadog'], hostname='stubbed.hostname', device=None, flush_first_value=False)
0.99    MetricStub(name='postgresql.activity.backend_xmin_age', type=0, value=4.0, tags=['app:datadog-agent', 'database_hostname:stubbed.hostname', 'database_instance:stubbed.hostname', 'db:datadog_test', 'dd.internal.resource:database_instance:stubbed.hostname', 'foo:bar', 'port:5432', 'postgresql_cluster_name:primary', 'postgresql_version:12.17', 'replication_role:master', 'system_identifier:7566296568732680221', 'user:datadog'], hostname='stubbed.hostname', device=None, flush_first_value=False)
...
test_conflicts_snapshot from test_pg_replication.py (Datadog)
Needed at least 1 candidates for 'postgresql.conflicts.snapshot', got 0
Expected:
        MetricStub(name='postgresql.conflicts.snapshot', type=None, value=1, tags=['database_hostname:stubbed.hostname', 'database_instance:stubbed.hostname', 'db:datadog_test', 'dd.internal.resource:database_instance:stubbed.hostname', 'foo:bar', 'port:5434', 'postgresql_version:12.17', 'replication_role:standby'], hostname=None, device=None, flush_first_value=None)
Difference to closest:
        Expected name: postgresql.conflicts.snapshot
        Found postgresql.conflicts.lock

Similar submitted:
Score   Most similar
0.89    MetricStub(name='postgresql.conflicts.lock', type=3, value=1.0, tags=['database_hostname:stubbed.hostname', 'database_instance:stubbed.hostname', 'db:datadog_test', 'dd.internal.resource:database_instance:stubbed.hostname', 'foo:bar', 'port:5434', 'postgresql_version:12.17', 'replication_role:standby'], hostname='stubbed.hostname', device=None, flush_first_value=False)
...

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4c6c66d | Docs | Was this helpful? Give us feedback!

@sethsamuel sethsamuel added this pull request to the merge queue Oct 29, 2025
Merged via the queue into master with commit 526cbd4 Oct 29, 2025
577 of 579 checks passed
@sethsamuel sethsamuel deleted the seth.samuel/fix-missed-collection-interval branch October 29, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants