Skip to content

Conversation

@sethsamuel
Copy link
Contributor

What does this PR do?

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@sethsamuel sethsamuel changed the title Seth.samuel/dbmon 5800 move postgres to new schema collector Migrate Postgres to new schema collector Oct 22, 2025
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 90.21526% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.03%. Comparing base (46169ca) to head (4b2fb31).
⚠️ Report is 44 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-official
Copy link
Contributor

datadog-official bot commented Oct 22, 2025

⚠️ Tests

⚠️ Warnings

❄️ 4 New flaky tests detected

test_collect_schemas[custom_ignore_schemas_owned_by] from test_metadata.py (Datadog)
assert 'num_partitions' in ['id', 'name', 'columns', 'indexes', 'foreign_keys']
test_collect_schemas[default_ignore_schemas_owned_by] from test_metadata.py (Datadog)
assert 'num_partitions' in ['id', 'name', 'columns', 'indexes', 'foreign_keys']
test_tables from test_schemas.py (Datadog)
assert {'personsdup11', 'pgtable', 'test_part_no_children', 'cities', 'personsdup9', 'personsdup3', 'personsdup5', 'test_part_no_activity', 'personsdup6', 'personsdup2', 'sample_foreign_d73a8c', 'personsdup1', 'persons', 'personsdup7', 'personsdup8', 'persons_indexed', 'personsdup12', 'pg_newtable', 'test_part', 'personsdup13', 'personsdup10', 'personsdup4'} == {'persons', 'personsdup11', 'personsdup7', 'personsdup8', 'pgtable', 'persons_indexed', 'cities', 'personsdup9', 'personsdup3', 'personsdup12', 'pg_newtable', 'personsdup5', 'personsdup6', 'personsdup2', 'sample_foreign_d73a8c', 'personsdup1', 'personsdup13', 'personsdup10', 'personsdup4'}
  
  Extra items in the left set:
  �[0m�[33m'�[39;49;00m�[33mtest_part�[39;49;00m�[33m'�[39;49;00m�[90m�[39;49;00m
  �[0m�[33m'�[39;49;00m�[33mtest_part_no_children�[39;49;00m�[33m'�[39;49;00m�[90m�[39;49;00m
  �[0m�[33m'�[39;49;00m�[33mtest_part_no_activity�[39;49;00m�[33m'�[39;49;00m�[90m�[39;49;00m
  
  Full diff:
  �[0m�[90m �[39;49;00m {�[90m�[39;49;00m
  �[90m �[39;49;00m     'cities',�[90m�[39;49;00m
...
test_statement_reported_hostname[override.hostname-override.hostname] from test_statements.py (Datadog)
should have collected at least one sample
assert []
View all

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4b2fb31 | Docs | Was this helpful? Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants