Switch to Python Build Standalone for macOS wheels
#21716
+14
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdesgroppes
force-pushed
the
regis.desgroppes/require-archs-on-macos-with-ofek-recommendation
branch
6 times, most recently
from
f75db89 to
d03a228
Compare
rdesgroppes
force-pushed
the
regis.desgroppes/require-archs-on-macos-with-ofek-recommendation
branch
from
d03a228 to
a2711b7
Compare
rdesgroppes
force-pushed
the
regis.desgroppes/require-archs-on-macos-with-ofek-recommendation
branch
from
a2711b7 to
77d35ca
Compare
rdesgroppes
changed the title
Python Build Standalone for macOS wheels
iliakur
previously approved these changes
Oct 27, 2025
temporal-github-worker-1
bot
added
agent/approved
and removed
agent/review-requested
labels
aiuto
reviewed
Oct 27, 2025
|
Good timing for this PR. We need to switch to a hermetic python for bazel. I am also sort of curious why we do this at all (for omnibus) when all the build machines and dev images have python 3.12 installed. But answering that should not block the this |
Looking at #21160, I guess the question would be better answered by @Kyle-Neale? |
ofek
approved these changes
Oct 27, 2025
This is a follow-up of: - #21692 ... where a review comment rightfully suggested that: > Instead, we should run a normal single-arch Python distribution where > everything will just work by default and we can remove the renaming > logic. The source of distributions should be the > [python-build-standalone](https://github.com/astral-sh/python-build-standalone) > project which the makers of UV recently adopted. They are used by > everyone nowadays, even > [rules_python](https://github.com/bazel-contrib/rules_python/blob/cf594f780c91f13d48e77faad34df48ac57398da/python/versions.bzl#L29). The present change aims at embracing the above-recommended approach, which looks indeed promising because the need for bundling targeted architectures is then addressed without additional environment variables, while still allowing `delocate_wheel` to verify architecture requirements. Also, the PBS distribution happens to be pretty lightweight (16MB vs 71MB).
This is to address: > n00b claude user, does this need to stay in the source code? (#21716 (comment)) > Looks good to me pending removal of the Claude comment! (#21716 (review))
rdesgroppes
force-pushed
the
regis.desgroppes/require-archs-on-macos-with-ofek-recommendation
branch
from
77d35ca to
a4238c3
Compare
temporal-github-worker-1
bot
dismissed
iliakur’s stale review
Review from iliakur is dismissed. Related teams and files:
- agent-integrations
- .github/workflows/resolve-build-deps.yaml
temporal-github-worker-1
bot
added
agent/review-requested
and removed
agent/approved
labels
iliakur
approved these changes
Oct 27, 2025
temporal-github-worker-1
bot
added
agent/approved
and removed
agent/review-requested
labels
Done in second commit (a4238c3). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a direct follow-up of:
... where a review comment rightfully suggested that:
What does this PR do?
The present change aims at embracing the above-recommended approach, which indeed looks simpler because the need for bundling targeted architectures is then addressed without additional environment variables, while still allowing
delocate_wheelto verify architecture requirements.Also, the PBS distribution happens to be pretty lightweight (16MB vs 71MB).