Adding formatting checks #615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikretz
reviewed
Oct 2, 2025
| return False, "" | ||
|
|
||
| output_lines = '\n'.join( | ||
| output_lines = "\n".join( |
There was a problem hiding this comment.
This is irritating tbh. Single quotes for single chars is totally acceptable.
ikretz
reviewed
Oct 2, 2025
Comment on lines
+63
to
+70
| f"The domain name of the maintainer's email address ({email}) was" | ||
| " re-registered after" | ||
| " the latest release of this " | ||
| "package. This can be an indicator that this is a" | ||
| " custom domain that expired, and was leveraged by" | ||
| " an attacker to compromise the" | ||
| f" package owner's {self.ecosystem}" | ||
| " account." |
ikretz
reviewed
Oct 2, 2025
Comment on lines
+15
to
+16
| description="Identify packages with a linked GitHub repository " | ||
| "where the package has extra unexpected files", |
There was a problem hiding this comment.
This looks bad, I think it should enclose the substrings in () if it's gonna break them up like this.
There was a problem hiding this comment.
don't you miss cargo format?
ikretz
approved these changes
Oct 2, 2025
tesnim5hamdouni
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding black for formatting