Skip to content

Conversation

@strongHunter
Copy link

Network errors are now handled and logged. If fetching from the internet fails, the local file is used. Minor code refactoring was performed. The module is now always returns data.

Previously, if the local file was outdated, the module would attempt to fetch it from the network. If a network error occurred, this would cause to fail.

@sobregosodd
Copy link
Contributor

sobregosodd commented Oct 9, 2025

Hello @strongHunter , thanks for the contribution,
I've realized that some checks are not passing, mostly because the linting errors and typing errors, since functions don't always return the same value type (depending on the raise).
Let me know if you can address them.

tip: there is a Makefile that helps with this checks, ie: make lint; make type-check; make format

@strongHunter
Copy link
Author

Fixed. Check out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants