Skip to content

Temporarily cap supported next.js version range to <15.4.1 #6094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/apm-integrations.yml
Original file line number Diff line number Diff line change
Expand Up @@ -754,7 +754,7 @@ jobs:
version:
- 18
- latest
range: ['>=10.2.0 <11', '>=11.0.0 <13', '11.1.4', '>=13.0.0 <14', '13.2.0', '>=14.0.0 <=14.2.6', '>=14.2.7 <15', '>=15.0.0']
range: ['>=10.2.0 <11', '>=11.0.0 <13', '11.1.4', '>=13.0.0 <14', '13.2.0', '>=14.0.0 <=14.2.6', '>=14.2.7 <15', '>=15.0.0 <15.4.1']
include:
- range: '>=10.2.0 <11'
range_clean: gte.10.2.0.and.lt.11
Expand All @@ -770,7 +770,7 @@ jobs:
range_clean: gte.14.0.0.and.lte.14.2.6
- range: '>=14.2.7 <15'
range_clean: gte.14.2.7.and.lt.15
- range: '>=15.0.0'
- range: '>=15.0.0 <15.4.1'
range_clean: gte.15.0.0
runs-on: ubuntu-latest
env:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/appsec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ jobs:
version:
- oldest
- latest
range: ['>=10.2.0 <11', '>=11.0.0 <13', '11.1.4', '>=13.0.0 <14', '13.2.0', '>=14.0.0 <=14.2.6', '>=14.2.7 <15', '>=15.0.0']
range: ['>=10.2.0 <11', '>=11.0.0 <13', '11.1.4', '>=13.0.0 <14', '13.2.0', '>=14.0.0 <=14.2.6', '>=14.2.7 <15', '>=15.0.0 <15.4.1']
include:
- range: '>=10.2.0 <11'
range_clean: gte.10.2.0.and.lt.11
Expand All @@ -232,7 +232,7 @@ jobs:
range_clean: gte.14.0.0.and.lte.14.2.6
- range: '>=14.2.7 <15'
range_clean: gte.14.2.7.and.lt.15
- range: '>=15.0.0'
- range: '>=15.0.0 <15.4.1'
range_clean: gte.15.0.0
runs-on: ubuntu-latest
env:
Expand Down
10 changes: 5 additions & 5 deletions packages/datadog-instrumentations/src/next.js
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ function finish (ctx, result, err) {
// however, it is not provided as a class function or exported property
addHook({
name: 'next',
versions: ['>=13.3.0'],
versions: ['>=13.3.0 <15.4.1'],
file: 'dist/server/web/spec-extension/adapters/next-request.js'
}, NextRequestAdapter => {
shimmer.wrap(NextRequestAdapter.NextRequestAdapter, 'fromNodeNextRequest', fromNodeNextRequest => {
Expand All @@ -212,7 +212,7 @@ addHook({

addHook({
name: 'next',
versions: ['>=11.1'],
versions: ['>=11.1 <15.4.1'],
file: 'dist/server/serve-static.js'
}, serveStatic => shimmer.wrap(serveStatic, 'serveStatic', wrapServeStatic, { replaceGetter: true }))

Expand All @@ -222,7 +222,7 @@ addHook({
file: 'dist/next-server/server/serve-static.js'
}, serveStatic => shimmer.wrap(serveStatic, 'serveStatic', wrapServeStatic, { replaceGetter: true }))

addHook({ name: 'next', versions: ['>=11.1'], file: 'dist/server/next-server.js' }, nextServer => {
addHook({ name: 'next', versions: ['>=11.1 <15.4.1'], file: 'dist/server/next-server.js' }, nextServer => {
const Server = nextServer.default

shimmer.wrap(Server.prototype, 'handleRequest', wrapHandleRequest)
Expand All @@ -239,7 +239,7 @@ addHook({ name: 'next', versions: ['>=11.1'], file: 'dist/server/next-server.js'
})

// `handleApiRequest` changes parameters/implementation at 13.2.0
addHook({ name: 'next', versions: ['>=13.2'], file: 'dist/server/next-server.js' }, nextServer => {
addHook({ name: 'next', versions: ['>=13.2 <15.4.1'], file: 'dist/server/next-server.js' }, nextServer => {
const Server = nextServer.default
shimmer.wrap(Server.prototype, 'handleApiRequest', wrapHandleApiRequestWithMatch)
return nextServer
Expand Down Expand Up @@ -277,7 +277,7 @@ addHook({

addHook({
name: 'next',
versions: ['>=13'],
versions: ['>=13 <15.4.1'],
file: 'dist/server/web/spec-extension/request.js'
}, request => {
shimmer.wrap(request.NextRequest.prototype, 'nextUrl', function (originalGet) {
Expand Down
2 changes: 1 addition & 1 deletion packages/datadog-plugin-next/test/index.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ describe('Plugin', function () {
const satisfiesStandalone = version => satisfies(version, '>=12.0.0')

// TODO: Figure out why 10.x tests are failing.
withVersions('next', 'next', '>=11.1', version => {
withVersions('next', 'next', '>=11.1 <15.4.1', version => {
const pkg = require(`../../../versions/next@${version}/node_modules/next/package.json`)

const startServer = ({ withConfig, standalone }, schemaVersion = 'v0', defaultToGlobalService = false) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ describe('esm', () => {
let proc
let sandbox
// match versions tested with unit tests
withVersions('next', 'next', '>=11.1', version => {
withVersions('next', 'next', '>=11.1 <15.4.1', version => {
before(async function () {
// next builds slower in the CI, match timeout with unit tests
this.timeout(300 * 1000)
Expand Down
2 changes: 1 addition & 1 deletion packages/dd-trace/test/appsec/index.next.plugin.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ describe('test suite', () => {

const satisfiesStandalone = version => satisfies(version, '>=12.0.0')

withVersions('next', 'next', '>=11.1', version => {
withVersions('next', 'next', '>=11.1 <15.4.1', version => {
if (version === '>=11.0.0 <13' && NODE_MAJOR === 24 &&
NODE_MINOR === 0 && NODE_PATCH === 0) {
return // node 24.0.0 fails, but 24.0.1 works
Expand Down
Loading