Skip to content

Revert "ci: add paths config to workflows for github & pull_request trigger (#5891)" #6093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

Revert "ci: add paths config to workflows for github & pull_request trigger (#5891)" #6093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions .github/workflows/apm-capabilities.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,6 @@ name: APM Capabilities

on:
pull_request:
paths:
# Paths for whole project (should be same in all workflows)
- '**'
- '!.github/workflows/**'
- '!.gitlab/**'
- '!.vscode/**'
- '!devdocs/**'
- '!examples/**'
- '!*.md'
- '!.gitlab-ci.yml'
- '!LICENSE*'
- 'LICENSE-3rdparty.csv'
- '!NOTICE'
# Paths for this workflow only
- '.github/workflows/apm-capabilities.yml'
push:
branches: [master]
schedule:
Expand Down
15 changes: 0 additions & 15 deletions .github/workflows/apm-integrations.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,6 @@ name: APM Integrations

on:
pull_request:
paths:
# Paths for whole project (should be same in all workflows)
- '**'
- '!.github/workflows/**'
- '!.gitlab/**'
- '!.vscode/**'
- '!devdocs/**'
- '!examples/**'
- '!*.md'
- '!.gitlab-ci.yml'
- '!LICENSE*'
- 'LICENSE-3rdparty.csv'
- '!NOTICE'
# Paths for this workflow only
- '.github/workflows/apm-integrations.yml'
push:
branches: [master]
schedule:
Expand Down
15 changes: 0 additions & 15 deletions .github/workflows/appsec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,6 @@ name: AppSec

on:
pull_request:
paths:
# Paths for whole project (should be same in all workflows)
- '**'
- '!.github/workflows/**'
- '!.gitlab/**'
- '!.vscode/**'
- '!devdocs/**'
- '!examples/**'
- '!*.md'
- '!.gitlab-ci.yml'
- '!LICENSE*'
- 'LICENSE-3rdparty.csv'
- '!NOTICE'
# Paths for this workflow only
- '.github/workflows/appsec.yml'
push:
branches: [master]
schedule:
Expand Down
15 changes: 0 additions & 15 deletions .github/workflows/debugger.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,6 @@ name: Debugger

on:
pull_request:
paths:
# Paths for whole project (should be same in all workflows)
- '**'
- '!.github/workflows/**'
- '!.gitlab/**'
- '!.vscode/**'
- '!devdocs/**'
- '!examples/**'
- '!*.md'
- '!.gitlab-ci.yml'
- '!LICENSE*'
- 'LICENSE-3rdparty.csv'
- '!NOTICE'
# Paths for this workflow only
- '.github/workflows/debugger.yml'
push:
branches: [master]
schedule:
Expand Down
15 changes: 0 additions & 15 deletions .github/workflows/lambda.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,6 @@ name: Lambda

on:
pull_request:
paths:
# Paths for whole project (should be same in all workflows)
- '**'
- '!.github/workflows/**'
- '!.gitlab/**'
- '!.vscode/**'
- '!devdocs/**'
- '!examples/**'
- '!*.md'
- '!.gitlab-ci.yml'
- '!LICENSE*'
- 'LICENSE-3rdparty.csv'
- '!NOTICE'
# Paths for this workflow only
- '.github/workflows/lambda.yml'
push:
branches: [master]
schedule:
Expand Down
15 changes: 0 additions & 15 deletions .github/workflows/llmobs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,6 @@ name: LLMObs

on:
pull_request:
paths:
# Paths for whole project (should be same in all workflows)
- '**'
- '!.github/workflows/**'
- '!.gitlab/**'
- '!.vscode/**'
- '!devdocs/**'
- '!examples/**'
- '!*.md'
- '!.gitlab-ci.yml'
- '!LICENSE*'
- 'LICENSE-3rdparty.csv'
- '!NOTICE'
# Paths for this workflow only
- '.github/workflows/llmobs.yml'
push:
branches: [master]
schedule:
Expand Down
15 changes: 0 additions & 15 deletions .github/workflows/platform.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,6 @@ name: Platform

on:
pull_request:
paths:
# Paths for whole project (should be same in all workflows)
- '**'
- '!.github/workflows/**'
- '!.gitlab/**'
- '!.vscode/**'
- '!devdocs/**'
- '!examples/**'
- '!*.md'
- '!.gitlab-ci.yml'
- '!LICENSE*'
- 'LICENSE-3rdparty.csv'
- '!NOTICE'
# Paths for this workflow only
- '.github/workflows/platform.yml'
push:
branches: [master]
schedule:
Expand Down
15 changes: 0 additions & 15 deletions .github/workflows/profiling.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,6 @@ name: Profiling

on:
pull_request:
paths:
# Paths for whole project (should be same in all workflows)
- '**'
- '!.github/workflows/**'
- '!.gitlab/**'
- '!.vscode/**'
- '!devdocs/**'
- '!examples/**'
- '!*.md'
- '!.gitlab-ci.yml'
- '!LICENSE*'
- 'LICENSE-3rdparty.csv'
- '!NOTICE'
# Paths for this workflow only
- '.github/workflows/profiling.yml'
push:
branches: [master]
schedule:
Expand Down
15 changes: 0 additions & 15 deletions .github/workflows/project.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,6 @@ name: Project

on:
pull_request:
paths:
# Paths for whole project (should be same in all workflows)
- '**'
- '!.github/workflows/**'
- '!.gitlab/**'
- '!.vscode/**'
- '!devdocs/**'
- '!examples/**'
- '!*.md'
- '!.gitlab-ci.yml'
- '!LICENSE*'
- 'LICENSE-3rdparty.csv'
- '!NOTICE'
# Paths for this workflow only
- '.github/workflows/**'
push:
branches: [master]

Expand Down
15 changes: 0 additions & 15 deletions .github/workflows/system-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,6 @@ name: System Tests

on:
pull_request:
paths:
# Paths for whole project (should be same in all workflows)
- '**'
- '!.github/workflows/**'
- '!.gitlab/**'
- '!.vscode/**'
- '!devdocs/**'
- '!examples/**'
- '!*.md'
- '!.gitlab-ci.yml'
- '!LICENSE*'
- 'LICENSE-3rdparty.csv'
- '!NOTICE'
# Paths for this workflow only
- '.github/workflows/system-tests.yml'
push:
branches: [master]
workflow_dispatch:
Expand Down
15 changes: 0 additions & 15 deletions .github/workflows/test-optimization.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,6 @@ name: Test Optimization

on:
pull_request:
paths:
# Paths for whole project (should be same in all workflows)
- '**'
- '!.github/workflows/**'
- '!.gitlab/**'
- '!.vscode/**'
- '!devdocs/**'
- '!examples/**'
- '!*.md'
- '!.gitlab-ci.yml'
- '!LICENSE*'
- 'LICENSE-3rdparty.csv'
- '!NOTICE'
# Paths for this workflow only
- '.github/workflows/test-optimization.yml'
push:
branches:
- master
Expand Down
48 changes: 0 additions & 48 deletions .gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,56 +16,8 @@ stages:

include:
- local: ".gitlab/one-pipeline.locked.yml"
rules:
- changes:
paths:
# Paths for whole project (should be same in all workflows)
- '**'
- '!.github/workflows/**'
- '!.gitlab/**'
- '!.vscode/**'
- '!devdocs/**'
- '!examples/**'
- '!*.md'
- '!LICENSE*'
- 'LICENSE-3rdparty.csv'
- '!NOTICE'
# Paths for this workflow only
- '.gitlab/one-pipeline.locked.yml'
- local: ".gitlab/benchmarks.yml"
rules:
- changes:
paths:
# Paths for whole project (should be same in all workflows)
- '**'
- '!.github/workflows/**'
- '!.gitlab/**'
- '!.vscode/**'
- '!devdocs/**'
- '!examples/**'
- '!*.md'
- '!LICENSE*'
- 'LICENSE-3rdparty.csv'
- '!NOTICE'
# Paths for this workflow only
- '.gitlab/benchmarks.yml'
- local: ".gitlab/macrobenchmarks.yml"
rules:
- changes:
paths:
# Paths for whole project (should be same in all workflows)
- '**'
- '!.github/workflows/**'
- '!.gitlab/**'
- '!.vscode/**'
- '!devdocs/**'
- '!examples/**'
- '!*.md'
- '!LICENSE*'
- 'LICENSE-3rdparty.csv'
- '!NOTICE'
# Paths for this workflow only
- '.gitlab/macrobenchmarks.yml'

workflow:
rules:
Expand Down
8 changes: 4 additions & 4 deletions scripts/verify-ci-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ const IGNORED_WORKFLOWS = {
'retry.yml'
],
trigger_pull_request: [
'audit.yml',
'eslint-rules.yml',
'stale.yml'
],
Expand All @@ -200,10 +201,9 @@ for (const workflow of workflows) {
const yamlPath = path.join(__dirname, '..', '.github', 'workflows', workflow)
const yamlContent = yaml.parse(fs.readFileSync(yamlPath, 'utf8'))
const triggers = yamlContent.on
if (!IGNORED_WORKFLOWS.trigger_pull_request.includes(workflow)) {
if (triggers?.pull_request !== null && Object.keys(triggers.pull_request).toString() !== 'paths') {
triggersError(workflow, 'The `pull_request` trigger should be blank or only include paths')
}
if (!IGNORED_WORKFLOWS.trigger_pull_request.includes(workflow) &&
triggers?.pull_request !== null) {
triggersError(workflow, 'The `pull_request` trigger should be blank')
}
if (!IGNORED_WORKFLOWS.trigger_push.includes(workflow) &&
triggers?.push?.branches?.[0] !== 'master') {
Expand Down
Loading