API Security -Add support for trace tagging rules #6075
+292
−70
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| 'use strict' | ||
|
|
||
| const { assert } = require('chai') | ||
| const path = require('path') | ||
| const Axios = require('axios') | ||
|
|
||
| const { | ||
| createSandbox, | ||
| FakeAgent, | ||
| spawnProc | ||
| } = require('../helpers') | ||
|
|
||
| describe('ASM Trace Tagging rules', () => { | ||
| let axios, sandbox, cwd, appFile, agent, proc | ||
|
|
||
| function startServer () { | ||
| beforeEach(async () => { | ||
| agent = await new FakeAgent().start() | ||
|
|
||
| const env = { | ||
| DD_TRACE_AGENT_PORT: agent.port, | ||
| DD_APPSEC_ENABLED: true, | ||
| DD_APPSEC_RULES: path.join(cwd, 'appsec', 'data-collection', 'data-collection-rules.json') | ||
| } | ||
|
|
||
| proc = await spawnProc(appFile, { cwd, env, execArgv: [] }) | ||
| axios = Axios.create({ baseURL: proc.url }) | ||
| }) | ||
|
|
||
| afterEach(async () => { | ||
| proc.kill() | ||
| await agent.stop() | ||
| }) | ||
| } | ||
|
|
||
| describe('express', () => { | ||
| before(async () => { | ||
| sandbox = await createSandbox(['express']) | ||
| cwd = sandbox.folder | ||
| appFile = path.join(cwd, 'appsec/data-collection/index.js') | ||
| }) | ||
|
|
||
| after(async () => { | ||
| await sandbox.remove() | ||
| }) | ||
|
|
||
| startServer() | ||
|
|
||
| it('should report waf attributes', async () => { | ||
| await axios.get('/', { headers: { 'User-Agent': 'TraceTaggingTest/v1' } }) | ||
|
|
||
| await agent.assertMessageReceived(({ _, payload }) => { | ||
| assert.property(payload[0][0].meta, '_dd.appsec.trace.agent') | ||
| assert.strictEqual(payload[0][0].meta['_dd.appsec.trace.agent'], 'TraceTaggingTest/v1') | ||
| assert.property(payload[0][0].metrics, '_dd.appsec.trace.integer') | ||
| assert.strictEqual(payload[0][0].metrics['_dd.appsec.trace.integer'], 1234) | ||
| }) | ||
| }) | ||
| }) | ||
|
|
||
| describe('fastify', () => { | ||
| before(async () => { | ||
| sandbox = await createSandbox(['fastify']) | ||
| cwd = sandbox.folder | ||
| appFile = path.join(cwd, 'appsec/data-collection/fastify.js') | ||
| }) | ||
|
|
||
| after(async () => { | ||
| await sandbox.remove() | ||
| }) | ||
|
|
||
| startServer() | ||
|
|
||
| it('should report waf attributes', async () => { | ||
| let fastifyRequestReceived = false | ||
|
|
||
| await axios.get('/', { headers: { 'User-Agent': 'TraceTaggingTest/v1' } }) | ||
|
|
||
| await agent.assertMessageReceived(({ _, payload }) => { | ||
| if (payload[0][0].name !== 'fastify.request') { | ||
| throw new Error('Not the span we are looking for') | ||
| } | ||
|
|
||
| fastifyRequestReceived = true | ||
|
|
||
| assert.property(payload[0][0].meta, '_dd.appsec.trace.agent') | ||
| assert.strictEqual(payload[0][0].meta['_dd.appsec.trace.agent'], 'TraceTaggingTest/v1') | ||
| assert.property(payload[0][0].metrics, '_dd.appsec.trace.integer') | ||
| assert.strictEqual(payload[0][0].metrics['_dd.appsec.trace.integer'], 1234) | ||
| }, 30000, 10, true) | ||
|
|
||
| assert.isTrue(fastifyRequestReceived) | ||
| }) | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sampling priority relies now in the keep field returned by the waf and not in the event presence. Due to this, appsec rate limiter has been moved to waf.