v5.58.1 proposal #6062
Closed
v5.58.1 proposal #6062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dd-trace-js[bot]](https://avatars.githubusercontent.com/in/1216021?s=60&v=4){kind=small}
Use the `Error.captureStackTrace` API when triggering `Error.prepareStackTrace` in order to be able to provide a constructor function. This is used to reduce the number of unnecessary frames being generated.
Enables all recommended rules from the `eslint-plugin-n` ESLint plugin that can reasonably be enabled without too much work. The following rules have been disabled as they cause too many errors: - `n/hashbang` - `n/no-process-exit` - `n/no-missing-require` (only disabled in benchmarks and tests) All `eslint-plugin-n` rules are also disabled for `**/*.mjs` files as these for some reason resulting in parsing errors. Finally a select list of experimental Node.js APIs have been allowed in `n/no-unsupported-features/node-builtins`, so that we can use them without having to add ESLint comments all over the place: - `Response` - `async_hooks.createHook` - `async_hooks.executionAsyncId` - `async_hooks.executionAsyncResource` - `fetch` - `fs/promises.cp`
* chore: update lru-cache, less lookups, dependabot ignore update This updates the lru-cache to the latest version that supports Node.js 18. The version above is ignored in dependabot. It also ignores path-to-regexp, since that has to stay aligned with the one used in express.js v4. Express itself is updated as dev dependencies. That way we should notice earlier in case more things break. The cache lookups got a bit optimized to not have to check multiple times if an entry exists or not. * chore: outcommend alternative in docker-compose Only one should be used per port.
* Fix issues related to adding strict-mode These issues are either just a different behavior in strict-mode, changes to tests that expect specific lines, or hiding real errors.
* move test cleanup to hook
Overall package sizeSelf size: 9.61 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 9.0.0 | 19.6 MB | 19.61 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.9.0 | 9.77 MB | 10.14 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.3 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.14.2 | 122.36 kB | 850.93 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | limiter | 3.0.0 | 157.92 kB | 157.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.9 | 25.11 kB | 25.11 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v5.x #6062 +/- ##
=======================================
Coverage ? 81.84%
=======================================
Files ? 470
Lines ? 19403
Branches ? 0
=======================================
Hits ? 15881
Misses ? 3522
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2025-07-09 05:17:10 Comparing candidate commit edc1655 in PR branch Found 60 performance improvements and 0 performance regressions! Performance is the same for 1123 metrics, 45 unstable metrics. scenario:shimmer-startup-arrow-wrap-18
scenario:shimmer-startup-arrow-wrap-20
scenario:shimmer-startup-arrow-wrap-22
scenario:shimmer-startup-arrow-wrapfn-18
scenario:shimmer-startup-arrow-wrapfn-20
scenario:shimmer-startup-arrow-wrapfn-22
scenario:shimmer-startup-asyncarrow-wrap-18
scenario:shimmer-startup-asyncarrow-wrap-20
scenario:shimmer-startup-asyncarrow-wrap-22
scenario:shimmer-startup-asyncdeclared-wrap-18
scenario:shimmer-startup-asyncdeclared-wrap-20
scenario:shimmer-startup-asyncdeclared-wrap-22
scenario:shimmer-startup-declared-wrap-18
scenario:shimmer-startup-declared-wrap-20
scenario:shimmer-startup-declared-wrap-22
scenario:shimmer-startup-declared-wrapfn-18
scenario:shimmer-startup-declared-wrapfn-20
scenario:shimmer-startup-declared-wrapfn-22
|
|
Superseded by #6069. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b4edcab2a2] - (SEMVER-PATCH) test: remove get-port usage from inferred proxy test (Roch Devost) #6054f2f650b528] - (SEMVER-PATCH) ESLint: Require 'use strict' header (Thomas Watson) #53341f4d857a96] - (SEMVER-PATCH) chore: update dependencies & dependabot & less cache lookups (Ruben Bridgewater) #6041e7cf286691] - (SEMVER-PATCH) Enable recommended rules for eslint-plugin-n (Thomas Watson) #52169ff794ccfc] - (SEMVER-PATCH) perf: improve algorithm for getting callsites in AppSec (Thomas Watson) #6044