Skip to content

remove async storage from graphql #5966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

wconti27
Copy link
Contributor

What does this PR do?

Motivation

Plugin Checklist

Additional Notes

@wconti27 wconti27 requested review from a team as code owners June 26, 2025 19:54
@wconti27 wconti27 self-assigned this Jun 26, 2025
Copy link

github-actions bot commented Jun 26, 2025

Overall package size

Self size: 9.69 MB
Deduped: 109.27 MB
No deduping: 109.66 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.0.0 | 20.3 MB | 20.31 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.9.0 | 9.77 MB | 10.14 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.3 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.14.2 | 122.36 kB | 850.93 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.9 | 25.11 kB | 25.11 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.93%. Comparing base (2244cf0) to head (c17708e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5966      +/-   ##
==========================================
- Coverage   81.98%   81.93%   -0.05%     
==========================================
  Files         475      475              
  Lines       19598    19624      +26     
==========================================
+ Hits        16067    16079      +12     
- Misses       3531     3545      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: conti/remove-async-storage-graphql
Commit report: d065140
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 1257 Passed, 0 Skipped, 20m 16.99s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Jun 26, 2025

Benchmarks

Benchmark execution time: 2025-07-15 13:36:47

Comparing candidate commit c17708e in PR branch conti/remove-async-storage-graphql with baseline commit 2244cf0 in branch master.

Found 48 performance improvements and 0 performance regressions! Performance is the same for 1221 metrics, 54 unstable metrics.

scenario:plugin-graphql-with-depth-and-collapse-off-18

  • 🟩 cpu_user_time [-271.453ms; -227.789ms] or [-15.304%; -12.842%]
  • 🟩 execution_time [-294.555ms; -248.115ms] or [-15.246%; -12.843%]
  • 🟩 instructions [-524.7M instructions; -498.3M instructions] or [-13.185%; -12.522%]
  • 🟩 max_rss_usage [-17.925MB; -16.505MB] or [-11.075%; -10.198%]

scenario:plugin-graphql-with-depth-and-collapse-off-20

  • 🟩 cpu_user_time [-502.576ms; -451.690ms] or [-26.408%; -23.734%]
  • 🟩 execution_time [-572.710ms; -516.966ms] or [-27.297%; -24.640%]
  • 🟩 instructions [-1.4G instructions; -1.4G instructions] or [-31.075%; -30.214%]
  • 🟩 max_rss_usage [-59.500MB; -56.783MB] or [-28.550%; -27.246%]

scenario:plugin-graphql-with-depth-and-collapse-off-22

  • 🟩 cpu_user_time [-719.216ms; -677.876ms] or [-37.250%; -35.108%]
  • 🟩 execution_time [-798.367ms; -752.893ms] or [-36.239%; -34.175%]
  • 🟩 instructions [-1.9G instructions; -1.9G instructions] or [-37.870%; -37.191%]
  • 🟩 max_rss_usage [-74.206MB; -73.430MB] or [-32.555%; -32.214%]

scenario:plugin-graphql-with-depth-and-collapse-on-18

  • 🟩 cpu_user_time [-133.022ms; -113.532ms] or [-12.242%; -10.448%]
  • 🟩 execution_time [-139.201ms; -122.109ms] or [-11.583%; -10.161%]
  • 🟩 instructions [-339.0M instructions; -317.9M instructions] or [-14.399%; -13.503%]
  • 🟩 max_rss_usage [-8.053MB; -7.502MB] or [-6.327%; -5.894%]

scenario:plugin-graphql-with-depth-and-collapse-on-20

  • 🟩 cpu_user_time [-515.659ms; -493.069ms] or [-36.507%; -34.908%]
  • 🟩 execution_time [-555.415ms; -533.303ms] or [-35.766%; -34.342%]
  • 🟩 instructions [-1.4G instructions; -1.3G instructions] or [-42.517%; -41.715%]
  • 🟩 max_rss_usage [-57.559MB; -56.820MB] or [-33.143%; -32.717%]

scenario:plugin-graphql-with-depth-and-collapse-on-22

  • 🟩 cpu_user_time [-696.890ms; -675.195ms] or [-48.016%; -46.521%]
  • 🟩 execution_time [-766.489ms; -743.656ms] or [-45.515%; -44.160%]
  • 🟩 instructions [-1.8G instructions; -1.8G instructions] or [-47.341%; -46.675%]
  • 🟩 max_rss_usage [-68.962MB; -68.288MB] or [-36.156%; -35.802%]

scenario:plugin-graphql-with-depth-off-18

  • 🟩 cpu_user_time [-105.398ms; -84.549ms] or [-9.657%; -7.747%]
  • 🟩 execution_time [-111.113ms; -91.961ms] or [-9.221%; -7.632%]
  • 🟩 instructions [-347.7M instructions; -327.9M instructions] or [-14.354%; -13.535%]
  • 🟩 max_rss_usage [-10.756MB; -10.294MB] or [-8.248%; -7.893%]

scenario:plugin-graphql-with-depth-off-20

  • 🟩 cpu_user_time [-512.437ms; -491.137ms] or [-35.968%; -34.473%]
  • 🟩 execution_time [-552.712ms; -530.982ms] or [-35.347%; -33.957%]
  • 🟩 instructions [-1.4G instructions; -1.3G instructions] or [-41.949%; -40.950%]
  • 🟩 max_rss_usage [-58.351MB; -57.369MB] or [-33.272%; -32.712%]

scenario:plugin-graphql-with-depth-off-22

  • 🟩 cpu_user_time [-680.280ms; -658.943ms] or [-46.350%; -44.896%]
  • 🟩 execution_time [-748.499ms; -726.498ms] or [-44.009%; -42.715%]
  • 🟩 instructions [-1.8G instructions; -1.8G instructions] or [-46.580%; -45.900%]
  • 🟩 max_rss_usage [-68.068MB; -67.367MB] or [-35.536%; -35.170%]

scenario:plugin-graphql-with-depth-on-max-18

  • 🟩 cpu_user_time [-129.681ms; -110.708ms] or [-11.948%; -10.200%]
  • 🟩 execution_time [-136.807ms; -120.414ms] or [-11.421%; -10.052%]
  • 🟩 instructions [-347.1M instructions; -326.6M instructions] or [-14.706%; -13.837%]
  • 🟩 max_rss_usage [-8.191MB; -7.695MB] or [-6.436%; -6.047%]

scenario:plugin-graphql-with-depth-on-max-20

  • 🟩 cpu_user_time [-517.961ms; -496.435ms] or [-36.680%; -35.155%]
  • 🟩 execution_time [-558.716ms; -536.060ms] or [-35.978%; -34.519%]
  • 🟩 instructions [-1.4G instructions; -1.3G instructions] or [-43.132%; -42.098%]
  • 🟩 max_rss_usage [-57.349MB; -56.675MB] or [-33.049%; -32.660%]

scenario:plugin-graphql-with-depth-on-max-22

  • 🟩 cpu_user_time [-689.379ms; -668.213ms] or [-47.835%; -46.366%]
  • 🟩 execution_time [-761.470ms; -737.867ms] or [-45.449%; -44.040%]
  • 🟩 instructions [-1.8G instructions; -1.8G instructions] or [-47.502%; -46.579%]
  • 🟩 max_rss_usage [-69.795MB; -68.835MB] or [-36.456%; -35.955%]

@wconti27 wconti27 requested a review from rochdev July 14, 2025 19:12
@BridgeAR BridgeAR marked this pull request as draft July 15, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants