Skip to content

chore(tracing): remove async storage from mongo plugins #5812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 20 commits into
base: master
Choose a base branch
from
Draft

chore(tracing): remove async storage from mongo plugins #5812

wants to merge 20 commits into from
+96 −70

Conversation

wconti27
Copy link
Contributor

@wconti27 wconti27 commented Jun 3, 2025

What does this PR do?

Make mongo plugins Node 24 compatible

Motivation

Plugin Checklist

Additional Notes

@wconti27 wconti27 requested review from a team as code owners June 3, 2025 14:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2025 •
edited
Loading

Overall package size

Self size: 9.69 MB
Deduped: 109.27 MB
No deduping: 109.66 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.0.0 | 20.3 MB | 20.31 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.9.0 | 9.77 MB | 10.14 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.3 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.14.2 | 122.36 kB | 850.93 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.9 | 25.11 kB | 25.11 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov Codecov
Copy link

codecov bot commented Jun 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.93%. Comparing base (2244cf0) to head (aade700).
Report is 6 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5812      +/-   ##
==========================================
- Coverage   81.98%   81.93%   -0.05%     
==========================================
  Files         475      474       -1     
  Lines       19598    19523      -75     
==========================================
- Hits        16067    15997      -70     
+ Misses       3531     3526       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wconti27 wconti27 self-assigned this Jun 3, 2025
@pr-commenter
Copy link

pr-commenter bot commented Jun 3, 2025 •
edited
Loading

Benchmarks

Benchmark execution time: 2025-07-15 15:35:56

Comparing candidate commit aade700 in PR branch conti/remove-async-storage-mongo with baseline commit 2244cf0 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1274 metrics, 49 unstable metrics.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jun 3, 2025 •
edited
Loading

Datadog Report

Branch report: conti/remove-async-storage-mongo
Commit report: 080e076
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 1254 Passed, 0 Skipped, 17m 19.36s Total Time

@BridgeAR BridgeAR marked this pull request as draft June 4, 2025 11:47
@tlhunter tlhunter mentioned this pull request Jul 3, 2025
Open
61 tasks
@wconti27 wconti27 marked this pull request as ready for review July 9, 2025 15:41
tlhunter
tlhunter reviewed Jul 9, 2025
View reviewed changes
packages/datadog-instrumentations/src/mongodb-core.js Outdated
@@ -58,22 +57,6 @@ addHook({ name: 'mongodb-core', versions: ['~3.1.10'], file: 'lib/wireprotocol/2
return WireProtocol
})

addHook({ name: 'mongodb', versions: ['>=3.5.4 <4.11.0'], file: 'lib/utils.js' }, util => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems weird that this hook was removed but not replaced with anything. Do you know why it is no longer needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been following a pattern for these changes. Since we don't call channel.publish here, AFAIK we do not need this wrapper hook anymore since it only deals with binding the asyncresource to the callback. Going to refer to @rochdev since honestly im not sure why this was ever needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is technically still needed as it basically patches non-native promise implementations that can be used by mongodb. Since we're also instrumenting the library and not just a generic promise implementation it could be replaced with a channel, but I think it's safe to just leave it here as-is for now as it's not nesting async resources.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, ive reverted the change and kept the function here.

@BridgeAR
Copy link
Collaborator

@wconti27 there seem to still be a few related test failures :)

https://github.com/DataDog/dd-trace-js/actions/runs/16173889662/job/45654105379?pr=5812

@wconti27 wconti27 requested a review from rochdev July 15, 2025 00:19
BridgeAR
BridgeAR reviewed Jul 15, 2025
View reviewed changes
Copy link
Collaborator

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mongoose changes are difficult to review for me. Would you mind a review call?
The other parts are LGTM with my suggestion.

@BridgeAR BridgeAR marked this pull request as draft July 16, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlhunter tlhunter tlhunter left review comments

@BridgeAR BridgeAR BridgeAR left review comments

@rochdev rochdev Awaiting requested review from rochdev

At least 1 approving review is required to merge this pull request.

Assignees

@wconti27 wconti27

Labels
semver-patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wconti27 @BridgeAR @tlhunter @rochdev