Skip to content

event based tracing #2869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from
Draft

event based tracing #2869

wants to merge 19 commits into from

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Mar 3, 2023

What does this PR do?

WIP

Motivation

WIP

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Overall package size

Self size: 3.9 MB
Deduped: 61.07 MB
No deduping: 61.11 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.1.1 13.38 MB 13.39 MB
@datadog/native-appsec 2.0.0 12.33 MB 12.34 MB
@datadog/pprof 2.0.0 10.47 MB 11.35 MB
@datadog/native-metrics 1.5.0 7.1 MB 7.11 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
sbffi 1.0.4 3.12 MB 3.5 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
opentracing 0.14.7 194.81 kB 194.81 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
semver 5.7.1 61.58 kB 61.58 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.4 32.7 kB 37.17 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #2869 (3c89157) into master (26fda2b) will increase coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2869      +/-   ##
==========================================
+ Coverage   88.92%   89.11%   +0.18%     
==========================================
  Files         305      317      +12     
  Lines       10798    11306     +508     
  Branches       33       33              
==========================================
+ Hits         9602    10075     +473     
- Misses       1196     1231      +35     
Impacted Files Coverage Δ
packages/datadog-plugin-http/src/index.js 100.00% <0.00%> (ø)
packages/datadog-plugin-ioredis/src/index.js 100.00% <0.00%> (ø)
packages/datadog-plugin-http/src/client.js 97.00% <0.00%> (ø)
...ckages/datadog-instrumentations/src/http/client.js 94.73% <0.00%> (ø)
...s/datadog-instrumentations/src/cassandra-driver.js 89.28% <0.00%> (ø)
...kages/datadog-plugin-cassandra-driver/src/index.js 90.90% <0.00%> (ø)
packages/datadog-instrumentations/src/redis.js 91.30% <0.00%> (ø)
packages/datadog-instrumentations/src/ioredis.js 92.59% <0.00%> (ø)
packages/datadog-plugin-redis/src/index.js 92.30% <0.00%> (ø)
packages/datadog-instrumentations/src/http.js 100.00% <0.00%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tlhunter tlhunter force-pushed the event-based-tracing-koa branch from 5234a82 to bae6be5 Compare March 3, 2023 17:27
@pr-commenter
Copy link

pr-commenter bot commented Mar 3, 2023

Benchmarks

Comparing candidate commit 3c89157 in PR branch event-based-tracing-koa with baseline commit 26fda2b in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 669 metrics, 39 unstable metrics.

@rochdev rochdev force-pushed the event-based-tracing-koa branch from cd7c187 to 6cbc353 Compare March 3, 2023 18:19
@BridgeAR
Copy link
Collaborator

@rochdev is this still worked upon? It seems very old, so I guess it would make sense to close this?

@rochdev
Copy link
Member Author

rochdev commented Feb 19, 2025

is this still worked upon? It seems very old, so I guess it would make sense to close this?

@BridgeAR It is still being worked on. The main issue is that very little time is allocated to this project over time, and it's a very time-consuming project, which means work is not happening quickly and there are no guarantees it will never land, but it's definitely still a work in progress. Happy to chat offline about the project and get your thoughts on it as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants