Skip to content

Commit e8869a6

Browse files
committed
Validate semver ranges
1 parent cff1165 commit e8869a6

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

packages/dd-trace/test/setup/mocha.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,8 +200,13 @@ function withVersions (plugin, modules, range, cb) {
200200

201201
// TODO may run into issues with the latest version being greater than supported Node?
202202
if (latestVersion && !process.env.PACKAGE_VERSION_RANGE) {
203-
const testVersion = semver.lte(version, latestVersion) ? version : latestVersion
204-
testVersions.set(testVersion, { range: version, test: testVersion })
203+
if (semver.valid(version)) {
204+
const testVersion = semver.lte(version, latestVersion) ? version : latestVersion
205+
testVersions.set(testVersion, { range: version, test: testVersion })
206+
} else if (semver.validRange(version)) {
207+
const testVersion = semver.maxSatisfying([version, latestVersion], version)
208+
testVersions.set(testVersion, { range: version, test: testVersion })
209+
}
205210
} else if (latestVersion) {
206211
const range = process.env.PACKAGE_VERSION_RANGE
207212
const testVersion = semver.satisfies(latestVersion, range)

0 commit comments

Comments
 (0)