Skip to content

Commit cff1165

Browse files
committed
Attempt to fix issue installing latest always
1 parent 53272d5 commit cff1165

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

packages/dd-trace/test/setup/mocha.js

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -198,9 +198,18 @@ function withVersions (plugin, modules, range, cb) {
198198
testVersions.set(min, { range: version, test: min })
199199
}
200200

201-
// TODO may run into issues with the latest version being greater than supported Node
202-
if (latestVersion) {
203-
testVersions.set(latestVersion, { range: version, test: latestVersion })
201+
// TODO may run into issues with the latest version being greater than supported Node?
202+
if (latestVersion && !process.env.PACKAGE_VERSION_RANGE) {
203+
const testVersion = semver.lte(version, latestVersion) ? version : latestVersion
204+
testVersions.set(testVersion, { range: version, test: testVersion })
205+
} else if (latestVersion) {
206+
const range = process.env.PACKAGE_VERSION_RANGE
207+
const testVersion = semver.satisfies(latestVersion, range)
208+
? latestVersion
209+
: semver.maxSatisfying([version, latestVersion], range)
210+
if (testVersion) {
211+
testVersions.set(testVersion, { range: version, test: testVersion })
212+
}
204213
} else {
205214
const max = require(`../../../../versions/${moduleName}@${version}`).version()
206215
testVersions.set(max, { range: version, test: version })

0 commit comments

Comments
 (0)