Context API `beforeFinish` Migration #9422

zarirhamza · 2025-08-26T03:31:51Z

What Does This Do

Finishes context API migration in regards to beforeFinish using context instead of span
Refactors everything to use context instead of span across requests

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

* Creates inferred proxy spans for API Gateway calls via presence of http headers --------- Co-authored-by: Zarir Hamza <zarir.hamza@datadoghq.com>

Avoid duplicate expensive context extraction Avoid subclassing tracing span for serverless but used serverless context element instead to store / track inferred span while keep tracing feature untouched Improved propagator to not create / capture inferred span context element on invalid data Rework context element to hold the inferred spans and its captured data Release captured data as soon as they span start (never read after this point so reclaiming memory) Refactor context element and propagator into the right package, not context component (product / feature agnostic) Refactor unit tests

datadog-datadog-prod-us1 · 2025-08-26T03:54:20Z

🎯 Code Coverage
• Patch Coverage: 0.00%
• Total Coverage: 63.29% (+3.59%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 5f20aee | Docs | Was this helpful? Give us feedback!}

pr-commenter · 2025-08-26T04:07:00Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	zarir/context-api-finish
git_commit_date	1761332592	1761420293
git_commit_sha	`f69e043`	`5f20aee`
release_version	1.55.0-SNAPSHOT~f69e04325c	1.53.0-SNAPSHOT~5f20aeea23

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1761422086	1761422086
ci_job_id	1197858074	1197858074
ci_pipeline_id	80301618	80301618
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-pmi8iai9 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-pmi8iai9 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 14 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~5f20aeea23, baseline=1.55.0-SNAPSHOT~f69e04325c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1047936
Total [baseline] (8.783 s) : 0, 8782812
Agent [candidate] (1.04 s) : 0, 1039808
Total [candidate] (8.73 s) : 0, 8729891
section iast
Agent [baseline] (1.161 s) : 0, 1160591
Total [baseline] (9.364 s) : 0, 9363592
Agent [candidate] (1.16 s) : 0, 1159982
Total [candidate] (9.366 s) : 0, 9365876

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.048 s	-
Agent	iast	1.161 s	112.655 ms (10.8%)
Total	tracing	8.783 s	-
Total	iast	9.364 s	580.78 ms (6.6%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.04 s	-
Agent	iast	1.16 s	120.174 ms (11.6%)
Total	tracing	8.73 s	-
Total	iast	9.366 s	635.984 ms (7.3%)

gantt
    title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~5f20aeea23, baseline=1.55.0-SNAPSHOT~f69e04325c

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.494 ms) : 0, 1494
crashtracking [candidate] (1.491 ms) : 0, 1491
BytebuddyAgent [baseline] (713.669 ms) : 0, 713669
BytebuddyAgent [candidate] (709.239 ms) : 0, 709239
GlobalTracer [baseline] (249.588 ms) : 0, 249588
GlobalTracer [candidate] (246.886 ms) : 0, 246886
AppSec [baseline] (33.135 ms) : 0, 33135
AppSec [candidate] (32.6 ms) : 0, 32600
Debugger [baseline] (6.662 ms) : 0, 6662
Debugger [candidate] (6.492 ms) : 0, 6492
Remote Config [baseline] (696.27 µs) : 0, 696
Remote Config [candidate] (686.034 µs) : 0, 686
Telemetry [baseline] (14.686 ms) : 0, 14686
Telemetry [candidate] (13.962 ms) : 0, 13962
Flare Poller [baseline] (6.54 ms) : 0, 6540
Flare Poller [candidate] (7.1 ms) : 0, 7100
section iast
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (823.053 ms) : 0, 823053
BytebuddyAgent [candidate] (822.404 ms) : 0, 822404
GlobalTracer [baseline] (233.961 ms) : 0, 233961
GlobalTracer [candidate] (234.342 ms) : 0, 234342
AppSec [baseline] (30.677 ms) : 0, 30677
AppSec [candidate] (28.684 ms) : 0, 28684
Debugger [baseline] (6.085 ms) : 0, 6085
Debugger [candidate] (6.08 ms) : 0, 6080
Remote Config [baseline] (611.408 µs) : 0, 611
Remote Config [candidate] (598.001 µs) : 0, 598
Telemetry [baseline] (8.468 ms) : 0, 8468
Telemetry [candidate] (8.33 ms) : 0, 8330
Flare Poller [baseline] (4.13 ms) : 0, 4130
Flare Poller [candidate] (4.209 ms) : 0, 4209
IAST [baseline] (30.788 ms) : 0, 30788
IAST [candidate] (32.536 ms) : 0, 32536

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~5f20aeea23, baseline=1.55.0-SNAPSHOT~f69e04325c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1042732
Total [baseline] (10.85 s) : 0, 10850326
Agent [candidate] (1.031 s) : 0, 1030752
Total [candidate] (10.869 s) : 0, 10869416
section appsec
Agent [baseline] (1.203 s) : 0, 1202839
Total [baseline] (10.991 s) : 0, 10991193
Agent [candidate] (1.203 s) : 0, 1203155
Total [candidate] (10.907 s) : 0, 10907393
section iast
Agent [baseline] (1.169 s) : 0, 1169356
Total [baseline] (11.179 s) : 0, 11179053
Agent [candidate] (1.159 s) : 0, 1159386
Total [candidate] (11.117 s) : 0, 11116799
section profiling
Agent [baseline] (1.18 s) : 0, 1180423
Total [baseline] (10.931 s) : 0, 10931115
Agent [candidate] (1.178 s) : 0, 1178020
Total [candidate] (10.871 s) : 0, 10871356

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.043 s	-
Agent	appsec	1.203 s	160.107 ms (15.4%)
Agent	iast	1.169 s	126.624 ms (12.1%)
Agent	profiling	1.18 s	137.691 ms (13.2%)
Total	tracing	10.85 s	-
Total	appsec	10.991 s	140.867 ms (1.3%)
Total	iast	11.179 s	328.727 ms (3.0%)
Total	profiling	10.931 s	80.789 ms (0.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.031 s	-
Agent	appsec	1.203 s	172.403 ms (16.7%)
Agent	iast	1.159 s	128.633 ms (12.5%)
Agent	profiling	1.178 s	147.268 ms (14.3%)
Total	tracing	10.869 s	-
Total	appsec	10.907 s	37.977 ms (0.3%)
Total	iast	11.117 s	247.383 ms (2.3%)
Total	profiling	10.871 s	1.94 ms (0.0%)

gantt
    title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~5f20aeea23, baseline=1.55.0-SNAPSHOT~f69e04325c

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.484 ms) : 0, 1484
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (710.907 ms) : 0, 710907
BytebuddyAgent [candidate] (702.747 ms) : 0, 702747
GlobalTracer [baseline] (247.538 ms) : 0, 247538
GlobalTracer [candidate] (245.391 ms) : 0, 245391
AppSec [baseline] (32.82 ms) : 0, 32820
AppSec [candidate] (32.126 ms) : 0, 32126
Debugger [baseline] (6.531 ms) : 0, 6531
Debugger [candidate] (6.36 ms) : 0, 6360
Remote Config [baseline] (694.812 µs) : 0, 695
Remote Config [candidate] (684.084 µs) : 0, 684
Telemetry [baseline] (14.671 ms) : 0, 14671
Telemetry [candidate] (14.552 ms) : 0, 14552
Flare Poller [baseline] (6.632 ms) : 0, 6632
Flare Poller [candidate] (6.321 ms) : 0, 6321
section appsec
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (725.879 ms) : 0, 725879
BytebuddyAgent [candidate] (726.928 ms) : 0, 726928
GlobalTracer [baseline] (236.4 ms) : 0, 236400
GlobalTracer [candidate] (236.069 ms) : 0, 236069
AppSec [baseline] (174.193 ms) : 0, 174193
AppSec [candidate] (173.826 ms) : 0, 173826
Debugger [baseline] (5.864 ms) : 0, 5864
Debugger [candidate] (5.873 ms) : 0, 5873
Remote Config [baseline] (629.615 µs) : 0, 630
Remote Config [candidate] (648.271 µs) : 0, 648
Telemetry [baseline] (8.374 ms) : 0, 8374
Telemetry [candidate] (8.363 ms) : 0, 8363
Flare Poller [baseline] (3.853 ms) : 0, 3853
Flare Poller [candidate] (3.845 ms) : 0, 3845
IAST [baseline] (25.081 ms) : 0, 25081
IAST [candidate] (25.037 ms) : 0, 25037
section iast
crashtracking [baseline] (1.486 ms) : 0, 1486
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (830.186 ms) : 0, 830186
BytebuddyAgent [candidate] (822.816 ms) : 0, 822816
GlobalTracer [baseline] (234.768 ms) : 0, 234768
GlobalTracer [candidate] (233.369 ms) : 0, 233369
AppSec [baseline] (30.105 ms) : 0, 30105
AppSec [candidate] (29.592 ms) : 0, 29592
Debugger [baseline] (6.162 ms) : 0, 6162
Debugger [candidate] (6.127 ms) : 0, 6127
Remote Config [baseline] (599.639 µs) : 0, 600
Remote Config [candidate] (593.44 µs) : 0, 593
Telemetry [baseline] (8.46 ms) : 0, 8460
Telemetry [candidate] (8.443 ms) : 0, 8443
Flare Poller [baseline] (4.161 ms) : 0, 4161
Flare Poller [candidate] (4.122 ms) : 0, 4122
IAST [baseline] (31.836 ms) : 0, 31836
IAST [candidate] (31.539 ms) : 0, 31539
section profiling
ProfilingAgent [baseline] (110.095 ms) : 0, 110095
ProfilingAgent [candidate] (110.2 ms) : 0, 110200
crashtracking [baseline] (1.483 ms) : 0, 1483
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (731.138 ms) : 0, 731138
BytebuddyAgent [candidate] (729.662 ms) : 0, 729662
GlobalTracer [baseline] (221.725 ms) : 0, 221725
GlobalTracer [candidate] (220.755 ms) : 0, 220755
AppSec [baseline] (33.227 ms) : 0, 33227
AppSec [candidate] (33.308 ms) : 0, 33308
Debugger [baseline] (9.185 ms) : 0, 9185
Debugger [candidate] (9.861 ms) : 0, 9861
Remote Config [baseline] (717.634 µs) : 0, 718
Remote Config [candidate] (2.191 ms) : 0, 2191
Telemetry [baseline] (12.984 ms) : 0, 12984
Telemetry [candidate] (10.742 ms) : 0, 10742
Flare Poller [baseline] (4.18 ms) : 0, 4180
Flare Poller [candidate] (4.155 ms) : 0, 4155
Profiling [baseline] (110.751 ms) : 0, 110751
Profiling [candidate] (110.858 ms) : 0, 110858

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	zarir/context-api-finish
git_commit_date	1761332592	1761420293
git_commit_sha	`f69e043`	`5f20aee`
release_version	1.55.0-SNAPSHOT~f69e04325c	1.53.0-SNAPSHOT~5f20aeea23

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1761421669	1761421669
ci_job_id	1197858075	1197858075
ci_pipeline_id	80301618	80301618
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-v2bdg0a1 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-v2bdg0a1 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 1 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:iast_GLOBAL:high_load	better [-656.581µs; -228.119µs] or [-5.967%; -2.073%]	unstable [-32.763op/s; +67.638op/s] or [-7.752%; +16.004%]	10.561ms	440.062op/s	11.004ms	422.625op/s
scenario:load:insecure-bank:iast:high_load	better [-614.945µs; -268.607µs] or [-6.278%; -2.742%]	unstable [-34.885op/s; +78.947op/s] or [-7.357%; +16.649%]	9.354ms	496.219op/s	9.796ms	474.188op/s
scenario:load:petclinic:code_origins:high_load	worse [+2.242ms; +3.087ms] or [+5.165%; +7.113%]	unstable [-13.697op/s; +1.197op/s] or [-12.701%; +1.110%]	46.065ms	101.588op/s	43.400ms	107.838op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~5f20aeea23, baseline=1.55.0-SNAPSHOT~f69e04325c
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.398 ms) : 4348, 4447
.   : milestone, 4398,
iast (9.796 ms) : 9631, 9960
.   : milestone, 9796,
iast_FULL (13.863 ms) : 13591, 14135
.   : milestone, 13863,
iast_GLOBAL (11.004 ms) : 10793, 11214
.   : milestone, 11004,
profiling (8.873 ms) : 8727, 9020
.   : milestone, 8873,
tracing (7.786 ms) : 7675, 7897
.   : milestone, 7786,
section candidate
no_agent (4.256 ms) : 4201, 4310
.   : milestone, 4256,
iast (9.354 ms) : 9197, 9511
.   : milestone, 9354,
iast_FULL (14.313 ms) : 14026, 14599
.   : milestone, 14313,
iast_GLOBAL (10.561 ms) : 10374, 10748
.   : milestone, 10561,
profiling (8.839 ms) : 8690, 8989
.   : milestone, 8839,
tracing (7.7 ms) : 7588, 7813
.   : milestone, 7700,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.398 ms [4.348 ms, 4.447 ms]	-
iast	9.796 ms [9.631 ms, 9.96 ms]	5.398 ms (122.7%)
iast_FULL	13.863 ms [13.591 ms, 14.135 ms]	9.466 ms (215.2%)
iast_GLOBAL	11.004 ms [10.793 ms, 11.214 ms]	6.606 ms (150.2%)
profiling	8.873 ms [8.727 ms, 9.02 ms]	4.476 ms (101.8%)
tracing	7.786 ms [7.675 ms, 7.897 ms]	3.388 ms (77.0%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.256 ms [4.201 ms, 4.31 ms]	-
iast	9.354 ms [9.197 ms, 9.511 ms]	5.098 ms (119.8%)
iast_FULL	14.313 ms [14.026 ms, 14.599 ms]	10.057 ms (236.3%)
iast_GLOBAL	10.561 ms [10.374 ms, 10.748 ms]	6.306 ms (148.2%)
profiling	8.839 ms [8.69 ms, 8.989 ms]	4.584 ms (107.7%)
tracing	7.7 ms [7.588 ms, 7.813 ms]	3.445 ms (80.9%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~5f20aeea23, baseline=1.55.0-SNAPSHOT~f69e04325c
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.456 ms) : 37145, 37767
.   : milestone, 37456,
appsec (47.461 ms) : 47046, 47875
.   : milestone, 47461,
code_origins (43.4 ms) : 43022, 43778
.   : milestone, 43400,
iast (45.229 ms) : 44833, 45625
.   : milestone, 45229,
profiling (49.802 ms) : 49324, 50279
.   : milestone, 49802,
tracing (43.535 ms) : 43151, 43918
.   : milestone, 43535,
section candidate
no_agent (37.748 ms) : 37453, 38043
.   : milestone, 37748,
appsec (47.154 ms) : 46734, 47574
.   : milestone, 47154,
code_origins (46.065 ms) : 45658, 46472
.   : milestone, 46065,
iast (44.541 ms) : 44150, 44932
.   : milestone, 44541,
profiling (49.861 ms) : 49403, 50320
.   : milestone, 49861,
tracing (42.935 ms) : 42567, 43302
.   : milestone, 42935,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.456 ms [37.145 ms, 37.767 ms]	-
appsec	47.461 ms [47.046 ms, 47.875 ms]	10.005 ms (26.7%)
code_origins	43.4 ms [43.022 ms, 43.778 ms]	5.944 ms (15.9%)
iast	45.229 ms [44.833 ms, 45.625 ms]	7.773 ms (20.8%)
profiling	49.802 ms [49.324 ms, 50.279 ms]	12.346 ms (33.0%)
tracing	43.535 ms [43.151 ms, 43.918 ms]	6.079 ms (16.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.748 ms [37.453 ms, 38.043 ms]	-
appsec	47.154 ms [46.734 ms, 47.574 ms]	9.406 ms (24.9%)
code_origins	46.065 ms [45.658 ms, 46.472 ms]	8.316 ms (22.0%)
iast	44.541 ms [44.15 ms, 44.932 ms]	6.793 ms (18.0%)
profiling	49.861 ms [49.403 ms, 50.32 ms]	12.113 ms (32.1%)
tracing	42.935 ms [42.567 ms, 43.302 ms]	5.186 ms (13.7%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	zarir/context-api-finish
git_commit_date	1761332592	1761420293
git_commit_sha	`f69e043`	`5f20aee`
release_version	1.55.0-SNAPSHOT~f69e04325c	1.53.0-SNAPSHOT~5f20aeea23

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1761422272	1761422272
ci_job_id	1197858076	1197858076
ci_pipeline_id	80301618	80301618
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-j6ufoi1j 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-j6ufoi1j 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~5f20aeea23, baseline=1.55.0-SNAPSHOT~f69e04325c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
.   : milestone, 1475,
appsec (3.726 ms) : 3506, 3946
.   : milestone, 3726,
iast (2.213 ms) : 2149, 2278
.   : milestone, 2213,
iast_GLOBAL (2.26 ms) : 2196, 2325
.   : milestone, 2260,
profiling (2.082 ms) : 2028, 2136
.   : milestone, 2082,
tracing (2.037 ms) : 1987, 2087
.   : milestone, 2037,
section candidate
no_agent (1.48 ms) : 1468, 1491
.   : milestone, 1480,
appsec (3.709 ms) : 3490, 3927
.   : milestone, 3709,
iast (2.212 ms) : 2148, 2276
.   : milestone, 2212,
iast_GLOBAL (2.255 ms) : 2191, 2319
.   : milestone, 2255,
profiling (2.505 ms) : 2333, 2677
.   : milestone, 2505,
tracing (2.039 ms) : 1989, 2089
.   : milestone, 2039,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.475 ms [1.463 ms, 1.486 ms]	-
appsec	3.726 ms [3.506 ms, 3.946 ms]	2.251 ms (152.6%)
iast	2.213 ms [2.149 ms, 2.278 ms]	738.669 µs (50.1%)
iast_GLOBAL	2.26 ms [2.196 ms, 2.325 ms]	785.575 µs (53.3%)
profiling	2.082 ms [2.028 ms, 2.136 ms]	607.191 µs (41.2%)
tracing	2.037 ms [1.987 ms, 2.087 ms]	561.843 µs (38.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.48 ms [1.468 ms, 1.491 ms]	-
appsec	3.709 ms [3.49 ms, 3.927 ms]	2.229 ms (150.6%)
iast	2.212 ms [2.148 ms, 2.276 ms]	732.339 µs (49.5%)
iast_GLOBAL	2.255 ms [2.191 ms, 2.319 ms]	775.183 µs (52.4%)
profiling	2.505 ms [2.333 ms, 2.677 ms]	1.025 ms (69.3%)
tracing	2.039 ms [1.989 ms, 2.089 ms]	559.138 µs (37.8%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~5f20aeea23, baseline=1.55.0-SNAPSHOT~f69e04325c
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.555 s) : 15555000, 15555000
.   : milestone, 15555000,
appsec (15.086 s) : 15086000, 15086000
.   : milestone, 15086000,
iast (18.333 s) : 18333000, 18333000
.   : milestone, 18333000,
iast_GLOBAL (17.941 s) : 17941000, 17941000
.   : milestone, 17941000,
profiling (15.465 s) : 15465000, 15465000
.   : milestone, 15465000,
tracing (15.139 s) : 15139000, 15139000
.   : milestone, 15139000,
section candidate
no_agent (15.288 s) : 15288000, 15288000
.   : milestone, 15288000,
appsec (14.767 s) : 14767000, 14767000
.   : milestone, 14767000,
iast (18.792 s) : 18792000, 18792000
.   : milestone, 18792000,
iast_GLOBAL (18.029 s) : 18029000, 18029000
.   : milestone, 18029000,
profiling (15.297 s) : 15297000, 15297000
.   : milestone, 15297000,
tracing (15.206 s) : 15206000, 15206000
.   : milestone, 15206000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.555 s [15.555 s, 15.555 s]	-
appsec	15.086 s [15.086 s, 15.086 s]	-469.0 ms (-3.0%)
iast	18.333 s [18.333 s, 18.333 s]	2.778 s (17.9%)
iast_GLOBAL	17.941 s [17.941 s, 17.941 s]	2.386 s (15.3%)
profiling	15.465 s [15.465 s, 15.465 s]	-90.0 ms (-0.6%)
tracing	15.139 s [15.139 s, 15.139 s]	-416.0 ms (-2.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.288 s [15.288 s, 15.288 s]	-
appsec	14.767 s [14.767 s, 14.767 s]	-521.0 ms (-3.4%)
iast	18.792 s [18.792 s, 18.792 s]	3.504 s (22.9%)
iast_GLOBAL	18.029 s [18.029 s, 18.029 s]	2.741 s (17.9%)
profiling	15.297 s [15.297 s, 15.297 s]	9.0 ms (0.1%)
tracing	15.206 s [15.206 s, 15.206 s]	-82.0 ms (-0.5%)

PerfectSlayer

I only had a quick review so far but it looks promising 👍

We need to #9384 review an merged to prevent conflicts. Can you target this branch instead?

Can you also remove what's already part of #9388? It will get better to review if we keep this PR related to the beforeFinish only. I will target mine onto yours then.

PerfectSlayer · 2025-08-27T05:54:03Z

...bootstrap/src/main/java/datadog/trace/bootstrap/instrumentation/decorator/BaseDecorator.java

  public AgentSpan beforeFinish(final AgentSpan span) {
    return span;
  }


❔ question: ‏Can this one be removed then? It will prevent other decorator to override it and never being called.

Cannot, WebSocketDecorator and its related instrumentation still call it. Needs to be a separate mini-migration

Is that the only one blocker? Because the WebSocketDecorator is calling the empty BaseDecorator.beforeFinish() and has no override... So technically, the call is doing nothing :/
So we can move it from BaseDecorator to WebSocketDecorator and migrate it in a second pass.

@amarziali What's the effort to migrate the WebSocket instrumentation to context rather than span?

Another place where this is called is within the Mule Instrumentation as well via the MuleDecorator in mule-4.

Moved the empty call to WebSocketDecorator and MuleDecorator thus allowing me to remove the function from BaseDecorator.

I assume the actual span -> context functionality will be taken care of later for both WebSockets and Mule.

I take it back, I'm not sure how the tests aren't catching it but the ClientDecorator also uses beforeFinish(span) via the BaseDecorator. This seems to indicate that we need to invest time into looking through all decorators and confirming their reliance on beforeFinish. To save time, for now we can focus just on HttpServerDecorator related instrumentation

...kka-http-10.0/src/main/java/datadog/trace/instrumentation/akkahttp/DatadogWrapperHelper.java

...0/src/main/java/datadog/trace/instrumentation/grizzly/GrizzlyHttpHandlerInstrumentation.java

...http-2.3.20/src/main/java/datadog/trace/instrumentation/grizzlyhttp232/GrizzlyDecorator.java

...dertow-2.0/src/main/java/datadog/trace/instrumentation/undertow/ExchangeEndSpanListener.java

...bootstrap/src/main/java/datadog/trace/bootstrap/instrumentation/decorator/BaseDecorator.java

PerfectSlayer · 2025-08-28T06:09:35Z

...bootstrap/src/main/java/datadog/trace/bootstrap/instrumentation/decorator/BaseDecorator.java

  public AgentSpan beforeFinish(final AgentSpan span) {
    return span;
  }


Is that the only one blocker? Because the WebSocketDecorator is calling the empty BaseDecorator.beforeFinish() and has no override... So technically, the call is doing nothing :/
So we can move it from BaseDecorator to WebSocketDecorator and migrate it in a second pass.

@amarziali What's the effort to migrate the WebSocket instrumentation to context rather than span?

...entation/cxf-2.1/src/main/java/datadog/trace/instrumentation/cxf/InvokerInstrumentation.java

...ain/java/datadog/trace/instrumentation/grizzlyhttp232/DefaultFilterChainInstrumentation.java

...zly-http-2.3.20/src/main/java/datadog/trace/instrumentation/grizzlyhttp232/FilterAdvice.java

...http-2.3.20/src/main/java/datadog/trace/instrumentation/grizzlyhttp232/GrizzlyDecorator.java

...t-1.1/src/main/java/datadog/trace/instrumentation/jaxrs/v1/JaxRsClientV1Instrumentation.java

PerfectSlayer · 2025-08-28T06:35:11Z

...ver-7.0/src/main/java/datadog/trace/instrumentation/jetty70/ServerHandleInstrumentation.java

@@ -53,42 +55,58 @@ public void methodAdvice(MethodTransformer transformer) {

  static class HandleAdvice {
    @Advice.OnMethodEnter(suppress = Throwable.class)
-    static AgentScope onEnter(
+    static ContextScope onEnter(


📝 notes: Note for myself. Time boxed the review to 1h and paused here for Today

PerfectSlayer

I miss baggage about Jetty instrumentation but mixing main context and dispatch span feels different than the original behavior. Did I miss something?

...ver-7.0/src/main/java/datadog/trace/instrumentation/jetty70/ServerHandleInstrumentation.java

...0/src/main/java/datadog/trace/instrumentation/jetty9/JettyCommitResponseInstrumentation.java

...rver-9.0/src/main/java/datadog/trace/instrumentation/jetty9/ServerHandleInstrumentation.java

...0/src/main/java_jetty10/datadog/trace/instrumentation/jetty10/JettyCommitResponseHelper.java

...rver-9.0/src/main/java_jetty10/datadog/trace/instrumentation/jetty10/ServerHandleAdvice.java

...src/main/java_jetty904/datadog/trace/instrumentation/jetty904/JettyCommitResponseHelper.java

...0/src/main/java_jetty93/datadog/trace/instrumentation/jetty93/JettyCommitResponseHelper.java

...c/main/java_jetty9421/datadog/trace/instrumentation/jetty9421/JettyCommitResponseHelper.java

zarirhamza · 2025-10-05T20:47:23Z

System Tests are fixed here - DataDog/system-tests#5430

mhlidd

👋 I didn't get the chance to fully review all files but I do have a concern.

Whenever scope.context() is called, we may need to make sure that the scope used is a ContextScope. If it is invoked on an AgentScope (like it is in many files now), we will get an AgentSpan back, which will lead to the wrong implementation of beforeFinish being called and the InferredProxySpan not actually getting finished.

Curious to what @PerfectSlayer and @mcculls think about this.

...tp-10.0/src/main/java/datadog/trace/instrumentation/akkahttp/DatadogAsyncHandlerWrapper.java

...instrumentation/axway-api/src/main/java/datadog/trace/instrumentation/axway/StateAdvice.java

...umentation/axway-api/src/main/java/datadog/trace/instrumentation/axway/HTTPPluginAdvice.java

mhlidd · 2025-10-07T16:15:31Z

.../finatra-2.9/src/main/java/datadog/trace/instrumentation/finatra/FinatraInstrumentation.java

      if (throwable != null) {
        DECORATE.onError(span, throwable);
-        DECORATE.beforeFinish(span);
+        DECORATE.beforeFinish(scope.context());


Same thing here, may need to migrate to ContextScope.

...zly-http-2.3.20/src/main/java/datadog/trace/instrumentation/grizzlyhttp232/FilterAdvice.java

....0/src/main/java/datadog/trace/instrumentation/netty40/server/MaybeBlockResponseHandler.java

...main/java/datadog/trace/instrumentation/netty40/server/HttpServerResponseTracingHandler.java

...in/java/datadog/trace/instrumentation/netty40/NettyChannelHandlerContextInstrumentation.java

.../main/java/datadog/trace/instrumentation/netty41/client/HttpClientRequestTracingHandler.java

jordan-wong and others added 3 commits August 21, 2025 09:43

Implement APIGW Inferred Proxy Spans (#8336)

796b57e

* Creates inferred proxy spans for API Gateway calls via presence of http headers --------- Co-authored-by: Zarir Hamza <zarir.hamza@datadoghq.com>

init commit of instrumentations

737e783

zarirhamza added inst: others All other instrumentations type: refactoring tag: serverless Serverless support and removed tag: serverless Serverless support labels Aug 26, 2025

zarirhamza added 8 commits August 26, 2025 12:10

fix tests

c9a2e21

round 2 of context migration

a0ecac7

netty changes

2ef3dc7

tomcat changes

a14848f

liberty changes

112ec20

store span

909d174

jetty

c883e8d

grizzly

b847401

zarirhamza added the tag: serverless Serverless support label Aug 26, 2025

Merge branch 'master' into zarir/context-api-finish

bebe637

zarirhamza marked this pull request as ready for review August 26, 2025 21:47

zarirhamza requested review from a team as code owners August 26, 2025 21:47

zarirhamza requested review from PerfectSlayer, dougqh, robertpi and sezen-datadog and removed request for a team August 26, 2025 21:47

PerfectSlayer reviewed Aug 27, 2025

View reviewed changes

Merge branch 'master' into zarir/context-api-finish

8f4a6ee

zarirhamza changed the base branch from master to bbujon/gateway-inferred-span2 August 27, 2025 15:14

zarirhamza requested a review from a team as a code owner August 27, 2025 15:14

zarirhamza requested a review from Mariovido August 27, 2025 15:14

zarirhamza changed the base branch from bbujon/gateway-inferred-span2 to master August 27, 2025 15:18

zarirhamza added 3 commits August 27, 2025 11:33

remove serverless

762c233

fixes part 1

c8c9ece

fix undertow tests

f715d62

zarirhamza removed the tag: serverless Serverless support label Aug 27, 2025

zarirhamza added 3 commits August 27, 2025 16:45

remove span within request

7fe9c70

fix tests

0f0f228

fix tests

ecc5049

PerfectSlayer reviewed Aug 28, 2025

View reviewed changes

zarirhamza added 2 commits August 28, 2025 14:17

implement fixes part 1

4bd005d

fix tests

9b4d887

PerfectSlayer mentioned this pull request Aug 29, 2025

Refactor Severless Gateway Inferred Span #9388

Merged

Mariovido requested review from daniel-mohedano and removed request for Mariovido September 15, 2025 12:02

PerfectSlayer reviewed Sep 22, 2025

View reviewed changes

zarirhamza added 3 commits October 2, 2025 11:03

merge main fixing merge conflicts

a3bb790

address jetty comments

ee71b23

Merge branch 'master' into zarir/context-api-finish

dd4c4c0

zarirhamza mentioned this pull request Oct 5, 2025

Java Exception Debugging Snapshot Update DataDog/system-tests#5430

Draft

6 tasks

mhlidd reviewed Oct 7, 2025

View reviewed changes

zarirhamza added 4 commits October 8, 2025 11:00

Merge branch 'master' into zarir/context-api-finish

7fd52d8

use context scope

2c27431

fix netty tests

6e950a0

Merge branch 'master' into zarir/context-api-finish

5f20aee

Context API beforeFinish Migration #9422

Are you sure you want to change the base?

Context API beforeFinish Migration #9422

Uh oh!

Conversation

zarirhamza commented Aug 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

datadog-datadog-prod-us1 bot commented Aug 26, 2025 • edited by datadog-official bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Aug 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zarirhamza commented Oct 5, 2025

Uh oh!

mhlidd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Context API `beforeFinish` Migration #9422

Context API `beforeFinish` Migration #9422

zarirhamza commented Aug 26, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Aug 26, 2025 •

edited by datadog-official bot

Loading

pr-commenter bot commented Aug 26, 2025 •

edited

Loading