- 
                Notifications
    You must be signed in to change notification settings 
- Fork 150
process tags for profiler #7715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Draft
      
      
            vandonr
  wants to merge
  1
  commit into
  master
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
vandonr/process2
  
      
      
   
  
    
  
  
  
 
  
      
    base: master
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Draft
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | BenchmarksBenchmarks Report for benchmark platform 🐌Benchmarks for #7715 compared to master: 
 The following thresholds were used for comparing the benchmark speeds: 
 Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
 Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ More allocations  | 
| Benchmark | Base Allocated | Diff Allocated | Change | Change % | 
|---|---|---|---|---|
| Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 | 3.31 KB | 3.35 KB | 46 B | 1.39% | 
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | 
|---|---|---|---|---|---|---|---|---|---|
| master | WriteAndFlushEnrichedTraces | net6.0 | 931μs | 196ns | 758ns | 0 | 0 | 0 | 2.71 KB | 
| master | WriteAndFlushEnrichedTraces | netcoreapp3.1 | 1.02ms | 198ns | 768ns | 0 | 0 | 0 | 2.7 KB | 
| master | WriteAndFlushEnrichedTraces | net472 | 1.18ms | 90.8ns | 340ns | 0 | 0 | 0 | 3.31 KB | 
| #7715 | WriteAndFlushEnrichedTraces | net6.0 | 934μs | 40.2ns | 145ns | 0 | 0 | 0 | 2.71 KB | 
| #7715 | WriteAndFlushEnrichedTraces | netcoreapp3.1 | 1.01ms | 205ns | 792ns | 0 | 0 | 0 | 2.7 KB | 
| #7715 | WriteAndFlushEnrichedTraces | net472 | 1.2ms | 58ns | 217ns | 0 | 0 | 0 | 3.35 KB | 
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Unknown 🤷 Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | 
|---|---|---|---|---|---|---|---|---|---|
| master | AllCycleSimpleBody | net6.0 | N/A | N/A | N/A | NaN | NaN | NaN | 0 b | 
| master | AllCycleSimpleBody | netcoreapp3.1 | N/A | N/A | N/A | NaN | NaN | NaN | 0 b | 
| master | AllCycleSimpleBody | net472 | N/A | N/A | N/A | NaN | NaN | NaN | 0 b | 
| master | AllCycleMoreComplexBody | net6.0 | N/A | N/A | N/A | NaN | NaN | NaN | 0 b | 
| master | AllCycleMoreComplexBody | netcoreapp3.1 | N/A | N/A | N/A | NaN | NaN | NaN | 0 b | 
| master | AllCycleMoreComplexBody | net472 | N/A | N/A | N/A | NaN | NaN | NaN | 0 b | 
| master | ObjectExtractorSimpleBody | net6.0 | 323ns | 1.59ns | 6.54ns | 0 | 0 | 0 | 280 B | 
| master | ObjectExtractorSimpleBody | netcoreapp3.1 | 393ns | 2.2ns | 13.4ns | 0 | 0 | 0 | 272 B | 
| master | ObjectExtractorSimpleBody | net472 | 299ns | 0.0277ns | 0.107ns | 0.0446 | 0 | 0 | 281 B | 
| master | ObjectExtractorMoreComplexBody | net6.0 | 6.25μs | 32ns | 150ns | 0 | 0 | 0 | 3.78 KB | 
| master | ObjectExtractorMoreComplexBody | netcoreapp3.1 | 7.77μs | 37ns | 143ns | 0 | 0 | 0 | 3.69 KB | 
| master | ObjectExtractorMoreComplexBody | net472 | 6.69μs | 0.952ns | 3.43ns | 0.601 | 0 | 0 | 3.8 KB | 
| #7715 | AllCycleSimpleBody | net6.0 | N/A | N/A | N/A | NaN | NaN | NaN | 0 b | 
| #7715 | AllCycleSimpleBody | netcoreapp3.1 | N/A | N/A | N/A | NaN | NaN | NaN | 0 b | 
| #7715 | AllCycleSimpleBody | net472 | N/A | N/A | N/A | NaN | NaN | NaN | 0 b | 
| #7715 | AllCycleMoreComplexBody | net6.0 | N/A | N/A | N/A | NaN | NaN | NaN | 0 b | 
| #7715 | AllCycleMoreComplexBody | netcoreapp3.1 | N/A | N/A | N/A | NaN | NaN | NaN | 0 b | 
| #7715 | AllCycleMoreComplexBody | net472 | N/A | N/A | N/A | NaN | NaN | NaN | 0 b | 
| #7715 | ObjectExtractorSimpleBody | net6.0 | 320ns | 1.6ns | 6.96ns | 0 | 0 | 0 | 280 B | 
| #7715 | ObjectExtractorSimpleBody | netcoreapp3.1 | 396ns | 2.13ns | 10.9ns | 0 | 0 | 0 | 272 B | 
| #7715 | ObjectExtractorSimpleBody | net472 | 303ns | 0.0207ns | 0.0774ns | 0.0439 | 0 | 0 | 281 B | 
| #7715 | ObjectExtractorMoreComplexBody | net6.0 | 6.34μs | 22.9ns | 88.6ns | 0 | 0 | 0 | 3.78 KB | 
| #7715 | ObjectExtractorMoreComplexBody | netcoreapp3.1 | 7.93μs | 28.8ns | 111ns | 0 | 0 | 0 | 3.69 KB | 
| #7715 | ObjectExtractorMoreComplexBody | net472 | 6.65μs | 2.76ns | 10.7ns | 0.597 | 0 | 0 | 3.8 KB | 
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | 
|---|---|---|---|---|---|---|---|---|---|
| master | EncodeArgs | net6.0 | 75.8μs | 218ns | 817ns | 0 | 0 | 0 | 32.4 KB | 
| master | EncodeArgs | netcoreapp3.1 | 98.5μs | 309ns | 1.2μs | 0 | 0 | 0 | 32.4 KB | 
| master | EncodeArgs | net472 | 111μs | 10.2ns | 39.4ns | 5.02 | 0 | 0 | 32.5 KB | 
| master | EncodeLegacyArgs | net6.0 | 145μs | 31.9ns | 111ns | 0 | 0 | 0 | 2.15 KB | 
| master | EncodeLegacyArgs | netcoreapp3.1 | 196μs | 193ns | 721ns | 0 | 0 | 0 | 2.14 KB | 
| master | EncodeLegacyArgs | net472 | 264μs | 44.3ns | 172ns | 0 | 0 | 0 | 2.17 KB | 
| #7715 | EncodeArgs | net6.0 | 76.6μs | 267ns | 1.04μs | 0 | 0 | 0 | 32.4 KB | 
| #7715 | EncodeArgs | netcoreapp3.1 | 96.9μs | 252ns | 910ns | 0 | 0 | 0 | 32.4 KB | 
| #7715 | EncodeArgs | net472 | 110μs | 29.2ns | 113ns | 4.94 | 0 | 0 | 32.5 KB | 
| #7715 | EncodeLegacyArgs | net6.0 | 145μs | 263ns | 1.02μs | 0 | 0 | 0 | 2.15 KB | 
| #7715 | EncodeLegacyArgs | netcoreapp3.1 | 199μs | 34.1ns | 128ns | 0 | 0 | 0 | 2.15 KB | 
| #7715 | EncodeLegacyArgs | net472 | 264μs | 33.2ns | 128ns | 0 | 0 | 0 | 2.16 KB | 
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | 
|---|---|---|---|---|---|---|---|---|---|
| master | RunWafRealisticBenchmark | net6.0 | 391μs | 51.2ns | 198ns | 0 | 0 | 0 | 4.55 KB | 
| master | RunWafRealisticBenchmark | netcoreapp3.1 | 802μs | 13.8μs | 136μs | 0 | 0 | 0 | 4.48 KB | 
| master | RunWafRealisticBenchmark | net472 | 426μs | 71.1ns | 275ns | 0 | 0 | 0 | 4.66 KB | 
| master | RunWafRealisticBenchmarkWithAttack | net6.0 | 286μs | 54ns | 209ns | 0 | 0 | 0 | 2.24 KB | 
| master | RunWafRealisticBenchmarkWithAttack | netcoreapp3.1 | 669μs | 13.2μs | 132μs | 0 | 0 | 0 | 2.22 KB | 
| master | RunWafRealisticBenchmarkWithAttack | net472 | 311μs | 21.1ns | 73.2ns | 0 | 0 | 0 | 2.29 KB | 
| #7715 | RunWafRealisticBenchmark | net6.0 | 393μs | 49.4ns | 185ns | 0 | 0 | 0 | 4.56 KB | 
| #7715 | RunWafRealisticBenchmark | netcoreapp3.1 | 852μs | 6.34μs | 57.1μs | 0 | 0 | 0 | 4.48 KB | 
| #7715 | RunWafRealisticBenchmark | net472 | 427μs | 73.5ns | 275ns | 0 | 0 | 0 | 4.66 KB | 
| #7715 | RunWafRealisticBenchmarkWithAttack | net6.0 | 284μs | 21ns | 78.6ns | 0 | 0 | 0 | 2.24 KB | 
| #7715 | RunWafRealisticBenchmarkWithAttack | netcoreapp3.1 | 679μs | 12.9μs | 124μs | 0 | 0 | 0 | 2.22 KB | 
| #7715 | RunWafRealisticBenchmarkWithAttack | net472 | 308μs | 34.6ns | 134ns | 0 | 0 | 0 | 2.29 KB | 
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | 
|---|---|---|---|---|---|---|---|---|---|
| master | SendRequest | net6.0 | 60.5μs | 58.3ns | 202ns | 0 | 0 | 0 | 14.52 KB | 
| master | SendRequest | netcoreapp3.1 | 71.8μs | 99.4ns | 372ns | 0 | 0 | 0 | 17.42 KB | 
| master | SendRequest | net472 | 0.00126ns | 0.000703ns | 0.00263ns | 0 | 0 | 0 | 0 b | 
| #7715 | SendRequest | net6.0 | 61.4μs | 52.2ns | 195ns | 0 | 0 | 0 | 14.52 KB | 
| #7715 | SendRequest | netcoreapp3.1 | 71.7μs | 397ns | 2.35μs | 0 | 0 | 0 | 17.42 KB | 
| #7715 | SendRequest | net472 | 0.00391ns | 0.00204ns | 0.00789ns | 0 | 0 | 0 | 0 b | 
Benchmarks.Trace.CharSliceBenchmark - Slower ⚠️  More allocations ⚠️ 
Slower ⚠️  in #7715
Benchmark 
diff/base 
Base Median (ns) 
Diff Median (ns) 
Modality 
 
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 
1.194 
808,619.71 
965,716.88 
 
More allocations ⚠️  in #7715
Benchmark 
Base Allocated 
Diff Allocated 
Change 
Change % 
 
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑netcoreapp3.1 
1 B 
60 B 
59 B 
5,900.00% 
 
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 
3 B 
4 B 
1 B 
33.33% 
 
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0 
6 B 
7 B 
1 B 
16.67% 
 
Fewer allocations 🎉 in #7715
Benchmark 
Base Allocated 
Diff Allocated 
Change 
Change % 
 
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑netcoreapp3.1 
1 B 
0 b 
-1 B 
-100.00% 
 
| Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | 
|---|---|---|---|---|
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 | 1.194 | 808,619.71 | 965,716.88 | 
| Benchmark | Base Allocated | Diff Allocated | Change | Change % | 
|---|---|---|---|---|
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑netcoreapp3.1 | 1 B | 60 B | 59 B | 5,900.00% | 
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 | 3 B | 4 B | 1 B | 33.33% | 
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0 | 6 B | 7 B | 1 B | 16.67% | 
| Benchmark | Base Allocated | Diff Allocated | Change | Change % | 
|---|---|---|---|---|
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑netcoreapp3.1 | 1 B | 0 b | -1 B | -100.00% | 
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | 
|---|---|---|---|---|---|---|---|---|---|
| master | OriginalCharSlice | net6.0 | 1.92ms | 6.16μs | 22.2μs | 0 | 0 | 0 | 640 KB | 
| master | OriginalCharSlice | netcoreapp3.1 | 2.11ms | 719ns | 2.59μs | 0 | 0 | 0 | 640 KB | 
| master | OriginalCharSlice | net472 | 2.64ms | 383ns | 1.43μs | 100 | 0 | 0 | 641.95 KB | 
| master | OptimizedCharSlice | net6.0 | 1.45ms | 120ns | 465ns | 0 | 0 | 0 | 6 B | 
| master | OptimizedCharSlice | netcoreapp3.1 | 1.72ms | 294ns | 1.14μs | 0 | 0 | 0 | 1 B | 
| master | OptimizedCharSlice | net472 | 1.96ms | 456ns | 1.77μs | 0 | 0 | 0 | 73 B | 
| master | OptimizedCharSliceWithPool | net6.0 | 809μs | 43.9ns | 170ns | 0 | 0 | 0 | 3 B | 
| master | OptimizedCharSliceWithPool | netcoreapp3.1 | 866μs | 80.2ns | 311ns | 0 | 0 | 0 | 1 B | 
| master | OptimizedCharSliceWithPool | net472 | 1.27ms | 97.5ns | 378ns | 0 | 0 | 0 | 47 B | 
| #7715 | OriginalCharSlice | net6.0 | 1.91ms | 937ns | 3.25μs | 0 | 0 | 0 | 640 KB | 
| #7715 | OriginalCharSlice | netcoreapp3.1 | 2.08ms | 9.17μs | 33.1μs | 0 | 0 | 0 | 640 KB | 
| #7715 | OriginalCharSlice | net472 | 2.61ms | 225ns | 811ns | 100 | 0 | 0 | 641.95 KB | 
| #7715 | OptimizedCharSlice | net6.0 | 1.34ms | 420ns | 1.57μs | 0 | 0 | 0 | 7 B | 
| #7715 | OptimizedCharSlice | netcoreapp3.1 | 1.67ms | 549ns | 2.13μs | 0 | 0 | 0 | 60 B | 
| #7715 | OptimizedCharSlice | net472 | 1.99ms | 292ns | 1.13μs | 0 | 0 | 0 | 73 B | 
| #7715 | OptimizedCharSliceWithPool | net6.0 | 966μs | 41.4ns | 155ns | 0 | 0 | 0 | 4 B | 
| #7715 | OptimizedCharSliceWithPool | netcoreapp3.1 | 799μs | 128ns | 478ns | 0 | 0 | 0 | 0 b | 
| #7715 | OptimizedCharSliceWithPool | net472 | 1.18ms | 69.6ns | 261ns | 0 | 0 | 0 | 47 B | 
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️ 
More allocations ⚠️  in #7715
Benchmark 
Base Allocated 
Diff Allocated 
Change 
Change % 
 
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 
41.77 KB 
42.4 KB 
626 B 
1.50% 
 
| Benchmark | Base Allocated | Diff Allocated | Change | Change % | 
|---|---|---|---|---|
| Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 | 41.77 KB | 42.4 KB | 626 B | 1.50% | 
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | 
|---|---|---|---|---|---|---|---|---|---|
| master | WriteAndFlushEnrichedTraces | net6.0 | 694μs | 3.68μs | 19.8μs | 0 | 0 | 0 | 41.66 KB | 
| master | WriteAndFlushEnrichedTraces | netcoreapp3.1 | 796μs | 4.32μs | 25.2μs | 0 | 0 | 0 | 41.77 KB | 
| master | WriteAndFlushEnrichedTraces | net472 | 988μs | 5.59μs | 37.1μs | 4.81 | 0 | 0 | 56.05 KB | 
| #7715 | WriteAndFlushEnrichedTraces | net6.0 | 695μs | 970ns | 3.63μs | 0 | 0 | 0 | 41.8 KB | 
| #7715 | WriteAndFlushEnrichedTraces | netcoreapp3.1 | 734μs | 3.45μs | 14.2μs | 0 | 0 | 0 | 42.4 KB | 
| #7715 | WriteAndFlushEnrichedTraces | net472 | 874μs | 1.79μs | 6.7μs | 8.33 | 0 | 0 | 56.29 KB | 
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | 
|---|---|---|---|---|---|---|---|---|---|
| master | ExecuteNonQuery | net6.0 | 1.93μs | 2.54ns | 9.82ns | 0 | 0 | 0 | 1.02 KB | 
| master | ExecuteNonQuery | netcoreapp3.1 | 2.67μs | 12.5ns | 48.5ns | 0 | 0 | 0 | 1.02 KB | 
| master | ExecuteNonQuery | net472 | 2.88μs | 2.14ns | 8.28ns | 0.156 | 0.0142 | 0 | 987 B | 
| #7715 | ExecuteNonQuery | net6.0 | 1.94μs | 4.96ns | 19.2ns | 0 | 0 | 0 | 1.02 KB | 
| #7715 | ExecuteNonQuery | netcoreapp3.1 | 2.61μs | 10.9ns | 40.8ns | 0 | 0 | 0 | 1.02 KB | 
| #7715 | ExecuteNonQuery | net472 | 2.83μs | 3.68ns | 14.2ns | 0.156 | 0.0142 | 0 | 987 B | 
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | 
|---|---|---|---|---|---|---|---|---|---|
| master | CallElasticsearch | net6.0 | 1.72μs | 8.21ns | 33.8ns | 0 | 0 | 0 | 1.03 KB | 
| master | CallElasticsearch | netcoreapp3.1 | 2.25μs | 10.8ns | 47ns | 0 | 0 | 0 | 1.03 KB | 
| master | CallElasticsearch | net472 | 3.67μs | 7.08ns | 27.4ns | 0.165 | 0 | 0 | 1.04 KB | 
| master | CallElasticsearchAsync | net6.0 | 1.85μs | 8.14ns | 31.5ns | 0 | 0 | 0 | 1.01 KB | 
| master | CallElasticsearchAsync | netcoreapp3.1 | 2.51μs | 11.2ns | 43.3ns | 0 | 0 | 0 | 1.08 KB | 
| master | CallElasticsearchAsync | net472 | 3.68μs | 1.95ns | 7.57ns | 0.166 | 0 | 0 | 1.1 KB | 
| #7715 | CallElasticsearch | net6.0 | 1.74μs | 3.41ns | 13.2ns | 0 | 0 | 0 | 1.03 KB | 
| #7715 | CallElasticsearch | netcoreapp3.1 | 2.24μs | 0.784ns | 3.04ns | 0 | 0 | 0 | 1.03 KB | 
| #7715 | CallElasticsearch | net472 | 3.58μs | 3.93ns | 15.2ns | 0.163 | 0 | 0 | 1.04 KB | 
| #7715 | CallElasticsearchAsync | net6.0 | 1.87μs | 4.06ns | 15.7ns | 0 | 0 | 0 | 1.01 KB | 
| #7715 | CallElasticsearchAsync | netcoreapp3.1 | 2.36μs | 8.82ns | 33ns | 0 | 0 | 0 | 1.08 KB | 
| #7715 | CallElasticsearchAsync | net472 | 3.65μs | 2.43ns | 9.4ns | 0.164 | 0 | 0 | 1.1 KB | 
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | 
|---|---|---|---|---|---|---|---|---|---|
| master | ExecuteAsync | net6.0 | 1.86μs | 1.15ns | 4.14ns | 0 | 0 | 0 | 952 B | 
| master | ExecuteAsync | netcoreapp3.1 | 2.55μs | 3.97ns | 15.4ns | 0 | 0 | 0 | 952 B | 
| master | ExecuteAsync | net472 | 2.64μs | 3.4ns | 13.2ns | 0.145 | 0 | 0 | 915 B | 
| #7715 | ExecuteAsync | net6.0 | 1.82μs | 0.33ns | 1.19ns | 0 | 0 | 0 | 952 B | 
| #7715 | ExecuteAsync | netcoreapp3.1 | 2.52μs | 11.5ns | 44.5ns | 0 | 0 | 0 | 952 B | 
| #7715 | ExecuteAsync | net472 | 2.58μs | 0.825ns | 3.2ns | 0.141 | 0 | 0 | 915 B | 
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | 
|---|---|---|---|---|---|---|---|---|---|
| master | SendAsync | net6.0 | 6.99μs | 10.3ns | 39.7ns | 0 | 0 | 0 | 2.36 KB | 
| master | SendAsync | netcoreapp3.1 | 8.63μs | 27.6ns | 107ns | 0 | 0 | 0 | 2.9 KB | 
| master | SendAsync | net472 | 12.1μs | 13.8ns | 53.6ns | 0.484 | 0 | 0 | 3.18 KB | 
| #7715 | SendAsync | net6.0 | 7.06μs | 13.1ns | 50.7ns | 0 | 0 | 0 | 2.36 KB | 
| #7715 | SendAsync | netcoreapp3.1 | 8.47μs | 25.6ns | 99ns | 0 | 0 | 0 | 2.9 KB | 
| #7715 | SendAsync | net472 | 12.1μs | 7.73ns | 28.9ns | 0.484 | 0 | 0 | 3.18 KB | 
Benchmarks.Trace.Iast.StringAspectsBenchmark - Faster 🎉 More allocations ⚠️ 
Faster 🎉 in #7715
Benchmark 
base/diff 
Base Median (ns) 
Diff Median (ns) 
Modality 
 
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 
1.142 
513,700.00 
449,850.00 
 
More allocations ⚠️  in #7715
Benchmark 
Base Allocated 
Diff Allocated 
Change 
Change % 
 
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 
43.22 KB 
45.55 KB 
2.34 KB 
5.41% 
 
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 
278.53 KB 
286.72 KB 
8.19 KB 
2.94% 
 
Fewer allocations 🎉 in #7715
Benchmark 
Base Allocated 
Diff Allocated 
Change 
Change % 
 
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 
44.42 KB 
43.5 KB 
-920 B 
-2.07% 
 
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 
279.38 KB 
259.62 KB 
-19.76 KB 
-7.07% 
 
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 
65.54 KB 
57.34 KB 
-8.19 KB 
-12.50% 
 
| Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | 
|---|---|---|---|---|
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 | 1.142 | 513,700.00 | 449,850.00 | 
| Benchmark | Base Allocated | Diff Allocated | Change | Change % | 
|---|---|---|---|---|
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 | 43.22 KB | 45.55 KB | 2.34 KB | 5.41% | 
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 | 278.53 KB | 286.72 KB | 8.19 KB | 2.94% | 
| Benchmark | Base Allocated | Diff Allocated | Change | Change % | 
|---|---|---|---|---|
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 | 44.42 KB | 43.5 KB | -920 B | -2.07% | 
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 | 279.38 KB | 259.62 KB | -19.76 KB | -7.07% | 
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 | 65.54 KB | 57.34 KB | -8.19 KB | -12.50% | 
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | 
|---|---|---|---|---|---|---|---|---|---|
| master | StringConcatBenchmark | net6.0 | 44.2μs | 244ns | 1.38μs | 0 | 0 | 0 | 44.42 KB | 
| master | StringConcatBenchmark | netcoreapp3.1 | 48μs | 264ns | 1.59μs | 0 | 0 | 0 | 43.22 KB | 
| master | StringConcatBenchmark | net472 | 57.7μs | 250ns | 935ns | 0 | 0 | 0 | 65.54 KB | 
| master | StringConcatAspectBenchmark | net6.0 | 516μs | 2.61μs | 11.4μs | 0 | 0 | 0 | 279.38 KB | 
| master | StringConcatAspectBenchmark | netcoreapp3.1 | 524μs | 2.28μs | 7.9μs | 0 | 0 | 0 | 274.46 KB | 
| master | StringConcatAspectBenchmark | net472 | 405μs | 1.94μs | 13.6μs | 0 | 0 | 0 | 278.53 KB | 
| #7715 | StringConcatBenchmark | net6.0 | 43.9μs | 368ns | 3.49μs | 0 | 0 | 0 | 43.5 KB | 
| #7715 | StringConcatBenchmark | netcoreapp3.1 | 56.1μs | 712ns | 6.94μs | 0 | 0 | 0 | 45.55 KB | 
| #7715 | StringConcatBenchmark | net472 | 57.9μs | 187ns | 676ns | 0 | 0 | 0 | 57.34 KB | 
| #7715 | StringConcatAspectBenchmark | net6.0 | 452μs | 2.15μs | 9.12μs | 0 | 0 | 0 | 259.62 KB | 
| #7715 | StringConcatAspectBenchmark | netcoreapp3.1 | 520μs | 1.78μs | 6.16μs | 0 | 0 | 0 | 274.18 KB | 
| #7715 | StringConcatAspectBenchmark | net472 | 404μs | 2.07μs | 9.69μs | 0 | 0 | 0 | 286.72 KB | 
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | 
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog | net6.0 | 2.66μs | 3.23ns | 12.5ns | 0 | 0 | 0 | 1.7 KB | 
| master | EnrichedLog | netcoreapp3.1 | 3.64μs | 3.74ns | 14.5ns | 0 | 0 | 0 | 1.7 KB | 
| master | EnrichedLog | net472 | 3.83μs | 3.73ns | 14.5ns | 0.251 | 0 | 0 | 1.64 KB | 
| #7715 | EnrichedLog | net6.0 | 2.61μs | 13.7ns | 65.6ns | 0 | 0 | 0 | 1.7 KB | 
| #7715 | EnrichedLog | netcoreapp3.1 | 3.64μs | 18.4ns | 82.2ns | 0 | 0 | 0 | 1.7 KB | 
| #7715 | EnrichedLog | net472 | 3.92μs | 1.89ns | 7.34ns | 0.254 | 0 | 0 | 1.64 KB | 
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | 
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog | net6.0 | 123μs | 85.3ns | 295ns | 0 | 0 | 0 | 4.31 KB | 
| master | EnrichedLog | netcoreapp3.1 | 128μs | 101ns | 366ns | 0 | 0 | 0 | 4.31 KB | 
| master | EnrichedLog | net472 | 167μs | 46.8ns | 181ns | 0 | 0 | 0 | 4.51 KB | 
| #7715 | EnrichedLog | net6.0 | 123μs | 54.7ns | 212ns | 0 | 0 | 0 | 4.31 KB | 
| #7715 | EnrichedLog | netcoreapp3.1 | 129μs | 161ns | 624ns | 0 | 0 | 0 | 4.31 KB | 
| #7715 | EnrichedLog | net472 | 167μs | 145ns | 542ns | 0 | 0 | 0 | 4.52 KB | 
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | 
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog | net6.0 | 4.91μs | 3.54ns | 12.8ns | 0 | 0 | 0 | 2.26 KB | 
| master | EnrichedLog | netcoreapp3.1 | 6.75μs | 4.74ns | 17.1ns | 0 | 0 | 0 | 2.26 KB | 
| master | EnrichedLog | net472 | 7.64μs | 5ns | 19.4ns | 0.304 | 0 | 0 | 2.08 KB | 
| #7715 | EnrichedLog | net6.0 | 4.89μs | 8.41ns | 32.6ns | 0 | 0 | 0 | 2.26 KB | 
| #7715 | EnrichedLog | netcoreapp3.1 | 6.67μs | 24.3ns | 93.9ns | 0 | 0 | 0 | 2.26 KB | 
| #7715 | EnrichedLog | net472 | 7.63μs | 8.49ns | 32.9ns | 0.304 | 0 | 0 | 2.08 KB | 
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | 
|---|---|---|---|---|---|---|---|---|---|
| master | SendReceive | net6.0 | 2.03μs | 9.96ns | 42.3ns | 0 | 0 | 0 | 1.2 KB | 
| master | SendReceive | netcoreapp3.1 | 2.73μs | 10ns | 38.9ns | 0 | 0 | 0 | 1.2 KB | 
| master | SendReceive | net472 | 3.05μs | 3.47ns | 13.5ns | 0.182 | 0 | 0 | 1.2 KB | 
| #7715 | SendReceive | net6.0 | 2μs | 10.5ns | 51.3ns | 0 | 0 | 0 | 1.2 KB | 
| #7715 | SendReceive | netcoreapp3.1 | 2.53μs | 12.1ns | 49.8ns | 0 | 0 | 0 | 1.2 KB | 
| #7715 | SendReceive | net472 | 3.07μs | 1.36ns | 5.1ns | 0.184 | 0 | 0 | 1.2 KB | 
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | 
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog | net6.0 | 4.35μs | 5.72ns | 22.1ns | 0 | 0 | 0 | 1.58 KB | 
| master | EnrichedLog | netcoreapp3.1 | 5.52μs | 13.9ns | 54ns | 0 | 0 | 0 | 1.63 KB | 
| master | EnrichedLog | net472 | 6.52μs | 11.1ns | 42.9ns | 0.293 | 0 | 0 | 2.03 KB | 
| #7715 | EnrichedLog | net6.0 | 4.36μs | 17.9ns | 69.2ns | 0 | 0 | 0 | 1.58 KB | 
| #7715 | EnrichedLog | netcoreapp3.1 | 5.63μs | 16.2ns | 62.8ns | 0 | 0 | 0 | 1.63 KB | 
| #7715 | EnrichedLog | net472 | 6.55μs | 7.05ns | 26.4ns | 0.292 | 0 | 0 | 2.03 KB | 
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | 
|---|---|---|---|---|---|---|---|---|---|
| master | StartFinishSpan | net6.0 | 760ns | 3.58ns | 13.9ns | 0 | 0 | 0 | 576 B | 
| master | StartFinishSpan | netcoreapp3.1 | 979ns | 0.249ns | 0.862ns | 0 | 0 | 0 | 576 B | 
| master | StartFinishSpan | net472 | 950ns | 0.0648ns | 0.234ns | 0.0907 | 0 | 0 | 578 B | 
| master | StartFinishScope | net6.0 | 923ns | 4.32ns | 16.7ns | 0 | 0 | 0 | 696 B | 
| master | StartFinishScope | netcoreapp3.1 | 1.22μs | 5.63ns | 21.8ns | 0 | 0 | 0 | 696 B | 
| master | StartFinishScope | net472 | 1.15μs | 1.13ns | 4.36ns | 0.103 | 0 | 0 | 658 B | 
| #7715 | StartFinishSpan | net6.0 | 815ns | 0.274ns | 1.06ns | 0 | 0 | 0 | 576 B | 
| #7715 | StartFinishSpan | netcoreapp3.1 | 966ns | 5.09ns | 24.9ns | 0 | 0 | 0 | 576 B | 
| #7715 | StartFinishSpan | net472 | 947ns | 0.275ns | 1.03ns | 0.0902 | 0 | 0 | 578 B | 
| #7715 | StartFinishScope | net6.0 | 924ns | 3.65ns | 14.1ns | 0 | 0 | 0 | 696 B | 
| #7715 | StartFinishScope | netcoreapp3.1 | 1.2μs | 5.5ns | 22ns | 0 | 0 | 0 | 696 B | 
| #7715 | StartFinishScope | net472 | 1.14μs | 0.255ns | 0.987ns | 0.103 | 0 | 0 | 658 B | 
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | 
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin | net6.0 | 1.05μs | 5.01ns | 20ns | 0 | 0 | 0 | 696 B | 
| master | RunOnMethodBegin | netcoreapp3.1 | 1.39μs | 7.19ns | 33ns | 0 | 0 | 0 | 696 B | 
| master | RunOnMethodBegin | net472 | 1.48μs | 0.718ns | 2.59ns | 0.103 | 0 | 0 | 658 B | 
| #7715 | RunOnMethodBegin | net6.0 | 1.05μs | 5.39ns | 25.9ns | 0 | 0 | 0 | 696 B | 
| #7715 | RunOnMethodBegin | netcoreapp3.1 | 1.45μs | 6.97ns | 27.9ns | 0 | 0 | 0 | 696 B | 
| #7715 | RunOnMethodBegin | net472 | 1.42μs | 1.06ns | 4.09ns | 0.0999 | 0 | 0 | 658 B | 
59c4d11    to
    4c74919      
    Compare
  
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Summary of changes
Write process tags to profiles
Reason for change
OLDAIDM-701
AIDM-195
Implementation details
All the C++ code is AI generated, fed with PR #4298
Test coverage
Other details