Skip to content

Conversation

@gjulianm
Copy link
Collaborator

@gjulianm gjulianm commented Oct 28, 2025

What does this PR do?

Adds the timer_create syscall to the allowed syscalls list in the system-probe seccomp profile.

Motivation

The Go runtime now uses the timer_create syscall for CPU profiling as of Go 1.23+ (see
golang/go@8cfd8c3). This PR adds it to the seccomp list so that profiling data is more accurate

Additional Notes

Minimum Agent Versions

No minimum version changes required.

Describe your test plan

Ensure that the timer_create syscall is present in the configmap data.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or
    dependencies
  • PR has a milestone or the qa/skip-qa label

@gjulianm gjulianm added bug Something isn't working qa/skip-qa labels Oct 28, 2025
@gjulianm gjulianm marked this pull request as ready for review October 28, 2025 16:30
@gjulianm gjulianm requested a review from a team as a code owner October 28, 2025 16:30
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 38.05%. Comparing base (c350dbf) to head (7cdcfa6).

Files with missing lines Patch % Lines
...controller/datadogagent/component/agent/default.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2274      +/-   ##
==========================================
- Coverage   38.05%   38.05%   -0.01%     
==========================================
  Files         255      255              
  Lines       20949    20950       +1     
==========================================
  Hits         7972     7972              
- Misses      12359    12360       +1     
  Partials      618      618              
Flag Coverage Δ
unittests 38.05% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...controller/datadogagent/component/agent/default.go 6.77% <0.00%> (-0.02%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c350dbf...7cdcfa6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gjulianm gjulianm added this to the v1.21.0 milestone Oct 28, 2025
@gjulianm
Copy link
Collaborator Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Oct 28, 2025

View all feedbacks in Devflow UI.

2025-10-28 17:02:36 UTC ℹ️ Start processing command /merge


2025-10-28 17:02:42 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 0s (p90).


2025-10-28 19:03:27 UTCMergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build 80526783 took longer than expected. The current limit for the base branch 'main' is 120 minutes.

Copy link
Collaborator Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Oct 29, 2025

View all feedbacks in Devflow UI.

2025-10-29 10:36:07 UTC ℹ️ Start processing command /merge


2025-10-29 10:36:12 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 0s (p90).


2025-10-29 12:36:54 UTCMergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build 80589704 took longer than expected. The current limit for the base branch 'main' is 120 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working mergequeue-status: rejected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants