Skip to content

Conversation

@khewonc
Copy link
Contributor

@khewonc khewonc commented Oct 22, 2025

What does this PR do?

Remove create strategy since it is not used internally, which was the main use case for this.
Original PR: #1365 (it was renamed after this)

Motivation

https://datadoghq.atlassian.net/browse/AGENTONB-2600

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Test that DAPs still work properly on a local cluster: https://github.com/DataDog/datadog-operator/blob/main/docs/datadog_agent_profiles.md

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@khewonc khewonc added this to the v1.21.0 milestone Oct 22, 2025
@khewonc khewonc requested review from a team as code owners October 22, 2025 19:59
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.01%. Comparing base (9a933b7) to head (c14e23a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2255      +/-   ##
==========================================
- Coverage   39.10%   39.01%   -0.10%     
==========================================
  Files         254      254              
  Lines       26329    26195     -134     
==========================================
- Hits        10297    10219      -78     
+ Misses      15418    15368      -50     
+ Partials      614      608       -6     
Flag Coverage Δ
unittests 39.01% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...controller/datadogagent/controller_reconcile_v2.go 56.96% <100.00%> (-0.18%) ⬇️
...ler/datadogagent/controller_reconcile_v2_common.go 32.62% <ø> (-1.21%) ⬇️
pkg/agentprofile/agent_profile.go 77.18% <100.00%> (+5.15%) ⬆️
pkg/agentprofile/status.go 72.91% <ø> (+8.44%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a933b7...c14e23a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants