-
Couldn't load subscription status.
- Fork 128
add GKE e2e provisioner #1936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add GKE e2e provisioner #1936
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1936 +/- ##
=======================================
Coverage 50.36% 50.36%
=======================================
Files 228 228
Lines 21774 21774
=======================================
Hits 10967 10967
Misses 10259 10259
Partials 548 548
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
dfedd16 to
0a946d1
Compare
test/e2e/tests/utils/utils.go
Outdated
| assert.NotEmpty(c, podsList.Items) | ||
| assert.Len(c, podsList.Items, numPods) | ||
| t.Log("PODSLIST COUNT: ", len(podsList.Items)) | ||
| for pod, _ := range podsList.Items { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔵 Code Quality Violation
| for pod, _ := range podsList.Items { | |
| for pod := range podsList.Items { |
Unnecessary blank identifier (...read more)
In Go, when using range iterations or receiving values from channels, it is recommended to avoid assigning the iteration or received value to the blank identifier _. Instead, it is preferred to omit the assignment entirely.
Here's why it is best to use for range s {}, x = someMap[key], and <-ch instead of using the blank identifier _:
- Clarity and Readability: By omitting the assignment entirely, it makes the code more readable and self-explanatory. Using
_can introduce confusion and make it less clear what the purpose of the assignment is or if the value is discarded intentionally or accidentally. - Avoiding Variable Pollution: Using
_as an assignment can unnecessarily pollute the variable space. Although Go allows the use of the blank identifier_to disregard a value, it is a good practice to avoid introducing unnecessary variables, especially if they are never used. - Linting and static analysis: Some linting tools and static analyzers may flag the use of
varName = _as an indication of accidental assignment or failure to handle errors or returned values properly. Removing these assignments eliminates such warnings or false-positive detections.
For example, consider the following code snippets:
for _ = range aSlice {}
x, _ = something()
_ = <- aChannelfor range aSlice {}
x = something()
<-aChannelBoth snippets achieve the same result, but the second one that omits the assignments using _ is preferred for its simplicity, readability, and adherence to Go's best practices.
By using for range s {}, x = someMap[key], and <-ch instead of assigning to _, you can write cleaner and more readable Go code while avoiding unnecessary variable assignments and potential confusion.
6181791 to
fadc4b3
Compare
fadc4b3 to
22aceda
Compare
a4d3824 to
9d5ab36
Compare
9c4a086 to
ae44a59
Compare
|
This pull request has been automatically marked as stale because it has not had activity in the past 15 days. It will be closed in 30 days if no further activity occurs. If this pull request is still relevant, adding a comment or pushing new commits will keep it open. Also, you can always reopen the pull request if you missed the window. Thank you for your contributions! |
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel