Skip to content

Conversation

@tbavelier
Copy link
Member

@tbavelier tbavelier commented Mar 31, 2025

What does this PR do?

Falls back to try getting leader from configmap for clusteragent even if leases are supported, in the case getting leader from lease failed

Motivation

Allows to get leader from configmap even if leases are supported in the environment, in a situation where configmap is still being used for leader election of DCA

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@tbavelier tbavelier added the enhancement New feature or request label Mar 31, 2025
@tbavelier tbavelier added this to the v1.14.0 milestone Mar 31, 2025
@tbavelier tbavelier requested a review from a team as a code owner March 31, 2025 16:06
@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2025

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.79%. Comparing base (b93f515) to head (86062da).
⚠️ Report is 153 commits behind head on main.

Files with missing lines Patch % Lines
cmd/kubectl-datadog/clusteragent/leader/leader.go 0.00% 9 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1833      +/-   ##
==========================================
- Coverage   49.80%   49.79%   -0.01%     
==========================================
  Files         221      221              
  Lines       21451    21452       +1     
==========================================
  Hits        10683    10683              
- Misses      10221    10222       +1     
  Partials      547      547              
Flag Coverage Δ
unittests 49.79% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cmd/kubectl-datadog/clusteragent/leader/leader.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b93f515...86062da. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tbavelier tbavelier changed the title [kubectl plugin] Add force-configmap flag to clusteragent [kubectl plugin] Fallback to configmap leader attempt for clusteragent if lease failed Mar 31, 2025
Copy link
Collaborator

@clamoriniere clamoriniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now we don't make a difference between lease not found or RBAC issue.
maybe a jira card can be created to track this improvement, but IMO not needed now.

thanks for the fix 🙇

@levan-m levan-m merged commit f1ad31e into main Mar 31, 2025
27 of 29 checks passed
@levan-m levan-m deleted the tbavelier/allow-force-configmap-leader-lookup branch March 31, 2025 17:20
khewonc added a commit that referenced this pull request Apr 23, 2025
* Use PodResources mount as a path instead of file (#1674)

* Use folder instead of file mount

* Fix test

* PodResourcesSocketDir->PodResourcesSocketPath

* remove unused function from merge

* nits + generate

---------

Co-authored-by: Timothée Bavelier <timothee.bavelier@datadoghq.com>

* Share common types between Autoscaler versions (#1663)

* Share common types between Autoscaler versions

* Apply suggestions from code review

Co-authored-by: Celene <celene@datadoghq.com>

---------

Co-authored-by: Timothée Bavelier <97530782+tbavelier@users.noreply.github.com>
Co-authored-by: Celene <celene@datadoghq.com>

* Bump the gh-actions-packages group with 7 updates (#1659)

Bumps the gh-actions-packages group with 7 updates:

| Package | From | To |
| --- | --- | --- |
| [actions/checkout](https://github.com/actions/checkout) | `1.2.0` | `4.2.2` |
| [actions/setup-go](https://github.com/actions/setup-go) | `1.1.3` | `5.3.0` |
| [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) | `3.2.0` | `6.1.0` |
| [github/codeql-action](https://github.com/github/codeql-action) | `2.28.1` | `3.28.8` |
| [codecov/codecov-action](https://github.com/codecov/codecov-action) | `2.1.0` | `5.3.1` |
| [softprops/action-gh-release](https://github.com/softprops/action-gh-release) | `1` | `2` |
| [rajatjindal/krew-release-bot](https://github.com/rajatjindal/krew-release-bot) | `0.0.43` | `0.0.47` |


Updates `actions/checkout` from 1.2.0 to 4.2.2
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v1.2.0...11bd719)

Updates `actions/setup-go` from 1.1.3 to 5.3.0
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v1.1.3...f111f33)

Updates `goreleaser/goreleaser-action` from 3.2.0 to 6.1.0
- [Release notes](https://github.com/goreleaser/goreleaser-action/releases)
- [Commits](goreleaser/goreleaser-action@b508e2e...9ed2f89)

Updates `github/codeql-action` from 2.28.1 to 3.28.8
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@b8d3b6e...dd74661)

Updates `codecov/codecov-action` from 2.1.0 to 5.3.1
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@f32b3a3...13ce06b)

Updates `softprops/action-gh-release` from 1 to 2
- [Release notes](https://github.com/softprops/action-gh-release/releases)
- [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md)
- [Commits](softprops/action-gh-release@de2c0eb...c95fe14)

Updates `rajatjindal/krew-release-bot` from 0.0.43 to 0.0.47
- [Release notes](https://github.com/rajatjindal/krew-release-bot/releases)
- [Changelog](https://github.com/rajatjindal/krew-release-bot/blob/main/.goreleaser.yml)
- [Commits](rajatjindal/krew-release-bot@92da038...3d9faef)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: gh-actions-packages
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: gh-actions-packages
- dependency-name: goreleaser/goreleaser-action
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: gh-actions-packages
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: gh-actions-packages
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: gh-actions-packages
- dependency-name: softprops/action-gh-release
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: gh-actions-packages
- dependency-name: rajatjindal/krew-release-bot
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: gh-actions-packages
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Timothée Bavelier <97530782+tbavelier@users.noreply.github.com>
Co-authored-by: Fanny Jiang <fanny.jiang@datadoghq.com>

* use gci lint + install tools (#1691)

* [CECO-1860][DatadogGenericResource] Add monitor support (#1635)

* refactor based on #1602

* fix finalizer test following refactor

* remove dead code following refactor

* move id conversion functions to utils.go from notebooks.go

* move synthetics status update function to synthetics.go from utils.go (and associated test)

* follow-up to 7b2552e: moving away from specific notebook id conversion to generic

* nit: fix update error message

* add monitor to supported generic resource controller

* move id conversion functions to utils.go from notebooks.go

* move synthetics status update function to synthetics.go from utils.go (and associated test)

* follow-up to 7b2552e: moving away from specific notebook id conversion to generic

* nit: fix update error message

* lint

---------

Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>

* (documentation) Update DatadogGenericResource contribute documentation (#1695)

* correct jsonSpec + use fake monitor IDs

* Update dev doc

* Update docs/datadog_generic_resource_dev.md

Co-authored-by: Heston Hoffman <hestonhoffman@gmail.com>

* doc review

---------

Co-authored-by: Heston Hoffman <hestonhoffman@gmail.com>

* update default fips-proxy image version to 1.1.7 (#1699)

* Fix parsing group resource to allow groups with periods (#1697)

* Fix parsing group resource to allow groups with periods

* remove GetVerb

* Update bundle and manager config from v1.12 (#1701)

* Fix some names in common Autoscaler types (#1706)

* Add Gitlab job to run redhat preflight check on rcs  (#1709)

* new job to run preflight check w/o submission

* more logging

* change log level to debug

* remove testing conditions

* depend on publish public tag + test

* undo testing changes

* update podresources mount to only be in agent container (#1716)

* feat(error tracking): add core agent and error tracking standalone settings (#1553)

* Add core agent and error tracking standalone settings

* Simplify bool condition

* set up defaults

* add tests

* add example

* fix tests

* rework into ErrorTracking.Mode

* rework into single errorTrackingStandalone variable

* fix typo

* update generated files

* doc fixes

---------

Co-authored-by: Eloy Toro <eloy.toro@datadoghq.com>
Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>
Co-authored-by: Levan Machablishvili <levan.machablishvili@datadoghq.com>

* bump golang to 1.23.6 (#1720)

* bump default agent images to 7.63.0 (#1722)

* Update OTel agent image (#1728)

* Update OTel agent image

Use `7.63.0-ot-beta-jmx` instead of nightly image. This will need to be updated once OTel agent is GA (7.64.0), as the ot-beta image will be discontinued.

* Update pkg/defaulting/images.go

Co-authored-by: Celene <celene@datadoghq.com>

---------

Co-authored-by: Celene <celene@datadoghq.com>

* Generate fips image compiled with Go boringcrypto (#1731)

* checkpoint: builds both with cli arg

* fips image for main build

* add jobs for generating fips image and publishing main-fips tag

* fix main fips job references

* fix param naming

* fix: set `DD_ADP_ENABLED` to `true` on Core Agent when ADP enabled (#1725)

* api/datadoghq/v2alpha1: add support for SSI targets (#1670)

* api/datadoghq/v2alpha1: add support for SSI targets

* error cleanup

* revert example

* Update docs/configuration.v2alpha1.md

Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com>

* feat(ssi): add tracer config options

This commit adds the tracer config options we've just added.

* Fix tests

* Address PR feedback

* Address PR feedback

* add log to warn for non-compatible agent version

* fix

* fix lint

* fix tests

* update types

---------

Co-authored-by: Mark Spicer <mark@markspicer.me>
Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com>
Co-authored-by: Mark Spicer <mark.spicer@datadoghq.com>
Co-authored-by: Celene <celene@datadoghq.com>

* Add gitlab workflows to publish fips images (#1732)

* Add gitlab workflows to publish fips images

* Add back -w -s ldflags

* bump kustomize to 5.6.0 (#1735)

* Update check_preflight_redhat_image image tag (#1740)

* Remove IsReadOnly from dashboard (#1742)

* bump 7.63.2 (#1744)

* Pass fips image tag to internal fips template (#1748)

* Support agent sidecar securityContext (#1733)

* add doc page for slos (#1757)

* bump 7.63.3 (#1760)

* update default fips-proxy image version to 1.1.8 (#1763)

* small fix for error handling (#1768)

* Fix internal fips image tag (#1770)

* [CECO-2004] Always run e2e tests on release branches (#1764)

* always run e2e tests on rc branches (test)

* testing

* remove testing rules

* use default provenance and oci media type (#1772)

* Gate profile canary waits behind annotation (#1758)

* use partof label to cleanup only owned ds/deployments (#1767)

* Handle Daemonset notFound when deleting Agent DS (#1779)

* Handle Daemonset notFound when deleting Agent DS

* Update internal/controller/datadogagent/controller_v2_test.go

Co-authored-by: Celene <celene@datadoghq.com>

---------

Co-authored-by: Celene <celene@datadoghq.com>

* Pass TMPL_RELEASE_TAG in internal image build workflow (#1782)

* Clean up integration tests (#1715)

* Revert "Pass TMPL_RELEASE_TAG in internal image build workflow (#1782)" (#1788)

This reverts commit 780f696.

* DOCS-10284: editing operator docs (#1755)

* initial pass at docs edits

* finishing edit

* Apply suggestions from code review

Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com>
Co-authored-by: Celene <celene@datadoghq.com>

* edits

* Apply suggestions from code review

Co-authored-by: Celene <celene@datadoghq.com>

* edits

---------

Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com>
Co-authored-by: Celene <celene@datadoghq.com>

* [feature/eventcollection] Don't set anything for the node agent (#1781)

Co-authored-by: fanny-jiang <fanny.jiang@datadoghq.com>

* [component/agent/default] Don't set DD_LEADER_ELECTION (#1787)

Co-authored-by: fanny-jiang <fanny.jiang@datadoghq.com>

* fix typo in license dir on operator image (#1793)

* fix typo

* remove un-necessary mkdir

* enhancement: per-container image override support (#1730)

* add support for Service Discovery network stats collection (#1780)

* add config option for Service Discovery network stats collection

* fix default value

* Update internal/controller/datadogagent/feature/servicediscovery/feature.go

Co-authored-by: Celene <celene@datadoghq.com>

* fix CR

---------

Co-authored-by: Celene <celene@datadoghq.com>

* [tooling] use latest preflight version (#1797)

* fixing links (#1799)

* [CECO-2084] Handle custom versions (not following semver) as always above minVersion (#1786)

* handle main/latest as always above minVersion

* return true when unable to convert to semver

* Change Operator base image from ubi-minimal to ubi-micro (#1798)

* Change Operator base image from ubi-minimal to ubi-micro

* switch check image to ubi-micro

* Update correct file

* update bundles following 1.13.0 release (#1806)

* [tooling][gitlab] separate publishing latest images, tweak community operators job (#1803)

* separate publishing latest images, tweak community operators job

* update from review

* sort git tag by semver (#1807)

* servicediscovery: add mounts of module and src volumes (#1804)

* [documentation] add example for configuring extra confd (#1811)

* [documentation] add example for configuring extra confd

* address feedback

* small edit

* Add backport PR GHA (#1809)

* testing backport pr

* testing conditions run without merge

* more testing conditions

* trying app token

* test on branch

* add workflow dispatch

* switch to pull_request for testing

* cleaning up

* trigger workflow in 2 scenarios

1. pr labeled after merge, merge action
2. pr merged but label is already present

* copy ca certs from ubi minimal (#1820)

* [autoscaling] Make objectives required CRD v1alpha2 (#1819)

* Support evaluation window option for monitors (#1702)

Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>

* [CECO-2004] Run e2e tests in more conditions (#1777)

* reorder e2e stage jobs

* reorder stages

* update conditions for e2e

* change conditional for conductor triggered job

* always run e2e tests otherwise

* add logging, cleanup

* remove debugging lines

* nit

* extend ksmcheck waitFor duration

* extend check time more

* add error tracking standalone var to the core agent (#1818)

* Allow to configure SlowStartAdditiveIncrease (#1821)

* Update backport PR conditions (#1826)

* update run action conditions

* noop change for testing (#1822)

* remove create app token step

* update to only run when labeling a merged pr

* noop to test backport pr (#1824)

* testing (#1825)

* change test-id to integer string id (#1828)

* Add validations to DatadogMonitorSpec (#1694)

Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>

* [e2e] Disable e2e tests on nightly build (#1829)

* disable e2e on nightly

* Update .gitlab-ci.yml

Co-authored-by: Timothée Bavelier <97530782+tbavelier@users.noreply.github.com>

---------

Co-authored-by: Timothée Bavelier <97530782+tbavelier@users.noreply.github.com>

* [CECO-2005] Configure additional k8s versions for e2e CI (#1769)

* always run e2e tests on rc branches (test)

* testing

* remove testing rules

* add k8s versions and testing rules

* add tags for runner type

* run tests on ubuntu 2004

* change order of VMOption

* remove ubuntu 20.04 vm and old versions

* mistake with merge conflict

---------

Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>

* Enable pod-resources mount only with GPU monitoring enabled (#1801)

* Enable podResources socket only with GPU monitoring feature

* Add unit tests

* Move env var

* Update internal/controller/datadogagent/feature/gpu/feature_test.go

Co-authored-by: Celene <celene@datadoghq.com>

* fix linter

---------

Co-authored-by: Celene <celene@datadoghq.com>
Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>

* (chore) E2E: use m5.xlarge instead of default t3.medium (#1831)

* use m5.xlarge instead of default t3.medium

* enable gitlab timestamps

* modify aws provisioner

* update default fips-proxy image version to 1.1.9 (#1830)

Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>

* Add checksd volume to ccr init-config (#1823)

Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>

* Add validations to DatadogDashboardSpec (#1704)

Co-authored-by: Sarah Wang <sarah.wang@datadoghq.com>

* [kubectl plugin] Fallback to configmap leader attempt for `clusteragent` if lease failed (#1833)

* add force-configmap flag

* Revert "add force-configmap flag"

This reverts commit b1b2cd4.

* fallback instead of using flag

* Bump Agent to 7.64.1 (#1834)

* [defaulting] clean up unused image methods (#1839)

* [defaulting] use jmx images for agent and cluster checks runner

* clean up jmx methods instead

* Add permission for PDB (#1841)

Orchestrator needs it since 7.64.1

* [autoscaling] Move to v1alpha2 as only supported version for Cluster Agent 7.64+ (#1845)

* Add flag (#1840)

* sign with githubops containers key (#1850)

* Bump Agent to 7.64.3 (#1847)

* Bump Agent to 7.64.2

* Bump Agent to 7.64.3

* [tooling] Add milestone to automated backport PR  (#1856)

* automatically add milestone to backport pr

* pin action by hash

* [datadogpodautoscalers] Add local fallback policy (#1759)

* Fix missing apostrophe in dpa json

* Add fallback policy and types

* Generate files

* Fix typo in apply policy name

* Use new fallback policy type

* Update fallback policy to only expose necessary options

* Update comment to reflect how pod resource objectives are defined

* Use bool for enabling fallback to reflect binary option

* fixup! Use bool for enabling fallback to reflect binary option

* Use fallback as top level for flexibility to add other fallback modes in future

* Fix SlowStartAdditiveIncrease (#1857)

* update seccomp profile to fix k3s (#1862)

Fixes #1726

* Add external as a valid recommendation source (#1867)

* [CECO-2114] Fix backport automated milestone  (#1860)

* testing backport milestone addition

* copy backport pr

* pin to hash

* remove some debug lines

* Include golangci-lint in fmt Make target (#1714)

* Include golangci-lint in fmt Make target

* fix formatting issues

---------

Co-authored-by: Sarah Wang <sarah.wang@datadoghq.com>
Co-authored-by: Sarah Wang <sarah.wang2009@gmail.com>

* Add seccomp changes from #1862

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Guillermo Julián <gjulianm@users.noreply.github.com>
Co-authored-by: Timothée Bavelier <timothee.bavelier@datadoghq.com>
Co-authored-by: Vincent Boulineau <58430298+vboulineau@users.noreply.github.com>
Co-authored-by: Timothée Bavelier <97530782+tbavelier@users.noreply.github.com>
Co-authored-by: Celene <celene@datadoghq.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Fanny Jiang <fanny.jiang@datadoghq.com>
Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>
Co-authored-by: Heston Hoffman <hestonhoffman@gmail.com>
Co-authored-by: louis-cqrl <93274433+louis-cqrl@users.noreply.github.com>
Co-authored-by: Adel Haj Hassan <41540817+adel121@users.noreply.github.com>
Co-authored-by: Sarah Wang <sarah.wang@datadoghq.com>
Co-authored-by: Gianluca Bortoli <giallogiallo93@gmail.com>
Co-authored-by: Eloy Toro <eloy.toro@datadoghq.com>
Co-authored-by: Levan Machablishvili <levan.machablishvili@datadoghq.com>
Co-authored-by: Mackenzie <63265430+mackjmr@users.noreply.github.com>
Co-authored-by: Toby Lawrence <tobz@users.noreply.github.com>
Co-authored-by: Kyle Nusbaum <kjn@9project.net>
Co-authored-by: Mark Spicer <mark@markspicer.me>
Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com>
Co-authored-by: Mark Spicer <mark.spicer@datadoghq.com>
Co-authored-by: Keisuke Umegaki <41987730+keisku@users.noreply.github.com>
Co-authored-by: Shuhei Kitagawa <shuheiktgw@users.noreply.github.com>
Co-authored-by: cecilia saixue watt <cecilia.watt@datadoghq.com>
Co-authored-by: David Ortiz <david.ortiz@datadoghq.com>
Co-authored-by: Guillaume Pagnoux <Yumasi@users.noreply.github.com>
Co-authored-by: Eloy Toro <eloytoro@gmail.com>
Co-authored-by: AliDatadog <125997632+AliDatadog@users.noreply.github.com>
Co-authored-by: Joachim <jbartosik@gmail.com>
Co-authored-by: Jennifer Chen <32009013+jennchenn@users.noreply.github.com>
Co-authored-by: Bryce Kahle <bryce.kahle@datadoghq.com>
Co-authored-by: Sarah Wang <sarah.wang2009@gmail.com>
levan-m added a commit that referenced this pull request May 1, 2025
* update podresources mount to only be in agent container (#1716)

* feat(error tracking): add core agent and error tracking standalone settings (#1553)

* Add core agent and error tracking standalone settings

* Simplify bool condition

* set up defaults

* add tests

* add example

* fix tests

* rework into ErrorTracking.Mode

* rework into single errorTrackingStandalone variable

* fix typo

* update generated files

* doc fixes

---------

Co-authored-by: Eloy Toro <eloy.toro@datadoghq.com>
Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>
Co-authored-by: Levan Machablishvili <levan.machablishvili@datadoghq.com>

* bump golang to 1.23.6 (#1720)

* bump default agent images to 7.63.0 (#1722)

* Update OTel agent image (#1728)

* Update OTel agent image

Use `7.63.0-ot-beta-jmx` instead of nightly image. This will need to be updated once OTel agent is GA (7.64.0), as the ot-beta image will be discontinued.

* Update pkg/defaulting/images.go

Co-authored-by: Celene <celene@datadoghq.com>

---------

Co-authored-by: Celene <celene@datadoghq.com>

* Generate fips image compiled with Go boringcrypto (#1731)

* checkpoint: builds both with cli arg

* fips image for main build

* add jobs for generating fips image and publishing main-fips tag

* fix main fips job references

* fix param naming

* fix: set `DD_ADP_ENABLED` to `true` on Core Agent when ADP enabled (#1725)

* api/datadoghq/v2alpha1: add support for SSI targets (#1670)

* api/datadoghq/v2alpha1: add support for SSI targets

* error cleanup

* revert example

* Update docs/configuration.v2alpha1.md

Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com>

* feat(ssi): add tracer config options

This commit adds the tracer config options we've just added.

* Fix tests

* Address PR feedback

* Address PR feedback

* add log to warn for non-compatible agent version

* fix

* fix lint

* fix tests

* update types

---------

Co-authored-by: Mark Spicer <mark@markspicer.me>
Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com>
Co-authored-by: Mark Spicer <mark.spicer@datadoghq.com>
Co-authored-by: Celene <celene@datadoghq.com>

* Add gitlab workflows to publish fips images (#1732)

* Add gitlab workflows to publish fips images

* Add back -w -s ldflags

* bump kustomize to 5.6.0 (#1735)

* Update check_preflight_redhat_image image tag (#1740)

* Remove IsReadOnly from dashboard (#1742)

* bump 7.63.2 (#1744)

* Pass fips image tag to internal fips template (#1748)

* Support agent sidecar securityContext (#1733)

* add doc page for slos (#1757)

* bump 7.63.3 (#1760)

* update default fips-proxy image version to 1.1.8 (#1763)

* small fix for error handling (#1768)

* Fix internal fips image tag (#1770)

* [CECO-2004] Always run e2e tests on release branches (#1764)

* always run e2e tests on rc branches (test)

* testing

* remove testing rules

* use default provenance and oci media type (#1772)

* Gate profile canary waits behind annotation (#1758)

* use partof label to cleanup only owned ds/deployments (#1767)

* Handle Daemonset notFound when deleting Agent DS (#1779)

* Handle Daemonset notFound when deleting Agent DS

* Update internal/controller/datadogagent/controller_v2_test.go

Co-authored-by: Celene <celene@datadoghq.com>

---------

Co-authored-by: Celene <celene@datadoghq.com>

* Pass TMPL_RELEASE_TAG in internal image build workflow (#1782)

* Clean up integration tests (#1715)

* Revert "Pass TMPL_RELEASE_TAG in internal image build workflow (#1782)" (#1788)

This reverts commit 780f696.

* DOCS-10284: editing operator docs (#1755)

* initial pass at docs edits

* finishing edit

* Apply suggestions from code review

Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com>
Co-authored-by: Celene <celene@datadoghq.com>

* edits

* Apply suggestions from code review

Co-authored-by: Celene <celene@datadoghq.com>

* edits

---------

Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com>
Co-authored-by: Celene <celene@datadoghq.com>

* [feature/eventcollection] Don't set anything for the node agent (#1781)

Co-authored-by: fanny-jiang <fanny.jiang@datadoghq.com>

* [component/agent/default] Don't set DD_LEADER_ELECTION (#1787)

Co-authored-by: fanny-jiang <fanny.jiang@datadoghq.com>

* fix typo in license dir on operator image (#1793)

* fix typo

* remove un-necessary mkdir

* enhancement: per-container image override support (#1730)

* add support for Service Discovery network stats collection (#1780)

* add config option for Service Discovery network stats collection

* fix default value

* Update internal/controller/datadogagent/feature/servicediscovery/feature.go

Co-authored-by: Celene <celene@datadoghq.com>

* fix CR

---------

Co-authored-by: Celene <celene@datadoghq.com>

* [tooling] use latest preflight version (#1797)

* fixing links (#1799)

* [CECO-2084] Handle custom versions (not following semver) as always above minVersion (#1786)

* handle main/latest as always above minVersion

* return true when unable to convert to semver

* Change Operator base image from ubi-minimal to ubi-micro (#1798)

* Change Operator base image from ubi-minimal to ubi-micro

* switch check image to ubi-micro

* Update correct file

* update bundles following 1.13.0 release (#1806)

* [tooling][gitlab] separate publishing latest images, tweak community operators job (#1803)

* separate publishing latest images, tweak community operators job

* update from review

* sort git tag by semver (#1807)

* servicediscovery: add mounts of module and src volumes (#1804)

* [documentation] add example for configuring extra confd (#1811)

* [documentation] add example for configuring extra confd

* address feedback

* small edit

* Add backport PR GHA (#1809)

* testing backport pr

* testing conditions run without merge

* more testing conditions

* trying app token

* test on branch

* add workflow dispatch

* switch to pull_request for testing

* cleaning up

* trigger workflow in 2 scenarios

1. pr labeled after merge, merge action
2. pr merged but label is already present

* copy ca certs from ubi minimal (#1820)

* [autoscaling] Make objectives required CRD v1alpha2 (#1819)

* Support evaluation window option for monitors (#1702)

Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>

* [CECO-2004] Run e2e tests in more conditions (#1777)

* reorder e2e stage jobs

* reorder stages

* update conditions for e2e

* change conditional for conductor triggered job

* always run e2e tests otherwise

* add logging, cleanup

* remove debugging lines

* nit

* extend ksmcheck waitFor duration

* extend check time more

* add error tracking standalone var to the core agent (#1818)

* Allow to configure SlowStartAdditiveIncrease (#1821)

* Update backport PR conditions (#1826)

* update run action conditions

* noop change for testing (#1822)

* remove create app token step

* update to only run when labeling a merged pr

* noop to test backport pr (#1824)

* testing (#1825)

* change test-id to integer string id (#1828)

* Add validations to DatadogMonitorSpec (#1694)

Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>

* [e2e] Disable e2e tests on nightly build (#1829)

* disable e2e on nightly

* Update .gitlab-ci.yml

Co-authored-by: Timothée Bavelier <97530782+tbavelier@users.noreply.github.com>

---------

Co-authored-by: Timothée Bavelier <97530782+tbavelier@users.noreply.github.com>

* [CECO-2005] Configure additional k8s versions for e2e CI (#1769)

* always run e2e tests on rc branches (test)

* testing

* remove testing rules

* add k8s versions and testing rules

* add tags for runner type

* run tests on ubuntu 2004

* change order of VMOption

* remove ubuntu 20.04 vm and old versions

* mistake with merge conflict

---------

Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>

* Enable pod-resources mount only with GPU monitoring enabled (#1801)

* Enable podResources socket only with GPU monitoring feature

* Add unit tests

* Move env var

* Update internal/controller/datadogagent/feature/gpu/feature_test.go

Co-authored-by: Celene <celene@datadoghq.com>

* fix linter

---------

Co-authored-by: Celene <celene@datadoghq.com>
Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>

* (chore) E2E: use m5.xlarge instead of default t3.medium (#1831)

* use m5.xlarge instead of default t3.medium

* enable gitlab timestamps

* modify aws provisioner

* update default fips-proxy image version to 1.1.9 (#1830)

Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>

* Add checksd volume to ccr init-config (#1823)

Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>

* Add validations to DatadogDashboardSpec (#1704)

Co-authored-by: Sarah Wang <sarah.wang@datadoghq.com>

* [kubectl plugin] Fallback to configmap leader attempt for `clusteragent` if lease failed (#1833)

* add force-configmap flag

* Revert "add force-configmap flag"

This reverts commit b1b2cd4.

* fallback instead of using flag

* Bump Agent to 7.64.1 (#1834)

* [defaulting] clean up unused image methods (#1839)

* [defaulting] use jmx images for agent and cluster checks runner

* clean up jmx methods instead

* Add permission for PDB (#1841)

Orchestrator needs it since 7.64.1

* [autoscaling] Move to v1alpha2 as only supported version for Cluster Agent 7.64+ (#1845)

* Add flag (#1840)

* sign with githubops containers key (#1850)

* Bump Agent to 7.64.3 (#1847)

* Bump Agent to 7.64.2

* Bump Agent to 7.64.3

* [tooling] Add milestone to automated backport PR  (#1856)

* automatically add milestone to backport pr

* pin action by hash

* [datadogpodautoscalers] Add local fallback policy (#1759)

* Fix missing apostrophe in dpa json

* Add fallback policy and types

* Generate files

* Fix typo in apply policy name

* Use new fallback policy type

* Update fallback policy to only expose necessary options

* Update comment to reflect how pod resource objectives are defined

* Use bool for enabling fallback to reflect binary option

* fixup! Use bool for enabling fallback to reflect binary option

* Use fallback as top level for flexibility to add other fallback modes in future

* Fix SlowStartAdditiveIncrease (#1857)

* update seccomp profile to fix k3s (#1862)

Fixes #1726

* Add external as a valid recommendation source (#1867)

* [CECO-2114] Fix backport automated milestone  (#1860)

* testing backport milestone addition

* copy backport pr

* pin to hash

* remove some debug lines

* Include golangci-lint in fmt Make target (#1714)

* Include golangci-lint in fmt Make target

* fix formatting issues

---------

Co-authored-by: Sarah Wang <sarah.wang@datadoghq.com>
Co-authored-by: Sarah Wang <sarah.wang2009@gmail.com>

* fix SBOM feature env vars applying to all agents instead of just core (#1761)

* fix SBOM feature env vars applying to all agents instead of just core

* fix unit tests

* SBOM: fix host root volumes for non-OS scans support (#1846)

* SBOM: mount the full host root, instead of re-building it from package managers

* fix tests

* Delete v1beta1 CRDs from repo (#1874)

* Delete v1beta1 CRDs from repo

* cleanup patch-crd.sh

* readme clean-up (#1872)

* readme clean-up

* address feedback

* Update README.md

Co-authored-by: Sarah Wang <sarah.wang@datadoghq.com>

* Update README.md

Co-authored-by: Sarah Wang <sarah.wang@datadoghq.com>

---------

Co-authored-by: Sarah Wang <sarah.wang@datadoghq.com>

* Fix missing SlowStartAdditiveIncrease (#1882)

* Refactor DatadogAgent reconciler (#1878)

* use helpers + some unit tests (#1746)
* Use object reconciler (#1778)
* Move creds and dca token out of enabledefault (#1789)
* Allow disabling features that are enabled by default (#1792)
* Remove monitoredObject (#1795)
* [Remote config feature] Agent & DCA are not required components, but need to be configured (#1805)
* Refactor global (#1808)
* [dda] update dependency fx names, move GetImage (#1842)
* Remove rbac from enabledefault (#1827)
* Move install info and seccomp out of enabledefault feature (#1866)

---------

Co-authored-by: khewonc <39867936+khewonc@users.noreply.github.com>
Co-authored-by: Celene <celene@datadoghq.com>
Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>

* Add permission for endpointslices (#1885)

* Add permission for endpointslices

* add kubebuilder makers

* add cursor to gitignore, e.g. rules (#1886)

* Remove deprecated dependencies (#1712)

Co-authored-by: Sarah Wang <sarah.wang@datadoghq.com>
Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>

* fix import

* fix assert.Len

---------

Co-authored-by: Celene <celene@datadoghq.com>
Co-authored-by: Gianluca Bortoli <giallogiallo93@gmail.com>
Co-authored-by: Eloy Toro <eloy.toro@datadoghq.com>
Co-authored-by: Mackenzie <63265430+mackjmr@users.noreply.github.com>
Co-authored-by: Toby Lawrence <tobz@users.noreply.github.com>
Co-authored-by: Kyle Nusbaum <kjn@9project.net>
Co-authored-by: Mark Spicer <mark@markspicer.me>
Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com>
Co-authored-by: Mark Spicer <mark.spicer@datadoghq.com>
Co-authored-by: Sarah Wang <sarah.wang@datadoghq.com>
Co-authored-by: khewonc <39867936+khewonc@users.noreply.github.com>
Co-authored-by: Timothée Bavelier <97530782+tbavelier@users.noreply.github.com>
Co-authored-by: Keisuke Umegaki <41987730+keisku@users.noreply.github.com>
Co-authored-by: louis-cqrl <93274433+louis-cqrl@users.noreply.github.com>
Co-authored-by: Shuhei Kitagawa <shuheiktgw@users.noreply.github.com>
Co-authored-by: cecilia saixue watt <cecilia.watt@datadoghq.com>
Co-authored-by: David Ortiz <david.ortiz@datadoghq.com>
Co-authored-by: fanny-jiang <fanny.jiang@datadoghq.com>
Co-authored-by: Guillaume Pagnoux <Yumasi@users.noreply.github.com>
Co-authored-by: Vincent Boulineau <58430298+vboulineau@users.noreply.github.com>
Co-authored-by: Eloy Toro <eloytoro@gmail.com>
Co-authored-by: AliDatadog <125997632+AliDatadog@users.noreply.github.com>
Co-authored-by: Guillermo Julián <gjulianm@users.noreply.github.com>
Co-authored-by: Joachim <jbartosik@gmail.com>
Co-authored-by: Jennifer Chen <32009013+jennchenn@users.noreply.github.com>
Co-authored-by: Bryce Kahle <bryce.kahle@datadoghq.com>
Co-authored-by: Sarah Wang <sarah.wang2009@gmail.com>
Co-authored-by: Paul Cacheux <paul.cacheux@datadoghq.com>
Co-authored-by: Kangyi LI <kangyi.li@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants