[SVLS-7763] create (beta) container app instrument command #1933
+2,406
−140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 7b6aef2 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
ava-silver
commented
Oct 28, 2025
| sidecarContainer === undefined || | ||
| sidecarContainer.image !== SIDECAR_IMAGE || | ||
| sidecarContainer.targetPort !== SIDECAR_PORT || | ||
| sidecarContainer.targetPort !== String(SIDECAR_PORT) || |
There was a problem hiding this comment.
the constant is now a number so we have to convert back here due to azure's spec
ava-silver
commented
Oct 28, 2025
| envVars.DD_TAGS = config.extraTags | ||
| } | ||
| // Get base environment variables | ||
| let envVars = getBaseEnvVars(config) |
There was a problem hiding this comment.
the variables shared across web apps and container apps are created here now
ava-silver
changed the title
ava-silver
force-pushed
the
ava.silver/svls-7763/initial-at-container-app-instrument
branch
from
6a63ec8 to
51932a4
Compare
ava-silver
force-pushed
the
ava.silver/svls-7763/initial-at-container-app-instrument
branch
from
c79c0c5 to
cfe9f25
Compare
ava-silver
added
enhancement
|
Created DOCS-12487 for Docs team review! |
domalessi
added
the
editorial review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Creates the new
container-app instrumentcommand, which adds the sidecar to an existing container app. This will support customers using container apps who are not using terraform, and would like to programmatically set up their applications.For now, this will be in beta until the full command is ready.
How?
Refactors a lot of the helpers used in the
aaspackage, and some of the constants used in thecloud-runpackage, so we can use them for container apps as well, and adds the instrument command for container apps.In a later PR, i'll do some more refactoring to see how much we can consolidate cloud run and container apps so we can simplify the instrumentation logic (since they both run on kubernetes)
Review checklist