add include parameter to On-Call team rules test
#2582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![api-clients-generation-pipeline[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/3908
branch
3 times, most recently
from
bb42a97 to
969f4a1
Compare
| @@ -30,13 +32,13 @@ def openapi_types(_): | |||
| "data": "data", | |||
| } | |||
|
|
|||
| def __init__(self_, data: RoutingRuleRelationshipsPolicyData, **kwargs): | |||
| def __init__(self_, data: Union[RoutingRuleRelationshipsPolicyData, UnsetType] = unset, **kwargs): | |||
There was a problem hiding this comment.
🔴 Code Quality Violation
Suggested change
| def __init__(self_, data: Union[RoutingRuleRelationshipsPolicyData, UnsetType] = unset, **kwargs): | |
| def __init__(self, data: Union[RoutingRuleRelationshipsPolicyData, UnsetType] = unset, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/3908
branch
7 times, most recently
from
626f033 to
2c35e78
Compare
| @@ -25,15 +32,15 @@ def openapi_types(_): | |||
| "workspace": "workspace", | |||
| } | |||
|
|
|||
| def __init__(self_, channel: str, type: str, workspace: str, **kwargs): | |||
| def __init__(self_, channel: str, type: SendSlackMessageActionType, workspace: str, **kwargs): | |||
There was a problem hiding this comment.
🔴 Code Quality Violation
Suggested change
| def __init__(self_, channel: str, type: SendSlackMessageActionType, workspace: str, **kwargs): | |
| def __init__(self, channel: str, type: SendSlackMessageActionType, workspace: str, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
| @@ -27,7 +34,7 @@ def openapi_types(_): | |||
| "type": "type", | |||
| } | |||
|
|
|||
| def __init__(self_, channel: str, team: str, tenant: str, type: str, **kwargs): | |||
| def __init__(self_, channel: str, team: str, tenant: str, type: SendTeamsMessageActionType, **kwargs): | |||
There was a problem hiding this comment.
🔴 Code Quality Violation
Suggested change
| def __init__(self_, channel: str, team: str, tenant: str, type: SendTeamsMessageActionType, **kwargs): | |
| def __init__(self, channel: str, team: str, tenant: str, type: SendTeamsMessageActionType, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
amaskara-dd
approved these changes
May 27, 2025
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/3908
branch
from
2c35e78 to
87a4f73
Compare
api-clients-generation-pipeline
bot
deleted the
datadog-api-spec/generated/3908
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See DataDog/datadog-api-spec#3908
Test branch datadog-api-spec/test/bndbsh/oncall-include